From: Moritz Fischer <mdf@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
trix@redhat.com, mdf@kernel.org, p.pisati@gmail.com,
atull@kernel.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: machxo2-spi: return an error on failure
Date: Wed, 11 Aug 2021 04:29:15 -0700 [thread overview]
Message-ID: <YRO0izb18fMEdxWH@archbook> (raw)
In-Reply-To: <20210810185116.GR22532@kadam>
On Tue, Aug 10, 2021 at 09:51:16PM +0300, Dan Carpenter wrote:
> On Tue, Aug 10, 2021 at 07:06:09PM +0200, Greg KH wrote:
> > On Tue, Aug 10, 2021 at 09:40:36AM -0700, trix@redhat.com wrote:
> > > From: Tom Rix <trix@redhat.com>
> > >
> > > Reported problem
> > >
> > > drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
> > > warn: missing error code 'ret'
> > >
> > > drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
> > > warn: missing error code 'ret'
> >
> > What reported this? What does it mean? Where was it reported?
>
> These are Smatch errors, but my bug reports don't mention Smatch so
> that's on me. I've fixed my report templated to mention Smatch now.
>
> regards,
> dan carepenter
>
>
Applied with slightly reworded commit-message to 'fixes' branch.
Thanks,
Moritz
prev parent reply other threads:[~2021-08-11 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 16:40 [PATCH] fpga: machxo2-spi: return an error on failure trix
2021-08-10 17:06 ` Greg KH
2021-08-10 18:51 ` Dan Carpenter
2021-08-11 11:29 ` Moritz Fischer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRO0izb18fMEdxWH@archbook \
--to=mdf@kernel.org \
--cc=atull@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.pisati@gmail.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).