linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fpga: machxo2-spi: return an error on failure
@ 2021-08-10 16:40 trix
  2021-08-10 17:06 ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: trix @ 2021-08-10 16:40 UTC (permalink / raw)
  To: mdf, p.pisati, atull, gregkh
  Cc: linux-fpga, linux-kernel, Tom Rix, Dan Carpenter

From: Tom Rix <trix@redhat.com>

Reported problem

	drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
	warn: missing error code 'ret'

	drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
	warn: missing error code 'ret'

Earlier successes leave 'ret' in a non error state, so these errors are
not reported.  So set ret to -EINVAL before going to the error handler.

Fixes: 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/fpga/machxo2-spi.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c
index 1afb41aa20d71..b4a530a31302f 100644
--- a/drivers/fpga/machxo2-spi.c
+++ b/drivers/fpga/machxo2-spi.c
@@ -225,8 +225,10 @@ static int machxo2_write_init(struct fpga_manager *mgr,
 		goto fail;
 
 	get_status(spi, &status);
-	if (test_bit(FAIL, &status))
+	if (test_bit(FAIL, &status)) {
+		ret = -EINVAL;
 		goto fail;
+	}
 	dump_status_reg(&status);
 
 	spi_message_init(&msg);
@@ -313,6 +315,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr,
 	dump_status_reg(&status);
 	if (!test_bit(DONE, &status)) {
 		machxo2_cleanup(mgr);
+		ret = -EINVAL;
 		goto fail;
 	}
 
-- 
2.26.3


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] fpga: machxo2-spi: return an error on failure
  2021-08-10 16:40 [PATCH] fpga: machxo2-spi: return an error on failure trix
@ 2021-08-10 17:06 ` Greg KH
  2021-08-10 18:51   ` Dan Carpenter
  0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2021-08-10 17:06 UTC (permalink / raw)
  To: trix; +Cc: mdf, p.pisati, atull, linux-fpga, linux-kernel, Dan Carpenter

On Tue, Aug 10, 2021 at 09:40:36AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Reported problem
> 
> 	drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
> 	warn: missing error code 'ret'
> 
> 	drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
> 	warn: missing error code 'ret'

What reported this?  What does it mean?  Where was it reported?

please be specific...

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] fpga: machxo2-spi: return an error on failure
  2021-08-10 17:06 ` Greg KH
@ 2021-08-10 18:51   ` Dan Carpenter
  2021-08-11 11:29     ` Moritz Fischer
  0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2021-08-10 18:51 UTC (permalink / raw)
  To: Greg KH; +Cc: trix, mdf, p.pisati, atull, linux-fpga, linux-kernel

On Tue, Aug 10, 2021 at 07:06:09PM +0200, Greg KH wrote:
> On Tue, Aug 10, 2021 at 09:40:36AM -0700, trix@redhat.com wrote:
> > From: Tom Rix <trix@redhat.com>
> > 
> > Reported problem
> > 
> > 	drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
> > 	warn: missing error code 'ret'
> > 
> > 	drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
> > 	warn: missing error code 'ret'
> 
> What reported this?  What does it mean?  Where was it reported?

These are Smatch errors, but my bug reports don't mention Smatch so
that's on me.  I've fixed my report templated to mention Smatch now.

regards,
dan carepenter



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] fpga: machxo2-spi: return an error on failure
  2021-08-10 18:51   ` Dan Carpenter
@ 2021-08-11 11:29     ` Moritz Fischer
  0 siblings, 0 replies; 4+ messages in thread
From: Moritz Fischer @ 2021-08-11 11:29 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Greg KH, trix, mdf, p.pisati, atull, linux-fpga, linux-kernel

On Tue, Aug 10, 2021 at 09:51:16PM +0300, Dan Carpenter wrote:
> On Tue, Aug 10, 2021 at 07:06:09PM +0200, Greg KH wrote:
> > On Tue, Aug 10, 2021 at 09:40:36AM -0700, trix@redhat.com wrote:
> > > From: Tom Rix <trix@redhat.com>
> > > 
> > > Reported problem
> > > 
> > > 	drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
> > > 	warn: missing error code 'ret'
> > > 
> > > 	drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
> > > 	warn: missing error code 'ret'
> > 
> > What reported this?  What does it mean?  Where was it reported?
> 
> These are Smatch errors, but my bug reports don't mention Smatch so
> that's on me.  I've fixed my report templated to mention Smatch now.
> 
> regards,
> dan carepenter
> 
> 
Applied with slightly reworded commit-message to 'fixes' branch.

Thanks,
Moritz

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-11 11:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-10 16:40 [PATCH] fpga: machxo2-spi: return an error on failure trix
2021-08-10 17:06 ` Greg KH
2021-08-10 18:51   ` Dan Carpenter
2021-08-11 11:29     ` Moritz Fischer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).