From: Tom Rix <trix@redhat.com>
To: Nava kishore Manne <nava.manne@xilinx.com>,
robh+dt@kernel.org, michal.simek@xilinx.com, mdf@kernel.org,
arnd@arndb.de, rajan.vaja@xilinx.com, gregkh@linuxfoundation.org,
amit.sunil.dhamne@xilinx.com, tejas.patel@xilinx.com,
zou_wei@huawei.com, lakshmi.sai.krishna.potthuri@xilinx.com,
ravi.patel@xilinx.com, iwamatsu@nigauri.org,
wendy.liang@xilinx.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org,
git@xilinx.com, chinnikishore369@gmail.com
Subject: Re: [PATCH v8 1/5] drivers: firmware: Add PDI load API support
Date: Tue, 6 Jul 2021 14:03:57 -0700 [thread overview]
Message-ID: <c2c06484-556d-1003-ad45-301e5b22210b@redhat.com> (raw)
In-Reply-To: <20210626155248.5004-2-nava.manne@xilinx.com>
On 6/26/21 8:52 AM, Nava kishore Manne wrote:
> This patch adds load PDI API support to enable full/partial PDI loading
> from linux. Programmable Device Image (PDI) is combination of headers,
> images and bitstream files to be loaded.
>
> Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> Reviewed-by: Moritz Fischer <mdf@kernel.org>
> ---
> Changes for v2:
> -Updated API Doc and commit msg.
> No functional changes.
>
> Changes for v3:
> -None.
>
> Changes for v4:
> -Rebased the changes on linux-next.
> No functional changes
>
> Changes for v5:
> -None.
>
> Changes for v6:
> -None.
>
> Changes for v7:
> -None.
>
> Changes for v8:
> -None.
>
> drivers/firmware/xilinx/zynqmp.c | 17 +++++++++++++++++
> include/linux/firmware/xlnx-zynqmp.h | 10 ++++++++++
> 2 files changed, 27 insertions(+)
>
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index 15b138326ecc..2db571da9ad8 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -1011,6 +1011,23 @@ int zynqmp_pm_set_requirement(const u32 node, const u32 capabilities,
> }
> EXPORT_SYMBOL_GPL(zynqmp_pm_set_requirement);
>
> +/**
> + * zynqmp_pm_load_pdi - Load and process PDI
> + * @src: Source device where PDI is located
> + * @address: PDI src address
> + *
> + * This function provides support to load PDI from linux
> + *
> + * Return: Returns status, either success or error+reason
> + */
> +int zynqmp_pm_load_pdi(const u32 src, const u64 address)
> +{
> + return zynqmp_pm_invoke_fn(PM_LOAD_PDI, src,
> + lower_32_bits(address),
> + upper_32_bits(address), 0, NULL);
> +}
> +EXPORT_SYMBOL_GPL(zynqmp_pm_load_pdi);
> +
> /**
> * zynqmp_pm_aes - Access AES hardware to encrypt/decrypt the data using
> * AES-GCM core.
> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
> index 9d1a5c175065..56b426fe020c 100644
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@ -52,6 +52,10 @@
> #define ZYNQMP_PM_CAPABILITY_WAKEUP 0x4U
> #define ZYNQMP_PM_CAPABILITY_UNUSABLE 0x8U
>
> +/* Loader commands */
> +#define PM_LOAD_PDI 0x701
This should be defined in enum pm_api_id
> +#define PDI_SRC_DDR 0xF
This is only used by versal_fpga_ops_write(), consider moving the
#define to versal-fpga.c
Tom
> +
> /*
> * Firmware FPGA Manager flags
> * XILINX_ZYNQMP_PM_FPGA_FULL: FPGA full reconfiguration
> @@ -411,6 +415,7 @@ int zynqmp_pm_pinctrl_get_config(const u32 pin, const u32 param,
> u32 *value);
> int zynqmp_pm_pinctrl_set_config(const u32 pin, const u32 param,
> u32 value);
> +int zynqmp_pm_load_pdi(const u32 src, const u64 address);
> #else
> static inline int zynqmp_pm_get_api_version(u32 *version)
> {
> @@ -622,6 +627,11 @@ static inline int zynqmp_pm_pinctrl_set_config(const u32 pin, const u32 param,
> {
> return -ENODEV;
> }
> +
> +static inline int zynqmp_pm_load_pdi(const u32 src, const u64 address)
> +{
> + return -ENODEV;
> +}
> #endif
>
> #endif /* __FIRMWARE_ZYNQMP_H__ */
next prev parent reply other threads:[~2021-07-06 21:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 15:52 [PATCH v8 0/5]Add Bitstream configuration support for Versal Nava kishore Manne
2021-06-26 15:52 ` [PATCH v8 1/5] drivers: firmware: Add PDI load API support Nava kishore Manne
2021-07-06 21:03 ` Tom Rix [this message]
2021-07-08 11:40 ` Nava kishore Manne
2021-06-26 15:52 ` [PATCH v8 2/5] dt-bindings: fpga: Add binding doc for versal fpga manager Nava kishore Manne
2021-06-26 15:52 ` [PATCH v8 3/5] dt-bindings: firmware: Add bindings for xilinx firmware Nava kishore Manne
2021-07-13 22:15 ` Rob Herring
2021-06-26 15:52 ` [PATCH v8 4/5] dt-bindings: firmware: Remove xlnx,zynqmp-firmware.txt file Nava kishore Manne
2021-07-06 21:09 ` Tom Rix
2021-07-08 11:42 ` Nava kishore Manne
2021-07-13 22:16 ` Rob Herring
2021-06-26 15:52 ` [PATCH v8 5/5] fpga: versal-fpga: Add versal fpga manager driver Nava kishore Manne
2021-07-06 21:34 ` Tom Rix
2021-07-08 11:57 ` Nava kishore Manne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2c06484-556d-1003-ad45-301e5b22210b@redhat.com \
--to=trix@redhat.com \
--cc=amit.sunil.dhamne@xilinx.com \
--cc=arnd@arndb.de \
--cc=chinnikishore369@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=iwamatsu@nigauri.org \
--cc=lakshmi.sai.krishna.potthuri@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=rajan.vaja@xilinx.com \
--cc=ravi.patel@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=tejas.patel@xilinx.com \
--cc=wendy.liang@xilinx.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).