linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Conor.Dooley@microchip.com>
To: <yilun.xu@intel.com>, <dengshaomin@cdjrlc.com>
Cc: <mdf@kernel.org>, <hao.wu@intel.com>,
	<linux-fpga@vger.kernel.org>, <trix@redhat.com>
Subject: Re: [PATCH] fpga: stratix10-soc: Fix comments typo
Date: Sat, 27 Aug 2022 14:46:37 +0000	[thread overview]
Message-ID: <f6a0b8a7-99cc-0974-564c-f2a215b5fc26@microchip.com> (raw)
In-Reply-To: <YwoorTXmTwOFfIwz@yilunxu-OptiPlex-7050>

On 27/08/2022 15:22, Xu Yilun wrote:
> On 2022-08-25 at 10:41:55 -0400, Shaomin Deng wrote:
>> Delete the repeated word "if" in comments.
> 
> Please don't duplicate similar patches.

It probably is not the right fix either...

> 
>>
>> Signed-off-by: Shaomin Deng <dengshaomin@cdjrlc.com>
>> ---
>>  drivers/fpga/stratix10-soc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
>> index 357cea58ec98..e4f2e83a615b 100644
>> --- a/drivers/fpga/stratix10-soc.c
>> +++ b/drivers/fpga/stratix10-soc.c
>> @@ -285,7 +285,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
>>  
>>  	/*
>>  	 * Loop waiting for buffers to be returned.  When a buffer is returned,
>> -	 * reuse it to send more data or free if if all data has been sent.
>> +	 * reuse it to send more data or free if all data has been sent.

s/free if if/free it if

Not sure if the cdjrlc people are scripting these duplicate word removals
but if so, they should check the output before sending b/c this seems to
happen a lot.

Thanks,
Conor.

>>  	 */
>>  	while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
>>  		reinit_completion(&priv->status_return_completion);
>> -- 
>> 2.35.1
>>

  reply	other threads:[~2022-08-27 14:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25 14:41 [PATCH] fpga: stratix10-soc: Fix comments typo Shaomin Deng
2022-08-27 14:22 ` Xu Yilun
2022-08-27 14:46   ` Conor.Dooley [this message]
2022-08-29  1:41     ` Xu Yilun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6a0b8a7-99cc-0974-564c-f2a215b5fc26@microchip.com \
    --to=conor.dooley@microchip.com \
    --cc=dengshaomin@cdjrlc.com \
    --cc=hao.wu@intel.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).