From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org,
Satya Tangirala <satyat@google.com>,
Paul Crowley <paulcrowley@google.com>,
Paul Lawrence <paullawrence@google.com>,
"Theodore Y . Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH 3/3] f2fs: add support for INLINE_CRYPT_OPTIMIZED encryption policies
Date: Tue, 22 Oct 2019 09:43:16 -0700 [thread overview]
Message-ID: <20191022164316.GA88771@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <20191021230355.23136-4-ebiggers@kernel.org>
On 10/21, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> f2fs inode numbers are stable across filesystem resizing, and f2fs inode
> and file logical block numbers are always 32-bit. So f2fs can always
> support INLINE_CRYPT_OPTIMIZED encryption policies. Wire up the needed
> fscrypt_operations to declare support.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/super.c | 26 ++++++++++++++++++++------
> 1 file changed, 20 insertions(+), 6 deletions(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 1443cee158633..851ac95229263 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -2308,13 +2308,27 @@ static bool f2fs_dummy_context(struct inode *inode)
> return DUMMY_ENCRYPTION_ENABLED(F2FS_I_SB(inode));
> }
>
> +static bool f2fs_has_stable_inodes(struct super_block *sb)
> +{
> + return true;
> +}
> +
> +static void f2fs_get_ino_and_lblk_bits(struct super_block *sb,
> + int *ino_bits_ret, int *lblk_bits_ret)
> +{
> + *ino_bits_ret = 8 * sizeof(nid_t);
> + *lblk_bits_ret = 8 * sizeof(block_t);
> +}
> +
> static const struct fscrypt_operations f2fs_cryptops = {
> - .key_prefix = "f2fs:",
> - .get_context = f2fs_get_context,
> - .set_context = f2fs_set_context,
> - .dummy_context = f2fs_dummy_context,
> - .empty_dir = f2fs_empty_dir,
> - .max_namelen = F2FS_NAME_LEN,
> + .key_prefix = "f2fs:",
> + .get_context = f2fs_get_context,
> + .set_context = f2fs_set_context,
> + .dummy_context = f2fs_dummy_context,
> + .empty_dir = f2fs_empty_dir,
> + .max_namelen = F2FS_NAME_LEN,
> + .has_stable_inodes = f2fs_has_stable_inodes,
> + .get_ino_and_lblk_bits = f2fs_get_ino_and_lblk_bits,
> };
> #endif
>
> --
> 2.23.0.866.gb869b98d4c-goog
prev parent reply other threads:[~2019-10-22 16:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 23:03 [PATCH 0/3] fscrypt: support for inline-encryption-optimized policies Eric Biggers
2019-10-21 23:03 ` [PATCH 1/3] fscrypt: add " Eric Biggers
2019-10-22 5:27 ` Dave Chinner
2019-10-22 6:00 ` Eric Biggers
2019-10-22 13:30 ` Theodore Y. Ts'o
2019-10-22 16:15 ` Eric Biggers
2019-10-23 9:27 ` Christoph Hellwig
2019-10-23 12:57 ` Theodore Y. Ts'o
2019-10-24 1:27 ` Christoph Hellwig
2019-10-24 2:44 ` Eric Biggers
2019-10-24 7:04 ` Christoph Hellwig
2019-10-24 9:54 ` Paul Crowley
2019-10-23 9:28 ` Christoph Hellwig
2019-10-21 23:03 ` [PATCH 2/3] ext4: add support for INLINE_CRYPT_OPTIMIZED encryption policies Eric Biggers
2019-10-22 13:37 ` Theodore Y. Ts'o
2019-10-22 16:37 ` Eric Biggers
2019-10-21 23:03 ` [PATCH 3/3] f2fs: " Eric Biggers
2019-10-22 16:43 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022164316.GA88771@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=paulcrowley@google.com \
--cc=paullawrence@google.com \
--cc=satyat@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).