From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Satya Tangirala <satyat@google.com>,
linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/4] f2fs: add inline encryption support
Date: Thu, 18 Jun 2020 11:13:57 -0700 [thread overview]
Message-ID: <20200618181357.GC2957@sol.localdomain> (raw)
In-Reply-To: <5e78e1be-f948-d54c-d28e-50f1f0a92ab3@huawei.com>
Hi Chao,
On Thu, Jun 18, 2020 at 06:06:02PM +0800, Chao Yu wrote:
> > @@ -936,8 +972,11 @@ void f2fs_submit_page_write(struct f2fs_io_info *fio)
> >
> > inc_page_count(sbi, WB_DATA_TYPE(bio_page));
> >
> > - if (io->bio && !io_is_mergeable(sbi, io->bio, io, fio,
> > - io->last_block_in_bio, fio->new_blkaddr))
> > + if (io->bio &&
> > + (!io_is_mergeable(sbi, io->bio, io, fio, io->last_block_in_bio,
> > + fio->new_blkaddr) ||
> > + !f2fs_crypt_mergeable_bio(io->bio, fio->page->mapping->host,
> > + fio->page->index, fio)))
>
> bio_page->index, fio)))
>
> > __submit_merged_bio(io);
> > alloc_new:
> > if (io->bio == NULL) {
> > @@ -949,6 +988,8 @@ void f2fs_submit_page_write(struct f2fs_io_info *fio)
> > goto skip;
> > }
> > io->bio = __bio_alloc(fio, BIO_MAX_PAGES);
> > + f2fs_set_bio_crypt_ctx(io->bio, fio->page->mapping->host,
> > + fio->page->index, fio, GFP_NOIO);
>
> bio_page->index, fio, GFP_NOIO);
>
We're using ->mapping->host and ->index. Ordinarily that would mean the page
needs to be a pagecache page. But bio_page can also be a compressed page or a
bounce page containing fs-layer encrypted contents.
Is your suggestion to keep using fio->page->mapping->host (since encrypted pages
don't have a mapping), but start using bio_page->index (since f2fs apparently
*does* set ->index for compressed pages, and if the file uses fs-layer
encryption then f2fs_set_bio_crypt_ctx() won't use the index anyway)?
Does this mean the code is currently broken for compression + inline encryption
because it's using the wrong ->index? I think the answer is no, since
f2fs_write_compressed_pages() will still pass the first 'nr_cpages' pagecache
pages along with the compressed pages. In that case, your suggestion would be a
cleanup rather than a fix?
It would be helpful if there was an f2fs mount option to auto-enable compression
on all files (similar to how test_dummy_encryption auto-enables encryption on
all files) so that it could be tested more easily.
- Eric
next prev parent reply other threads:[~2020-06-18 18:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 7:57 [PATCH 0/4] Inline Encryption Support for fscrypt Satya Tangirala
2020-06-17 7:57 ` [PATCH 1/4] fs: introduce SB_INLINECRYPT Satya Tangirala
2020-06-17 17:46 ` Jaegeuk Kim
2020-06-18 1:19 ` Dave Chinner
2020-06-18 3:19 ` Eric Biggers
2020-06-23 0:46 ` Dave Chinner
2020-06-23 1:50 ` [f2fs-dev] " Eric Biggers
2020-06-24 0:55 ` Dave Chinner
2020-06-17 7:57 ` [PATCH 2/4] fscrypt: add inline encryption support Satya Tangirala
2020-06-17 17:59 ` Jaegeuk Kim
2020-06-18 17:48 ` Eric Biggers
2020-06-17 7:57 ` [PATCH 3/4] f2fs: " Satya Tangirala
2020-06-17 17:56 ` Jaegeuk Kim
2020-06-18 10:06 ` Chao Yu
2020-06-18 18:13 ` Eric Biggers [this message]
2020-06-18 19:28 ` Jaegeuk Kim
2020-06-18 19:35 ` Eric Biggers
2020-06-19 2:43 ` Chao Yu
2020-06-19 2:39 ` Chao Yu
2020-06-19 4:20 ` Eric Biggers
2020-06-19 6:37 ` Chao Yu
2020-06-18 22:50 ` Eric Biggers
2020-06-17 7:57 ` [PATCH 4/4] ext4: " Satya Tangirala
2020-06-18 17:27 ` [PATCH 0/4] Inline Encryption Support for fscrypt Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618181357.GC2957@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=satyat@google.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).