* Ack to merge through DRM? WAS [PATCH v5 1/9] fs: Constify vma argument to vma_is_dax [not found] <20200303102247.4635-1-thomas_os@shipmail.org> @ 2020-03-03 10:28 ` Thomas Hellström (VMware) 2020-03-23 13:30 ` Thomas Hellström (VMware) 0 siblings, 1 reply; 2+ messages in thread From: Thomas Hellström (VMware) @ 2020-03-03 10:28 UTC (permalink / raw) To: Alexander Viro; +Cc: linux-fsdevel, linux-kernel Alexander, Could you ack merging the below patch through a DRM tree? Thanks, Thomas Hellstrom From: Thomas Hellstrom <thellstrom@vmware.com> The function is used by upcoming vma_is_special_huge() with which we want to use a const vma argument. Since for vma_is_dax() the vma argument is only dereferenced for reading, constify it. Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Michal Hocko <mhocko@suse.com> Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Cc: Ralph Campbell <rcampbell@nvidia.com> Cc: "Jérôme Glisse" <jglisse@redhat.com> Cc: "Christian König" <christian.koenig@amd.com> Cc: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com> Reviewed-by: Roland Scheidegger <sroland@vmware.com> Acked-by: Christian König <christian.koenig@amd.com> --- include/linux/fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 3cd4fe6b845e..2b38ce5b73ad 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -3391,7 +3391,7 @@ static inline bool io_is_direct(struct file *filp) return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host); } -static inline bool vma_is_dax(struct vm_area_struct *vma) +static inline bool vma_is_dax(const struct vm_area_struct *vma) { return vma->vm_file && IS_DAX(vma->vm_file->f_mapping->host); } -- 2.21.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Ack to merge through DRM? WAS [PATCH v5 1/9] fs: Constify vma argument to vma_is_dax 2020-03-03 10:28 ` Ack to merge through DRM? WAS [PATCH v5 1/9] fs: Constify vma argument to vma_is_dax Thomas Hellström (VMware) @ 2020-03-23 13:30 ` Thomas Hellström (VMware) 0 siblings, 0 replies; 2+ messages in thread From: Thomas Hellström (VMware) @ 2020-03-23 13:30 UTC (permalink / raw) To: Alexander Viro; +Cc: linux-fsdevel, linux-kernel Ping? On 3/3/20 11:28 AM, Thomas Hellström (VMware) wrote: > Alexander, > > Could you ack merging the below patch through a DRM tree? > > Thanks, > > Thomas Hellstrom > > > From: Thomas Hellstrom <thellstrom@vmware.com> > > > The function is used by upcoming vma_is_special_huge() with which we want > to use a const vma argument. Since for vma_is_dax() the vma argument is > only dereferenced for reading, constify it. > > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Michal Hocko <mhocko@suse.com> > Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Cc: Ralph Campbell <rcampbell@nvidia.com> > Cc: "Jérôme Glisse" <jglisse@redhat.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com> > Reviewed-by: Roland Scheidegger <sroland@vmware.com> > Acked-by: Christian König <christian.koenig@amd.com> > --- > include/linux/fs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 3cd4fe6b845e..2b38ce5b73ad 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -3391,7 +3391,7 @@ static inline bool io_is_direct(struct file *filp) > return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host); > } > -static inline bool vma_is_dax(struct vm_area_struct *vma) > +static inline bool vma_is_dax(const struct vm_area_struct *vma) > { > return vma->vm_file && IS_DAX(vma->vm_file->f_mapping->host); > } > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-23 13:37 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20200303102247.4635-1-thomas_os@shipmail.org> 2020-03-03 10:28 ` Ack to merge through DRM? WAS [PATCH v5 1/9] fs: Constify vma argument to vma_is_dax Thomas Hellström (VMware) 2020-03-23 13:30 ` Thomas Hellström (VMware)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).