* [PATCH] binfmt_em86: Fix incompatible pointer type
@ 2016-06-09 12:43 Daniel Wagner
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Wagner @ 2016-06-09 12:43 UTC (permalink / raw)
To: linux-kernel
Cc: linux-alpha, linux-fsdevel, Richard Henderson, Ivan Kokshaysky,
Matt Turner, Alexander Viro, Daniel Wagner
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
Since the -Wincompatible-pointer-types is reported as error, alpha
doesn't build anymore. Let's fix it in a minimal way.
fs/binfmt_em86.c:73:35: error: passing argument 2 of ‘copy_strings_kernel’ from incompatible pointer type [-Werror=incompatible-pointer-types]
retval = copy_strings_kernel(1, &i_arg, bprm);
^ ^
fs/binfmt_em86.c:77:34: error: passing argument 2 of ‘copy_strings_kernel’ from incompatible pointer type [-Werror=incompatible-pointer-types]
retval = copy_strings_kernel(1, &i_name, bprm);
^
Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
---
fs/binfmt_em86.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/binfmt_em86.c b/fs/binfmt_em86.c
index 4905385..dd2d3f0 100644
--- a/fs/binfmt_em86.c
+++ b/fs/binfmt_em86.c
@@ -24,7 +24,8 @@
static int load_em86(struct linux_binprm *bprm)
{
- char *interp, *i_name, *i_arg;
+ const char *i_name, *i_arg;
+ char *interp;
struct file * file;
int retval;
struct elfhdr elf_ex;
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] binfmt_em86: Fix incompatible pointer type
@ 2016-07-26 9:39 Daniel Wagner
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Wagner @ 2016-07-26 9:39 UTC (permalink / raw)
To: linux-kernel
Cc: linux-alpha, linux-fsdevel, Richard Henderson, Ivan Kokshaysky,
Matt Turner, Alexander Viro, Andrew Morton, Daniel Wagner
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
Since the -Wincompatible-pointer-types is reported as error, alpha
doesn't build anymore. Let's fix it in a minimal way.
fs/binfmt_em86.c:73:35: error: passing argument 2 of ‘copy_strings_kernel’ from incompatible pointer type [-Werror=incompatible-pointer-types]
retval = copy_strings_kernel(1, &i_arg, bprm);
^ ^
fs/binfmt_em86.c:77:34: error: passing argument 2 of ‘copy_strings_kernel’ from incompatible pointer type [-Werror=incompatible-pointer-types]
retval = copy_strings_kernel(1, &i_name, bprm);
^
Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
---
Hi,
Here is the same patch again. The 0day bot is nagging me that
I broke that and up to now it's still not fixed.
Andrew, are you willing to pick this one up?
cheers,
daniel
fs/binfmt_em86.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/binfmt_em86.c b/fs/binfmt_em86.c
index 4905385..dd2d3f0 100644
--- a/fs/binfmt_em86.c
+++ b/fs/binfmt_em86.c
@@ -24,7 +24,8 @@
static int load_em86(struct linux_binprm *bprm)
{
- char *interp, *i_name, *i_arg;
+ const char *i_name, *i_arg;
+ char *interp;
struct file * file;
int retval;
struct elfhdr elf_ex;
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-26 9:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-09 12:43 [PATCH] binfmt_em86: Fix incompatible pointer type Daniel Wagner
2016-07-26 9:39 Daniel Wagner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).