* [PATCH] fs: remove obsolete comment
@ 2018-06-29 8:31 Li RongQing
2018-07-19 3:22 ` 答复: " Li,Rongqing
0 siblings, 1 reply; 2+ messages in thread
From: Li RongQing @ 2018-06-29 8:31 UTC (permalink / raw)
To: linux-fsdevel; +Cc: viro
After e8e8a0c6c9b [writeback: move nr_pages == 0 logic to one
location], the nr_page argument of __wakeup_flusher_threads_bdi
has been removed, so remove this obsolete comment
After bc48f001de12225 [buffer: eliminate the need to call
free_more_memory() in __getblk_slow()], no free_more_memory
function
Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
fs/buffer.c | 2 +-
fs/fs-writeback.c | 4 ----
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index cabc045f483d..58e199da8ca0 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -924,7 +924,7 @@ grow_dev_page(struct block_device *bdev, sector_t block,
struct page *page;
struct buffer_head *bh;
sector_t end_block;
- int ret = 0; /* Will call free_more_memory() */
+ int ret = 0;
gfp_t gfp_mask;
gfp_mask = mapping_gfp_constraint(inode->i_mapping, ~__GFP_FS) | gfp;
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 471d863958bc..abafc9bd4622 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -1968,10 +1968,6 @@ void wb_workfn(struct work_struct *work)
current->flags &= ~PF_SWAPWRITE;
}
-/*
- * Start writeback of `nr_pages' pages on this bdi. If `nr_pages' is zero,
- * write back the whole world.
- */
static void __wakeup_flusher_threads_bdi(struct backing_dev_info *bdi,
enum wb_reason reason)
{
--
2.16.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* 答复: [PATCH] fs: remove obsolete comment
2018-06-29 8:31 [PATCH] fs: remove obsolete comment Li RongQing
@ 2018-07-19 3:22 ` Li,Rongqing
0 siblings, 0 replies; 2+ messages in thread
From: Li,Rongqing @ 2018-07-19 3:22 UTC (permalink / raw)
To: Li,Rongqing, linux-fsdevel; +Cc: viro
Ping
-RongQing
> -----邮件原件-----
> 发件人: linux-fsdevel-owner@vger.kernel.org [mailto:linux-fsdevel-
> owner@vger.kernel.org] 代表 Li RongQing
> 发送时间: 2018年6月29日 16:31
> 收件人: linux-fsdevel@vger.kernel.org
> 抄送: viro@zeniv.linux.org.uk
> 主题: [PATCH] fs: remove obsolete comment
>
> After e8e8a0c6c9b [writeback: move nr_pages == 0 logic to one location], the
> nr_page argument of __wakeup_flusher_threads_bdi has been removed, so
> remove this obsolete comment
>
> After bc48f001de12225 [buffer: eliminate the need to call
> free_more_memory() in __getblk_slow()], no free_more_memory function
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
> fs/buffer.c | 2 +-
> fs/fs-writeback.c | 4 ----
> 2 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index cabc045f483d..58e199da8ca0 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -924,7 +924,7 @@ grow_dev_page(struct block_device *bdev, sector_t
> block,
> struct page *page;
> struct buffer_head *bh;
> sector_t end_block;
> - int ret = 0; /* Will call free_more_memory() */
> + int ret = 0;
> gfp_t gfp_mask;
>
> gfp_mask = mapping_gfp_constraint(inode->i_mapping, ~__GFP_FS)
> | gfp; diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index
> 471d863958bc..abafc9bd4622 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -1968,10 +1968,6 @@ void wb_workfn(struct work_struct *work)
> current->flags &= ~PF_SWAPWRITE;
> }
>
> -/*
> - * Start writeback of `nr_pages' pages on this bdi. If `nr_pages' is zero,
> - * write back the whole world.
> - */
> static void __wakeup_flusher_threads_bdi(struct backing_dev_info *bdi,
> enum wb_reason reason)
> {
> --
> 2.16.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-19 4:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-29 8:31 [PATCH] fs: remove obsolete comment Li RongQing
2018-07-19 3:22 ` 答复: " Li,Rongqing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).