* [PATCH] f2fs: fix memory leak in build_directory
@ 2019-07-31 3:27 Xiaojun Wang
0 siblings, 0 replies; only message in thread
From: Xiaojun Wang @ 2019-07-31 3:27 UTC (permalink / raw)
To: linux-fsdevel, linux-f2fs-devel; +Cc: chao
This patch fix bug that variable dentries going
out of scope leaks the storage it points to.
Signed-off-by: Xiaojun Wang<wangxiaojun11@huawei.com>
---
fsck/sload.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fsck/sload.c b/fsck/sload.c
index f5a4651..e5de2e1 100644
--- a/fsck/sload.c
+++ b/fsck/sload.c
@@ -240,15 +240,18 @@ static int build_directory(struct f2fs_sb_info *sbi, const char *full_path,
ret = set_selinux_xattr(sbi, dentries[i].path,
dentries[i].ino, dentries[i].mode);
if (ret)
- return ret;
+ goto out;
+ }
+out:
+ for (i = 0; i < entries; i++) {
free(dentries[i].path);
free(dentries[i].full_path);
free((void *)dentries[i].name);
}
free(dentries);
- return 0;
+ return ret;
}
static int configure_files(void)
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-07-31 4:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-31 3:27 [PATCH] f2fs: fix memory leak in build_directory Xiaojun Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).