linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Tejun Heo <tj@kernel.org>
Cc: Eric Sandeen <sandeen@sandeen.net>,
	Fox Chen <foxhlchen@gmail.com>,
	Brice Goglin <brice.goglin@gmail.com>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	Rick Lindsley <ricklind@linux.vnet.ibm.com>,
	David Howells <dhowells@redhat.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Carlos Maiolino <cmaiolino@redhat.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH v6 7/7] kernfs: dont call d_splice_alias() under kernfs node lock
Date: Wed, 09 Jun 2021 16:52:25 +0800	[thread overview]
Message-ID: <162322874509.361452.3143376113190093370.stgit@web.messagingengine.com> (raw)
In-Reply-To: <162322846765.361452.17051755721944717990.stgit@web.messagingengine.com>

The call to d_splice_alias() in kernfs_iop_lookup() doesn't depend on
any kernfs node so there's no reason to hold the kernfs node lock when
calling it.

Signed-off-by: Ian Kent <raven@themaw.net>
---
 fs/kernfs/dir.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
index 195561c08439a..a5820a8c139a2 100644
--- a/fs/kernfs/dir.c
+++ b/fs/kernfs/dir.c
@@ -1097,7 +1097,6 @@ static struct dentry *kernfs_iop_lookup(struct inode *dir,
 					struct dentry *dentry,
 					unsigned int flags)
 {
-	struct dentry *ret;
 	struct kernfs_node *parent = dir->i_private;
 	struct kernfs_node *kn;
 	struct inode *inode = NULL;
@@ -1117,11 +1116,10 @@ static struct dentry *kernfs_iop_lookup(struct inode *dir,
 	/* Needed only for negative dentry validation */
 	if (!inode)
 		kernfs_set_rev(parent, dentry);
-	/* instantiate and hash (possibly negative) dentry */
-	ret = d_splice_alias(inode, dentry);
 	up_read(&kernfs_rwsem);
 
-	return ret;
+	/* instantiate and hash (possibly negative) dentry */
+	return d_splice_alias(inode, dentry);
 }
 
 static int kernfs_iop_mkdir(struct user_namespace *mnt_userns,



  parent reply	other threads:[~2021-06-09  8:52 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09  8:49 [PATCH v6 0/7] kernfs: proposed locking and concurrency improvement Ian Kent
2021-06-09  8:49 ` [PATCH v6 1/7] kernfs: move revalidate to be near lookup Ian Kent
2021-06-11 12:45   ` Miklos Szeredi
2021-06-09  8:49 ` [PATCH v6 2/7] kernfs: add a revision to identify directory node changes Ian Kent
2021-06-11 12:49   ` Miklos Szeredi
2021-06-11 12:56     ` Ian Kent
2021-06-11 13:11       ` Greg Kroah-Hartman
2021-06-11 13:31         ` Ian Kent
2021-06-11 14:05           ` Greg Kroah-Hartman
2021-06-11 14:16             ` Ian Kent
2021-06-09  8:50 ` [PATCH v6 3/7] kernfs: use VFS negative dentry caching Ian Kent
2021-06-11 13:07   ` Miklos Szeredi
2021-06-12  0:47     ` Ian Kent
2021-06-12  1:48       ` Al Viro
2021-06-13  1:16         ` Ian Kent
2021-06-12  0:07   ` Al Viro
2021-06-12  0:43     ` Ian Kent
2021-06-12  1:08       ` Ian Kent
2021-06-12  1:51         ` Al Viro
2021-06-13  1:57           ` Ian Kent
2021-06-09  8:50 ` [PATCH v6 4/7] kernfs: switch kernfs to use an rwsem Ian Kent
2021-06-11 13:10   ` Miklos Szeredi
2021-06-12  1:24   ` Al Viro
2021-06-09  8:51 ` [PATCH v6 5/7] kernfs: use i_lock to protect concurrent inode updates Ian Kent
2021-06-11 13:11   ` Miklos Szeredi
2021-06-12  1:45   ` Al Viro
2021-06-13  1:31     ` Ian Kent
2021-06-14  1:32     ` Ian Kent
2021-06-14  6:52       ` Ian Kent
2021-06-14  7:16         ` Ian Kent
2021-06-09  8:52 ` [PATCH v6 6/7] kernfs: add kernfs_need_inode_refresh() Ian Kent
2021-06-11 13:13   ` Miklos Szeredi
2021-06-09  8:52 ` Ian Kent [this message]
2021-06-11 13:14   ` [PATCH v6 7/7] kernfs: dont call d_splice_alias() under kernfs node lock Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162322874509.361452.3143376113190093370.stgit@web.messagingengine.com \
    --to=raven@themaw.net \
    --cc=brice.goglin@gmail.com \
    --cc=cmaiolino@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=foxhlchen@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=mtosatti@redhat.com \
    --cc=ricklind@linux.vnet.ibm.com \
    --cc=sandeen@sandeen.net \
    --cc=tj@kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).