From: Ian Kent <raven@themaw.net>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>, Eric Sandeen <sandeen@sandeen.net>,
Fox Chen <foxhlchen@gmail.com>,
Brice Goglin <brice.goglin@gmail.com>,
Rick Lindsley <ricklind@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Marcelo Tosatti <mtosatti@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Carlos Maiolino <cmaiolino@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 3/7] kernfs: use VFS negative dentry caching
Date: Sat, 12 Jun 2021 08:43:13 +0800 [thread overview]
Message-ID: <2ee74cbed729d66a38a5c7de9c4608d02fb89f26.camel@themaw.net> (raw)
In-Reply-To: <YMP6topegaTXGNgC@zeniv-ca.linux.org.uk>
On Sat, 2021-06-12 at 00:07 +0000, Al Viro wrote:
> On Wed, Jun 09, 2021 at 04:50:27PM +0800, Ian Kent wrote:
>
> > + if (d_really_is_negative(dentry)) {
> > + struct dentry *d_parent = dget_parent(dentry);
> > + struct kernfs_node *parent;
>
> What the hell is dget_parent() for? You don't do anything blocking
> here, so why not simply grab dentry->d_lock - that'll stabilize
> the value of ->d_parent just fine. Just don't forget to drop the
> lock before returning and that's it...
Thanks Al, I'll change it.
>
> > + /* If the kernfs parent node has changed discard
> > and
> > + * proceed to ->lookup.
> > + */
> > + parent = kernfs_dentry_node(d_parent);
> > + if (parent) {
> > + if (kernfs_dir_changed(parent, dentry)) {
> > + dput(d_parent);
> > + return 0;
> > + }
> > + }
> > + dput(d_parent);
> > +
> > + /* The kernfs node doesn't exist, leave the dentry
> > + * negative and return success.
> > + */
> > + return 1;
> > + }
next prev parent reply other threads:[~2021-06-12 0:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 8:49 [PATCH v6 0/7] kernfs: proposed locking and concurrency improvement Ian Kent
2021-06-09 8:49 ` [PATCH v6 1/7] kernfs: move revalidate to be near lookup Ian Kent
2021-06-11 12:45 ` Miklos Szeredi
2021-06-09 8:49 ` [PATCH v6 2/7] kernfs: add a revision to identify directory node changes Ian Kent
2021-06-11 12:49 ` Miklos Szeredi
2021-06-11 12:56 ` Ian Kent
2021-06-11 13:11 ` Greg Kroah-Hartman
2021-06-11 13:31 ` Ian Kent
2021-06-11 14:05 ` Greg Kroah-Hartman
2021-06-11 14:16 ` Ian Kent
2021-06-09 8:50 ` [PATCH v6 3/7] kernfs: use VFS negative dentry caching Ian Kent
2021-06-11 13:07 ` Miklos Szeredi
2021-06-12 0:47 ` Ian Kent
2021-06-12 1:48 ` Al Viro
2021-06-13 1:16 ` Ian Kent
2021-06-12 0:07 ` Al Viro
2021-06-12 0:43 ` Ian Kent [this message]
2021-06-12 1:08 ` Ian Kent
2021-06-12 1:51 ` Al Viro
2021-06-13 1:57 ` Ian Kent
2021-06-09 8:50 ` [PATCH v6 4/7] kernfs: switch kernfs to use an rwsem Ian Kent
2021-06-11 13:10 ` Miklos Szeredi
2021-06-12 1:24 ` Al Viro
2021-06-09 8:51 ` [PATCH v6 5/7] kernfs: use i_lock to protect concurrent inode updates Ian Kent
2021-06-11 13:11 ` Miklos Szeredi
2021-06-12 1:45 ` Al Viro
2021-06-13 1:31 ` Ian Kent
2021-06-14 1:32 ` Ian Kent
2021-06-14 6:52 ` Ian Kent
2021-06-14 7:16 ` Ian Kent
2021-06-09 8:52 ` [PATCH v6 6/7] kernfs: add kernfs_need_inode_refresh() Ian Kent
2021-06-11 13:13 ` Miklos Szeredi
2021-06-09 8:52 ` [PATCH v6 7/7] kernfs: dont call d_splice_alias() under kernfs node lock Ian Kent
2021-06-11 13:14 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ee74cbed729d66a38a5c7de9c4608d02fb89f26.camel@themaw.net \
--to=raven@themaw.net \
--cc=brice.goglin@gmail.com \
--cc=cmaiolino@redhat.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=foxhlchen@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mtosatti@redhat.com \
--cc=ricklind@linux.vnet.ibm.com \
--cc=sandeen@sandeen.net \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).