linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabian Frederick <fabf@skynet.be>
To: Al Viro <viro@ZenIV.linux.org.uk>, linux-fsdevel@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>
Subject: Re: [RFC][PATCH] affs_lookup: switch to d_splice_alias()
Date: Mon, 29 Oct 2018 17:45:56 +0100 (CET)	[thread overview]
Message-ID: <1680566718.110930.1540831556783@webmail.appsuite-ad.proximus.be> (raw)
In-Reply-To: <20180513160341.GN30522@ZenIV.linux.org.uk>


> On 13 May 2018 at 18:03 Al Viro <viro@ZenIV.linux.org.uk> wrote:
> 
> 
> Making something exportable takes more than providing ->s_export_ops.
> In particular, ->lookup() *MUST* use d_splice_alias() instead of
> d_add().
> 
> Reading Documentation/filesystems/nfs/Exporting would've been a good idea;
> as it is, exporting AFFS is badly (and exploitably) broken.

Hi Al,

	Could you tell me where Affs is broken ? affs_get_parent() uses d_obtain_alias() and
your patch fixes the lookup. Do you suggest other updates or to mark nfs support experimental in AFFS or 
 something else ?

(btw, other export functions are
fh_to_dentry using generic_fh_to_dentry()
fh_to_parent using generic_fh_to_parent()
)

Regards,
Fabian

      parent reply	other threads:[~2018-10-30  1:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-13 16:03 [RFC][PATCH] affs_lookup: switch to d_splice_alias() Al Viro
2018-05-21 13:46 ` David Sterba
2018-10-29 16:45 ` Fabian Frederick [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1680566718.110930.1540831556783@webmail.appsuite-ad.proximus.be \
    --to=fabf@skynet.be \
    --cc=dsterba@suse.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).