From: Chengguang Xu <cgxu519@mykernel.net>
To: "Amir Goldstein" <amir73il@gmail.com>
Cc: "Miklos Szeredi" <miklos@szeredi.hu>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"linux-fsdevel" <linux-fsdevel@vger.kernel.org>,
"overlayfs" <linux-unionfs@vger.kernel.org>
Subject: Re: [RFC PATCH v3 0/9] Suppress negative dentry
Date: Fri, 15 May 2020 16:25:42 +0800 [thread overview]
Message-ID: <17217706984.f5e20fe88512.8363313618084688988@mykernel.net> (raw)
In-Reply-To: <CAOQ4uxhytw8YPY5WR+txeeHhuO+Hvr0eDFuKOahrN_htXtH_rA@mail.gmail.com>
---- 在 星期五, 2020-05-15 15:30:27 Amir Goldstein <amir73il@gmail.com> 撰写 ----
> On Fri, May 15, 2020 at 10:21 AM Chengguang Xu <cgxu519@mykernel.net> wrote:
> >
> > This series adds a new lookup flag LOOKUP_DONTCACHE_NEGATIVE
> > to indicate to drop negative dentry in slow path of lookup.
> >
> > In overlayfs, negative dentries in upper/lower layers are useless
> > after construction of overlayfs' own dentry, so in order to
> > effectively reclaim those dentries, specify LOOKUP_DONTCACHE_NEGATIVE
> > flag when doing lookup in upper/lower layers.
> >
> > Patch 1 adds flag LOOKUP_DONTCACHE_NEGATIVE and related logic in vfs layer.
> > Patch 2 does lookup optimazation for overlayfs.
> > Patch 3-9 just adjusts function argument when calling
> > lookup_positive_unlocked() and lookup_one_len_unlocked().
>
> Hmm you cannot do that, build must not be broken mid series.
> When Miklos said split he meant to patch 1 and 2.
> Patch 1 must convert all callers to the new argument list,
> at which point all overlayfs calls are with 0 flags.
>
> Once that's done, you may add:
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
>
OK, I got it, I'll still wait for a while in case of other feedbacks.
Miklos, AI
I'm not sure this series will go into whose tree in the end,
so I just rebased on current linus-tree, any suggestion for the code base?
Thanks,
cgxu
next prev parent reply other threads:[~2020-05-15 8:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 7:20 [RFC PATCH v3 0/9] Suppress negative dentry Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 1/9] fs/dcache: Introduce a new lookup flag LOOKUP_DONTCACHE_NEGATIVE Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 2/9] ovl: Suppress negative dentry in lookup Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 3/9] cifs: Adjust argument for lookup_positive_unlocked() Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 4/9] debugfs: " Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 5/9] ecryptfs: Adjust argument for lookup_one_len_unlocked() Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 6/9] exportfs: " Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 7/9] kernfs: Adjust argument for lookup_positive_unlocked() Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 8/9] nfsd: " Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 9/9] quota: " Chengguang Xu
2020-05-15 7:30 ` [RFC PATCH v3 0/9] Suppress negative dentry Amir Goldstein
2020-05-15 8:25 ` Chengguang Xu [this message]
2020-05-15 8:42 ` Miklos Szeredi
2020-05-18 0:53 ` Ian Kent
2020-05-18 5:27 ` Amir Goldstein
2020-05-18 7:52 ` Miklos Szeredi
2020-05-18 8:51 ` Amir Goldstein
2020-05-18 9:17 ` Miklos Szeredi
2020-05-19 5:01 ` cgxu
2020-05-19 8:21 ` Miklos Szeredi
2020-05-19 9:23 ` cgxu
2020-05-20 14:44 ` Miklos Szeredi
2020-05-25 13:37 ` Chengguang Xu
2020-05-25 13:50 ` Miklos Szeredi
2020-05-18 10:26 ` Ian Kent
2020-05-18 10:39 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17217706984.f5e20fe88512.8363313618084688988@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).