From: Chengguang Xu <cgxu519@mykernel.net>
To: miklos@szeredi.hu, viro@zeniv.linux.org.uk, amir73il@gmail.com
Cc: linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org,
Chengguang Xu <cgxu519@mykernel.net>
Subject: [RFC PATCH v3 8/9] nfsd: Adjust argument for lookup_positive_unlocked()
Date: Fri, 15 May 2020 15:20:46 +0800 [thread overview]
Message-ID: <20200515072047.31454-9-cgxu519@mykernel.net> (raw)
In-Reply-To: <20200515072047.31454-1-cgxu519@mykernel.net>
Set 0 as lookup flag argument when calling lookup_positive_unlocked(),
because we don't hope to drop negative dentry in lookup.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/nfsd/nfs3xdr.c | 2 +-
fs/nfsd/nfs4xdr.c | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/nfsd/nfs3xdr.c b/fs/nfsd/nfs3xdr.c
index aae514d40b64..19628922969c 100644
--- a/fs/nfsd/nfs3xdr.c
+++ b/fs/nfsd/nfs3xdr.c
@@ -855,7 +855,7 @@ compose_entry_fh(struct nfsd3_readdirres *cd, struct svc_fh *fhp,
} else
dchild = dget(dparent);
} else
- dchild = lookup_positive_unlocked(name, dparent, namlen);
+ dchild = lookup_positive_unlocked(name, dparent, namlen, 0);
if (IS_ERR(dchild))
return rv;
if (d_mountpoint(dchild))
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 996ac01ee977..1a69e60b8d59 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -3066,7 +3066,8 @@ nfsd4_encode_dirent_fattr(struct xdr_stream *xdr, struct nfsd4_readdir *cd,
__be32 nfserr;
int ignore_crossmnt = 0;
- dentry = lookup_positive_unlocked(name, cd->rd_fhp->fh_dentry, namlen);
+ dentry = lookup_positive_unlocked(name, cd->rd_fhp->fh_dentry,
+ namlen, 0);
if (IS_ERR(dentry))
return nfserrno(PTR_ERR(dentry));
--
2.20.1
next prev parent reply other threads:[~2020-05-15 7:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 7:20 [RFC PATCH v3 0/9] Suppress negative dentry Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 1/9] fs/dcache: Introduce a new lookup flag LOOKUP_DONTCACHE_NEGATIVE Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 2/9] ovl: Suppress negative dentry in lookup Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 3/9] cifs: Adjust argument for lookup_positive_unlocked() Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 4/9] debugfs: " Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 5/9] ecryptfs: Adjust argument for lookup_one_len_unlocked() Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 6/9] exportfs: " Chengguang Xu
2020-05-15 7:20 ` [RFC PATCH v3 7/9] kernfs: Adjust argument for lookup_positive_unlocked() Chengguang Xu
2020-05-15 7:20 ` Chengguang Xu [this message]
2020-05-15 7:20 ` [RFC PATCH v3 9/9] quota: " Chengguang Xu
2020-05-15 7:30 ` [RFC PATCH v3 0/9] Suppress negative dentry Amir Goldstein
2020-05-15 8:25 ` Chengguang Xu
2020-05-15 8:42 ` Miklos Szeredi
2020-05-18 0:53 ` Ian Kent
2020-05-18 5:27 ` Amir Goldstein
2020-05-18 7:52 ` Miklos Szeredi
2020-05-18 8:51 ` Amir Goldstein
2020-05-18 9:17 ` Miklos Szeredi
2020-05-19 5:01 ` cgxu
2020-05-19 8:21 ` Miklos Szeredi
2020-05-19 9:23 ` cgxu
2020-05-20 14:44 ` Miklos Szeredi
2020-05-25 13:37 ` Chengguang Xu
2020-05-25 13:50 ` Miklos Szeredi
2020-05-18 10:26 ` Ian Kent
2020-05-18 10:39 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515072047.31454-9-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).