From: Randy Dunlap <rdunlap@infradead.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Chao Yu <yuchao0@huawei.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: always expose label 'next_page'
Date: Tue, 30 Jun 2020 13:44:22 -0700 [thread overview]
Message-ID: <1be18397-7fc6-703e-121b-e210e101357f@infradead.org> (raw)
In-Reply-To: <20200630202357.GA1396584@google.com>
On 6/30/20 1:23 PM, Jaegeuk Kim wrote:
> On 06/30, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix build error when F2FS_FS_COMPRESSION is not set/enabled.
>> This label is needed in either case.
>>
>> ../fs/f2fs/data.c: In function ‘f2fs_mpage_readpages’:
>> ../fs/f2fs/data.c:2327:5: error: label ‘next_page’ used but not defined
>> goto next_page;
>
> Thank you for the fix. This was actually introduced by the recent testing patch.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=ff963ad2bf54460431f517b5cae473997a29bf2a
>
> If you don't mind, please let me integrate this into the original patch.
> Let me know.
Sure, no problem.
> Thanks,
>
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
>> Cc: Chao Yu <yuchao0@huawei.com>
>> Cc: linux-f2fs-devel@lists.sourceforge.net
>> ---
>> fs/f2fs/data.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> --- linux-next-20200630.orig/fs/f2fs/data.c
>> +++ linux-next-20200630/fs/f2fs/data.c
>> @@ -2366,9 +2366,7 @@ set_error_page:
>> zero_user_segment(page, 0, PAGE_SIZE);
>> unlock_page(page);
>> }
>> -#ifdef CONFIG_F2FS_FS_COMPRESSION
>> next_page:
>> -#endif
>> if (rac)
>> put_page(page);
>>
--
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>
prev parent reply other threads:[~2020-06-30 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 17:09 [PATCH] f2fs: always expose label 'next_page' Randy Dunlap
2020-06-30 20:23 ` Jaegeuk Kim
2020-06-30 20:44 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1be18397-7fc6-703e-121b-e210e101357f@infradead.org \
--to=rdunlap@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).