Linux-Fsdevel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] f2fs: always expose label 'next_page'
@ 2020-06-30 17:09 Randy Dunlap
  2020-06-30 20:23 ` Jaegeuk Kim
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-06-30 17:09 UTC (permalink / raw)
  To: Linux FS Devel, Jaegeuk Kim, Chao Yu, linux-f2fs-devel

From: Randy Dunlap <rdunlap@infradead.org>

Fix build error when F2FS_FS_COMPRESSION is not set/enabled.
This label is needed in either case.

../fs/f2fs/data.c: In function ‘f2fs_mpage_readpages’:
../fs/f2fs/data.c:2327:5: error: label ‘next_page’ used but not defined
     goto next_page;

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
---
 fs/f2fs/data.c |    2 --
 1 file changed, 2 deletions(-)

--- linux-next-20200630.orig/fs/f2fs/data.c
+++ linux-next-20200630/fs/f2fs/data.c
@@ -2366,9 +2366,7 @@ set_error_page:
 			zero_user_segment(page, 0, PAGE_SIZE);
 			unlock_page(page);
 		}
-#ifdef CONFIG_F2FS_FS_COMPRESSION
 next_page:
-#endif
 		if (rac)
 			put_page(page);
 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] f2fs: always expose label 'next_page'
  2020-06-30 17:09 [PATCH] f2fs: always expose label 'next_page' Randy Dunlap
@ 2020-06-30 20:23 ` Jaegeuk Kim
  2020-06-30 20:44   ` Randy Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: Jaegeuk Kim @ 2020-06-30 20:23 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Linux FS Devel, Chao Yu, linux-f2fs-devel

On 06/30, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build error when F2FS_FS_COMPRESSION is not set/enabled.
> This label is needed in either case.
> 
> ../fs/f2fs/data.c: In function ‘f2fs_mpage_readpages’:
> ../fs/f2fs/data.c:2327:5: error: label ‘next_page’ used but not defined
>      goto next_page;

Thank you for the fix. This was actually introduced by the recent testing patch.

https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=ff963ad2bf54460431f517b5cae473997a29bf2a

If you don't mind, please let me integrate this into the original patch.
Let me know.

Thanks,

> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
> Cc: Chao Yu <yuchao0@huawei.com>
> Cc: linux-f2fs-devel@lists.sourceforge.net
> ---
>  fs/f2fs/data.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> --- linux-next-20200630.orig/fs/f2fs/data.c
> +++ linux-next-20200630/fs/f2fs/data.c
> @@ -2366,9 +2366,7 @@ set_error_page:
>  			zero_user_segment(page, 0, PAGE_SIZE);
>  			unlock_page(page);
>  		}
> -#ifdef CONFIG_F2FS_FS_COMPRESSION
>  next_page:
> -#endif
>  		if (rac)
>  			put_page(page);
>  

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] f2fs: always expose label 'next_page'
  2020-06-30 20:23 ` Jaegeuk Kim
@ 2020-06-30 20:44   ` Randy Dunlap
  0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2020-06-30 20:44 UTC (permalink / raw)
  To: Jaegeuk Kim; +Cc: Linux FS Devel, Chao Yu, linux-f2fs-devel

On 6/30/20 1:23 PM, Jaegeuk Kim wrote:
> On 06/30, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix build error when F2FS_FS_COMPRESSION is not set/enabled.
>> This label is needed in either case.
>>
>> ../fs/f2fs/data.c: In function ‘f2fs_mpage_readpages’:
>> ../fs/f2fs/data.c:2327:5: error: label ‘next_page’ used but not defined
>>      goto next_page;
> 
> Thank you for the fix. This was actually introduced by the recent testing patch.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=ff963ad2bf54460431f517b5cae473997a29bf2a
> 
> If you don't mind, please let me integrate this into the original patch.
> Let me know.

Sure, no problem.

> Thanks,
> 
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
>> Cc: Chao Yu <yuchao0@huawei.com>
>> Cc: linux-f2fs-devel@lists.sourceforge.net
>> ---
>>  fs/f2fs/data.c |    2 --
>>  1 file changed, 2 deletions(-)
>>
>> --- linux-next-20200630.orig/fs/f2fs/data.c
>> +++ linux-next-20200630/fs/f2fs/data.c
>> @@ -2366,9 +2366,7 @@ set_error_page:
>>  			zero_user_segment(page, 0, PAGE_SIZE);
>>  			unlock_page(page);
>>  		}
>> -#ifdef CONFIG_F2FS_FS_COMPRESSION
>>  next_page:
>> -#endif
>>  		if (rac)
>>  			put_page(page);
>>  


-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-30 17:09 [PATCH] f2fs: always expose label 'next_page' Randy Dunlap
2020-06-30 20:23 ` Jaegeuk Kim
2020-06-30 20:44   ` Randy Dunlap

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org
	public-inbox-index linux-fsdevel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git