From: Andrew Morton <akpm@linux-foundation.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>, Greg KH <greg@kroah.com>,
Dmitry Kasatkin <dmitry.kasatkin@intel.com>,
linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] vfs: iversion truncate bug fix
Date: Thu, 5 Jan 2012 14:30:15 -0800 [thread overview]
Message-ID: <20120105143015.540ba7d7.akpm@linux-foundation.org> (raw)
In-Reply-To: <1325788781.2775.12.camel@dabdike.Larkspurhotels.com>
On Thu, 05 Jan 2012 10:39:41 -0800
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> > > Please, go read Documentation/stable_kernel_rules.txt for how to
> > > properly submit patches to the stable kernel tree. The information here
> > > needs to be in the patch changelog itself, not in some random email
> > > thread that will get lost instantly into my email-archive-from-hell
> > > after I am done reading this.
> > >
> > > greg k-h
> >
> > Yes, I've read Documentation/stable_kernel_rules.txt and think this
> > patch meets the criteria for being backported.
> >
> > As far as I'm aware, this patch hasn't been upstreamed yet and is
> > waiting for someone, besides myself, to Ack it. Once Acked, either
> > Dmitry or I can send a pull request with an updated patch description.
> > Should this patch go in via the security tree?
>
> If it hasn't been upstreamed yet, just make sure you put
>
> cc: stable@kernel.org
>
> In the signoffs of the patch you're sending upstream and the backport
> will occur automatically when the patch is finally upstreamed.
Mimi didn't write or send the patch.
This happily git-free maintainer simply goes in and edits the
changelog. I do this very very frequently.
Here's what I currently have. I plan to send this to Rip Van Viro.
From: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
Subject: vfs: increment iversion when a file is truncated
When a file is truncated with truncate()/ftruncate() and then closed,
iversion is not updated. This patch uses ATTR_SIZE flag as an indication
to increment iversion.
Mimi said:
On fput(), i_version is used to detect and flag files that have changed
and need to be re-measured in the IMA measurement policy. When a file
is truncated with truncate()/ftruncate() and then closed, i_version is
not updated. As a result, although the file has changed, it will not be
re-measured and added to the IMA measurement list on subsequent access.
Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
Acked-by: Mimi Zohar <zohar@us.ibm.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/attr.c | 5 +++++
1 file changed, 5 insertions(+)
diff -puN fs/attr.c~vfs-increment-iversion-when-a-file-is-truncated fs/attr.c
--- a/fs/attr.c~vfs-increment-iversion-when-a-file-is-truncated
+++ a/fs/attr.c
@@ -176,6 +176,11 @@ int notify_change(struct dentry * dentry
return -EPERM;
}
+ if ((ia_valid & ATTR_SIZE) && IS_I_VERSION(inode)) {
+ if (attr->ia_size != inode->i_size)
+ inode_inc_iversion(inode);
+ }
+
if ((ia_valid & ATTR_MODE)) {
umode_t amode = attr->ia_mode;
/* Flag setting protected by i_mutex */
_
next prev parent reply other threads:[~2012-01-05 22:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 10:54 [PATCH v3 1/1] vfs: iversion truncate bug fix Dmitry Kasatkin
2011-12-22 13:26 ` Mimi Zohar
2012-01-04 23:28 ` Andrew Morton
2012-01-05 0:33 ` Mimi Zohar
2012-01-05 0:46 ` Andrew Morton
2012-01-05 2:06 ` Greg KH
2012-01-05 4:17 ` Mimi Zohar
2012-01-05 4:53 ` Dave Chinner
2012-01-05 18:14 ` Christoph Hellwig
2012-01-05 19:49 ` Mimi Zohar
2012-01-05 21:36 ` J. Bruce Fields
2012-01-05 22:27 ` Mimi Zohar
2012-01-05 16:54 ` Greg KH
2012-01-05 17:19 ` Mimi Zohar
2012-01-05 18:39 ` James Bottomley
2012-01-05 22:30 ` Andrew Morton [this message]
2012-01-05 23:09 ` Mimi Zohar
2012-01-13 10:13 ` Kasatkin, Dmitry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105143015.540ba7d7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dmitry.kasatkin@intel.com \
--cc=greg@kroah.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).