linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
To: linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org
Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org, zohar@linux.vnet.ibm.com,
	Dmitry Kasatkin <dmitry.kasatkin@intel.com>
Subject: [PATCH v3 1/1] vfs: iversion truncate bug fix
Date: Thu, 22 Dec 2011 12:54:28 +0200	[thread overview]
Message-ID: <ba9643a815137d64301559f174f6f6bf3a552b16.1324551152.git.dmitry.kasatkin@intel.com> (raw)

When a file is truncated with truncate()/ftruncate() and then closed,
iversion is not updated. This patch uses ATTR_SIZE flag as an indication
to increment iversion.

Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
---
 fs/attr.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/fs/attr.c b/fs/attr.c
index 7ee7ba4..b8f55c4 100644
--- a/fs/attr.c
+++ b/fs/attr.c
@@ -176,6 +176,11 @@ int notify_change(struct dentry * dentry, struct iattr * attr)
 			return -EPERM;
 	}
 
+	if ((ia_valid & ATTR_SIZE) && IS_I_VERSION(inode)) {
+		if (attr->ia_size != inode->i_size)
+			inode_inc_iversion(inode);
+	}
+
 	if ((ia_valid & ATTR_MODE)) {
 		mode_t amode = attr->ia_mode;
 		/* Flag setting protected by i_mutex */
-- 
1.7.4.1


             reply	other threads:[~2011-12-22 10:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22 10:54 Dmitry Kasatkin [this message]
2011-12-22 13:26 ` [PATCH v3 1/1] vfs: iversion truncate bug fix Mimi Zohar
2012-01-04 23:28   ` Andrew Morton
2012-01-05  0:33     ` Mimi Zohar
2012-01-05  0:46       ` Andrew Morton
2012-01-05  2:06         ` Greg KH
2012-01-05  4:17           ` Mimi Zohar
2012-01-05  4:53             ` Dave Chinner
2012-01-05 18:14               ` Christoph Hellwig
2012-01-05 19:49                 ` Mimi Zohar
2012-01-05 21:36                 ` J. Bruce Fields
2012-01-05 22:27                 ` Mimi Zohar
2012-01-05 16:54             ` Greg KH
2012-01-05 17:19               ` Mimi Zohar
2012-01-05 18:39                 ` James Bottomley
2012-01-05 22:30                   ` Andrew Morton
2012-01-05 23:09                     ` Mimi Zohar
2012-01-13 10:13                     ` Kasatkin, Dmitry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba9643a815137d64301559f174f6f6bf3a552b16.1324551152.git.dmitry.kasatkin@intel.com \
    --to=dmitry.kasatkin@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).