From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Marco Stornelli <marco.stornelli@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] vfs pile 3
Date: Sat, 13 Oct 2012 11:48:10 -0400 [thread overview]
Message-ID: <20121013154810.GA9678@infradead.org> (raw)
In-Reply-To: <20121013075128.GQ2616@ZenIV.linux.org.uk>
On Sat, Oct 13, 2012 at 08:51:28AM +0100, Al Viro wrote:
> It's somewhat pointless on its own... If you were doing something with
> the callers afterwards - sure, it would be make sense, but as it is...
I'd really like to see ->truncate and vmtruncate done, so from that side
I'm absolutely in favour of this series. What I'm a bit concerned about
is that it just does the trivial 1:1 conversion and not actually
converts the sequence of operations to the proper form, which was one
of the two big reasons of moving away from ->truncate to start with.
I'd love to see the full conversion, but without adequate test coverage
for all the fringe filesystems that might be a bit too much to expect
from Marco.
I think just doing the easy conversions he did, and putting a TODO
comment explaining how it should be taken further at each of the sites
would be valueable on its own.
next prev parent reply other threads:[~2012-10-13 15:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 0:20 [git pull] vfs pile 3 Al Viro
2012-10-13 7:20 ` Marco Stornelli
2012-10-13 7:51 ` Al Viro
2012-10-13 7:52 ` Marco Stornelli
2012-10-13 15:48 ` Christoph Hellwig [this message]
2012-10-13 16:01 ` Al Viro
2012-10-13 16:04 ` Christoph Hellwig
2012-10-13 17:07 ` Al Viro
2012-10-14 9:59 ` Marco Stornelli
2016-08-07 3:46 Al Viro
2016-08-07 14:00 ` Linus Torvalds
2016-12-23 0:03 Al Viro
2016-12-23 11:44 ` Al Viro
2018-06-04 1:12 [git pull] vfs, " Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121013154810.GA9678@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).