* [patch] vfs: remove an unneeded condition in show_vfsstat()
@ 2015-03-19 10:18 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-03-19 10:18 UTC (permalink / raw)
To: Alexander Viro, Dmitry V. Levin; +Cc: linux-fsdevel, kernel-janitors
Static checkers complain that "err" is always zero here. This check is
not needed after we applied 9d4d65748a5c ('vfs: make mounts and
mountstats honor root dir like mountinfo does').
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/proc_namespace.c b/fs/proc_namespace.c
index 8db932d..97540a7 100644
--- a/fs/proc_namespace.c
+++ b/fs/proc_namespace.c
@@ -219,8 +219,7 @@ static int show_vfsstat(struct seq_file *m, struct vfsmount *mnt)
/* optional statistics */
if (sb->s_op->show_stats) {
seq_putc(m, ' ');
- if (!err)
- err = sb->s_op->show_stats(m, mnt_path.dentry);
+ err = sb->s_op->show_stats(m, mnt_path.dentry);
}
seq_putc(m, '\n');
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-03-19 10:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-19 10:18 [patch] vfs: remove an unneeded condition in show_vfsstat() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).