From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Brian Foster <bfoster@redhat.com>
Cc: david@fromorbit.com, linux-fsdevel@vger.kernel.org,
vishal.l.verma@intel.com, xfs@oss.sgi.com
Subject: Re: [PATCH 012/119] xfs: during btree split, save new block key & ptr for future insertion
Date: Mon, 27 Jun 2016 15:30:23 -0700 [thread overview]
Message-ID: <20160627223023.GD4921@birch.djwong.org> (raw)
In-Reply-To: <20160621130043.GA62352@bfoster.bfoster>
On Tue, Jun 21, 2016 at 09:00:45AM -0400, Brian Foster wrote:
> On Thu, Jun 16, 2016 at 06:19:08PM -0700, Darrick J. Wong wrote:
> > When a btree block has to be split, we pass the new block's ptr from
> > xfs_btree_split() back to xfs_btree_insert() via a pointer parameter;
> > however, we pass the block's key through the cursor's record. It is a
> > little weird to "initialize" a record from a key since the non-key
> > attributes will have garbage values.
> >
> > When we go to add support for interval queries, we have to be able to
> > pass the lowest and highest keys accessible via a pointer. There's no
> > clean way to pass this back through the cursor's record field.
> > Therefore, pass the key directly back to xfs_btree_insert() the same
> > way that we pass the btree_ptr.
> >
> > As a bonus, we no longer need init_rec_from_key and can drop it from the
> > codebase.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > fs/xfs/libxfs/xfs_alloc_btree.c | 12 ----------
> > fs/xfs/libxfs/xfs_bmap_btree.c | 12 ----------
> > fs/xfs/libxfs/xfs_btree.c | 44 +++++++++++++++++++-------------------
> > fs/xfs/libxfs/xfs_btree.h | 2 --
> > fs/xfs/libxfs/xfs_ialloc_btree.c | 10 ---------
> > 5 files changed, 22 insertions(+), 58 deletions(-)
> >
> >
> ...
> > diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> > index 046fbcf..a096539 100644
> > --- a/fs/xfs/libxfs/xfs_btree.c
> > +++ b/fs/xfs/libxfs/xfs_btree.c
> ...
> > @@ -2929,16 +2927,16 @@ xfs_btree_insrec(
> > struct xfs_btree_cur *cur, /* btree cursor */
> > int level, /* level to insert record at */
> > union xfs_btree_ptr *ptrp, /* i/o: block number inserted */
> > - union xfs_btree_rec *recp, /* i/o: record data inserted */
> > + union xfs_btree_key *key, /* i/o: block key for ptrp */
> > struct xfs_btree_cur **curp, /* output: new cursor replacing cur */
> > int *stat) /* success/failure */
> > {
> > struct xfs_btree_block *block; /* btree block */
> > struct xfs_buf *bp; /* buffer for block */
> > - union xfs_btree_key key; /* btree key */
> > union xfs_btree_ptr nptr; /* new block ptr */
> > struct xfs_btree_cur *ncur; /* new btree cursor */
> > - union xfs_btree_rec nrec; /* new record count */
> > + union xfs_btree_key nkey; /* new block key */
> > + union xfs_btree_rec rec; /* record to insert */
> > int optr; /* old key/record index */
> > int ptr; /* key/record index */
> > int numrecs;/* number of records */
> > @@ -2947,8 +2945,14 @@ xfs_btree_insrec(
> > int i;
> > #endif
> >
> > + /* Make a key out of the record data to be inserted, and save it. */
> > + if (level == 0) {
> > + cur->bc_ops->init_rec_from_cur(cur, &rec);
> > + cur->bc_ops->init_key_from_rec(key, &rec);
> > + }
>
> The level == 0 check looks a bit hacky to me. IOW, I think it's cleaner
> that the key is initialized once in the caller rather than check for a
> particular iteration down in xfs_btree_insrec(). That said,
> xfs_btree_insrec() still needs rec initialized in the level == 0 case.
>
> I wonder if we could create an inline xfs_btree_init_key_from_cur()
> helper to combine the above calls, invoke it once in xfs_btree_insert(),
> then push down the ->init_rec_from_cur() calls to the contexts further
> down in this function where rec is actually required. There are only two
> and one of them is DEBUG code. Thoughts?
How about I make btree_insert set both &key and &rec at the start and
pass them both into btree_insrec? That would eliminate the hacky check
above and fix the dummy tracing hook too, in case it ever does anything.
>
> > +
> > XFS_BTREE_TRACE_CURSOR(cur, XBT_ENTRY);
> > - XFS_BTREE_TRACE_ARGIPR(cur, level, *ptrp, recp);
> > + XFS_BTREE_TRACE_ARGIPR(cur, level, *ptrp, &rec);
> >
>
> So these look like unimplemented dummy tracing hooks. It sounds like
> previously rec could have a junk value after a btree split, but now it
> looks like rec is junk for every non-zero level. Kind of annoying, I
> wonder if we can just kill these.. :/
<shrug> I have no opinion either way. :)
--D
>
> Brian
>
> > ncur = NULL;
> >
> > @@ -2973,9 +2977,6 @@ xfs_btree_insrec(
> > return 0;
> > }
> >
> > - /* Make a key out of the record data to be inserted, and save it. */
> > - cur->bc_ops->init_key_from_rec(&key, recp);
> > -
> > optr = ptr;
> >
> > XFS_BTREE_STATS_INC(cur, insrec);
> > @@ -2992,10 +2993,10 @@ xfs_btree_insrec(
> > /* Check that the new entry is being inserted in the right place. */
> > if (ptr <= numrecs) {
> > if (level == 0) {
> > - ASSERT(cur->bc_ops->recs_inorder(cur, recp,
> > + ASSERT(cur->bc_ops->recs_inorder(cur, &rec,
> > xfs_btree_rec_addr(cur, ptr, block)));
> > } else {
> > - ASSERT(cur->bc_ops->keys_inorder(cur, &key,
> > + ASSERT(cur->bc_ops->keys_inorder(cur, key,
> > xfs_btree_key_addr(cur, ptr, block)));
> > }
> > }
> > @@ -3008,7 +3009,7 @@ xfs_btree_insrec(
> > xfs_btree_set_ptr_null(cur, &nptr);
> > if (numrecs == cur->bc_ops->get_maxrecs(cur, level)) {
> > error = xfs_btree_make_block_unfull(cur, level, numrecs,
> > - &optr, &ptr, &nptr, &ncur, &nrec, stat);
> > + &optr, &ptr, &nptr, &ncur, &nkey, stat);
> > if (error || *stat == 0)
> > goto error0;
> > }
> > @@ -3058,7 +3059,7 @@ xfs_btree_insrec(
> > #endif
> >
> > /* Now put the new data in, bump numrecs and log it. */
> > - xfs_btree_copy_keys(cur, kp, &key, 1);
> > + xfs_btree_copy_keys(cur, kp, key, 1);
> > xfs_btree_copy_ptrs(cur, pp, ptrp, 1);
> > numrecs++;
> > xfs_btree_set_numrecs(block, numrecs);
> > @@ -3079,7 +3080,7 @@ xfs_btree_insrec(
> > xfs_btree_shift_recs(cur, rp, 1, numrecs - ptr + 1);
> >
> > /* Now put the new data in, bump numrecs and log it. */
> > - xfs_btree_copy_recs(cur, rp, recp, 1);
> > + xfs_btree_copy_recs(cur, rp, &rec, 1);
> > xfs_btree_set_numrecs(block, ++numrecs);
> > xfs_btree_log_recs(cur, bp, ptr, numrecs);
> > #ifdef DEBUG
> > @@ -3095,7 +3096,7 @@ xfs_btree_insrec(
> >
> > /* If we inserted at the start of a block, update the parents' keys. */
> > if (optr == 1) {
> > - error = xfs_btree_updkey(cur, &key, level + 1);
> > + error = xfs_btree_updkey(cur, key, level + 1);
> > if (error)
> > goto error0;
> > }
> > @@ -3105,7 +3106,7 @@ xfs_btree_insrec(
> > * we are at the far right edge of the tree, update it.
> > */
> > if (xfs_btree_is_lastrec(cur, block, level)) {
> > - cur->bc_ops->update_lastrec(cur, block, recp,
> > + cur->bc_ops->update_lastrec(cur, block, &rec,
> > ptr, LASTREC_INSREC);
> > }
> >
> > @@ -3115,7 +3116,7 @@ xfs_btree_insrec(
> > */
> > *ptrp = nptr;
> > if (!xfs_btree_ptr_is_null(cur, &nptr)) {
> > - *recp = nrec;
> > + *key = nkey;
> > *curp = ncur;
> > }
> >
> > @@ -3146,14 +3147,13 @@ xfs_btree_insert(
> > union xfs_btree_ptr nptr; /* new block number (split result) */
> > struct xfs_btree_cur *ncur; /* new cursor (split result) */
> > struct xfs_btree_cur *pcur; /* previous level's cursor */
> > - union xfs_btree_rec rec; /* record to insert */
> > + union xfs_btree_key key; /* key of block to insert */
> >
> > level = 0;
> > ncur = NULL;
> > pcur = cur;
> >
> > xfs_btree_set_ptr_null(cur, &nptr);
> > - cur->bc_ops->init_rec_from_cur(cur, &rec);
> >
> > /*
> > * Loop going up the tree, starting at the leaf level.
> > @@ -3165,7 +3165,7 @@ xfs_btree_insert(
> > * Insert nrec/nptr into this level of the tree.
> > * Note if we fail, nptr will be null.
> > */
> > - error = xfs_btree_insrec(pcur, level, &nptr, &rec, &ncur, &i);
> > + error = xfs_btree_insrec(pcur, level, &nptr, &key, &ncur, &i);
> > if (error) {
> > if (pcur != cur)
> > xfs_btree_del_cursor(pcur, XFS_BTREE_ERROR);
> > diff --git a/fs/xfs/libxfs/xfs_btree.h b/fs/xfs/libxfs/xfs_btree.h
> > index b955e5d..b99c018 100644
> > --- a/fs/xfs/libxfs/xfs_btree.h
> > +++ b/fs/xfs/libxfs/xfs_btree.h
> > @@ -158,8 +158,6 @@ struct xfs_btree_ops {
> > /* init values of btree structures */
> > void (*init_key_from_rec)(union xfs_btree_key *key,
> > union xfs_btree_rec *rec);
> > - void (*init_rec_from_key)(union xfs_btree_key *key,
> > - union xfs_btree_rec *rec);
> > void (*init_rec_from_cur)(struct xfs_btree_cur *cur,
> > union xfs_btree_rec *rec);
> > void (*init_ptr_from_cur)(struct xfs_btree_cur *cur,
> > diff --git a/fs/xfs/libxfs/xfs_ialloc_btree.c b/fs/xfs/libxfs/xfs_ialloc_btree.c
> > index 89c21d7..88da2ad 100644
> > --- a/fs/xfs/libxfs/xfs_ialloc_btree.c
> > +++ b/fs/xfs/libxfs/xfs_ialloc_btree.c
> > @@ -146,14 +146,6 @@ xfs_inobt_init_key_from_rec(
> > }
> >
> > STATIC void
> > -xfs_inobt_init_rec_from_key(
> > - union xfs_btree_key *key,
> > - union xfs_btree_rec *rec)
> > -{
> > - rec->inobt.ir_startino = key->inobt.ir_startino;
> > -}
> > -
> > -STATIC void
> > xfs_inobt_init_rec_from_cur(
> > struct xfs_btree_cur *cur,
> > union xfs_btree_rec *rec)
> > @@ -314,7 +306,6 @@ static const struct xfs_btree_ops xfs_inobt_ops = {
> > .get_minrecs = xfs_inobt_get_minrecs,
> > .get_maxrecs = xfs_inobt_get_maxrecs,
> > .init_key_from_rec = xfs_inobt_init_key_from_rec,
> > - .init_rec_from_key = xfs_inobt_init_rec_from_key,
> > .init_rec_from_cur = xfs_inobt_init_rec_from_cur,
> > .init_ptr_from_cur = xfs_inobt_init_ptr_from_cur,
> > .key_diff = xfs_inobt_key_diff,
> > @@ -336,7 +327,6 @@ static const struct xfs_btree_ops xfs_finobt_ops = {
> > .get_minrecs = xfs_inobt_get_minrecs,
> > .get_maxrecs = xfs_inobt_get_maxrecs,
> > .init_key_from_rec = xfs_inobt_init_key_from_rec,
> > - .init_rec_from_key = xfs_inobt_init_rec_from_key,
> > .init_rec_from_cur = xfs_inobt_init_rec_from_cur,
> > .init_ptr_from_cur = xfs_finobt_init_ptr_from_cur,
> > .key_diff = xfs_inobt_key_diff,
> >
> > _______________________________________________
> > xfs mailing list
> > xfs@oss.sgi.com
> > http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-06-27 22:30 UTC|newest]
Thread overview: 236+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 1:17 [PATCH v6 000/119] xfs: add reverse mapping, reflink, dedupe, and online scrub support Darrick J. Wong
2016-06-17 1:17 ` [PATCH 001/119] vfs: fix return type of ioctl_file_dedupe_range Darrick J. Wong
2016-06-17 11:32 ` Christoph Hellwig
2016-06-28 19:19 ` Darrick J. Wong
2016-06-17 1:18 ` [PATCH 002/119] vfs: support FS_XFLAG_REFLINK and FS_XFLAG_COWEXTSIZE Darrick J. Wong
2016-06-17 11:41 ` Christoph Hellwig
2016-06-17 12:16 ` Brian Foster
2016-06-17 15:06 ` Christoph Hellwig
2016-06-17 16:54 ` Darrick J. Wong
2016-06-17 17:38 ` Brian Foster
2016-06-17 1:18 ` [PATCH 003/119] xfs: check offsets of variable length structures Darrick J. Wong
2016-06-17 11:33 ` Christoph Hellwig
2016-06-17 17:34 ` Brian Foster
2016-06-18 18:01 ` Darrick J. Wong
2016-06-20 12:38 ` Brian Foster
2016-06-17 1:18 ` [PATCH 004/119] xfs: enable buffer deadlock postmortem diagnosis via ftrace Darrick J. Wong
2016-06-17 11:34 ` Christoph Hellwig
2016-06-21 0:47 ` Dave Chinner
2016-06-17 1:18 ` [PATCH 005/119] xfs: check for a valid error_tag in errortag_add Darrick J. Wong
2016-06-17 11:34 ` Christoph Hellwig
2016-06-17 1:18 ` [PATCH 006/119] xfs: port differences from xfsprogs libxfs Darrick J. Wong
2016-06-17 15:06 ` Christoph Hellwig
2016-06-20 0:21 ` Dave Chinner
2016-07-13 23:39 ` Darrick J. Wong
2016-06-17 1:18 ` [PATCH 007/119] xfs: rearrange xfs_bmap_add_free parameters Darrick J. Wong
2016-06-17 11:39 ` Christoph Hellwig
2016-06-17 1:18 ` [PATCH 008/119] xfs: separate freelist fixing into a separate helper Darrick J. Wong
2016-06-17 11:52 ` Christoph Hellwig
2016-06-21 0:48 ` Dave Chinner
2016-06-21 1:40 ` Dave Chinner
2016-06-17 1:18 ` [PATCH 009/119] xfs: convert list of extents to free into a regular list Darrick J. Wong
2016-06-17 11:59 ` Christoph Hellwig
2016-06-18 20:15 ` Darrick J. Wong
2016-06-21 0:57 ` Dave Chinner
2016-06-17 1:18 ` [PATCH 010/119] xfs: create a standard btree size calculator code Darrick J. Wong
2016-06-20 14:31 ` Brian Foster
2016-06-20 19:34 ` Darrick J. Wong
2016-06-17 1:19 ` [PATCH 011/119] xfs: refactor btree maxlevels computation Darrick J. Wong
2016-06-20 14:31 ` Brian Foster
2016-06-20 18:23 ` Darrick J. Wong
2016-06-17 1:19 ` [PATCH 012/119] xfs: during btree split, save new block key & ptr for future insertion Darrick J. Wong
2016-06-21 13:00 ` Brian Foster
2016-06-27 22:30 ` Darrick J. Wong [this message]
2016-06-28 12:31 ` Brian Foster
2016-06-17 1:19 ` [PATCH 013/119] xfs: support btrees with overlapping intervals for keys Darrick J. Wong
2016-06-22 15:17 ` Brian Foster
2016-06-28 3:26 ` Darrick J. Wong
2016-06-28 12:32 ` Brian Foster
2016-06-28 17:36 ` Darrick J. Wong
2016-07-06 4:59 ` Dave Chinner
2016-07-06 8:09 ` Darrick J. Wong
2016-06-17 1:19 ` [PATCH 014/119] xfs: introduce interval queries on btrees Darrick J. Wong
2016-06-22 15:18 ` Brian Foster
2016-06-27 21:07 ` Darrick J. Wong
2016-06-28 12:32 ` Brian Foster
2016-06-28 16:29 ` Darrick J. Wong
2016-06-17 1:19 ` [PATCH 015/119] xfs: refactor btree owner change into a separate visit-blocks function Darrick J. Wong
2016-06-23 17:19 ` Brian Foster
2016-06-17 1:19 ` [PATCH 016/119] xfs: move deferred operations into a separate file Darrick J. Wong
2016-06-27 13:14 ` Brian Foster
2016-06-27 19:14 ` Darrick J. Wong
2016-06-28 12:32 ` Brian Foster
2016-06-28 18:51 ` Darrick J. Wong
2016-06-17 1:19 ` [PATCH 017/119] xfs: add tracepoints for the deferred ops mechanism Darrick J. Wong
2016-06-27 13:15 ` Brian Foster
2016-06-17 1:19 ` [PATCH 018/119] xfs: enable the xfs_defer mechanism to process extents to free Darrick J. Wong
2016-06-27 13:15 ` Brian Foster
2016-06-27 21:41 ` Darrick J. Wong
2016-06-27 22:00 ` Darrick J. Wong
2016-06-28 12:32 ` Brian Foster
2016-06-28 16:33 ` Darrick J. Wong
2016-06-17 1:19 ` [PATCH 019/119] xfs: rework xfs_bmap_free callers to use xfs_defer_ops Darrick J. Wong
2016-06-17 1:20 ` [PATCH 020/119] xfs: change xfs_bmap_{finish, cancel, init, free} -> xfs_defer_* Darrick J. Wong
2016-06-30 0:11 ` Darrick J. Wong
2016-06-17 1:20 ` [PATCH 021/119] xfs: rename flist/free_list to dfops Darrick J. Wong
2016-06-17 1:20 ` [PATCH 022/119] xfs: add tracepoints and error injection for deferred extent freeing Darrick J. Wong
2016-06-17 1:20 ` [PATCH 023/119] xfs: introduce rmap btree definitions Darrick J. Wong
2016-06-30 17:32 ` Brian Foster
2016-06-17 1:20 ` [PATCH 024/119] xfs: add rmap btree stats infrastructure Darrick J. Wong
2016-06-30 17:32 ` Brian Foster
2016-06-17 1:20 ` [PATCH 025/119] xfs: rmap btree add more reserved blocks Darrick J. Wong
2016-06-30 17:32 ` Brian Foster
2016-06-17 1:20 ` [PATCH 026/119] xfs: add owner field to extent allocation and freeing Darrick J. Wong
2016-07-06 4:01 ` Dave Chinner
2016-07-06 6:44 ` Darrick J. Wong
2016-07-07 15:12 ` Brian Foster
2016-07-07 19:09 ` Darrick J. Wong
2016-07-07 22:55 ` Dave Chinner
2016-07-08 11:37 ` Brian Foster
2016-06-17 1:20 ` [PATCH 027/119] xfs: introduce rmap extent operation stubs Darrick J. Wong
2016-06-17 1:20 ` [PATCH 028/119] xfs: define the on-disk rmap btree format Darrick J. Wong
2016-07-06 4:05 ` Dave Chinner
2016-07-06 6:44 ` Darrick J. Wong
2016-07-07 18:41 ` Brian Foster
2016-07-07 19:18 ` Darrick J. Wong
2016-07-07 23:14 ` Dave Chinner
2016-07-07 23:58 ` Darrick J. Wong
2016-06-17 1:20 ` [PATCH 029/119] xfs: add rmap btree growfs support Darrick J. Wong
2016-06-17 1:21 ` [PATCH 030/119] xfs: rmap btree transaction reservations Darrick J. Wong
2016-07-08 13:21 ` Brian Foster
2016-06-17 1:21 ` [PATCH 031/119] xfs: rmap btree requires more reserved free space Darrick J. Wong
2016-07-08 13:21 ` Brian Foster
2016-07-13 16:50 ` Darrick J. Wong
2016-07-13 18:32 ` Brian Foster
2016-07-13 23:50 ` Dave Chinner
2016-06-17 1:21 ` [PATCH 032/119] xfs: add rmap btree operations Darrick J. Wong
2016-07-08 18:33 ` Brian Foster
2016-07-08 23:53 ` Darrick J. Wong
2016-06-17 1:21 ` [PATCH 033/119] xfs: support overlapping intervals in the rmap btree Darrick J. Wong
2016-07-08 18:33 ` Brian Foster
2016-07-09 0:14 ` Darrick J. Wong
2016-07-09 13:25 ` Brian Foster
2016-06-17 1:21 ` [PATCH 034/119] xfs: teach rmapbt to support interval queries Darrick J. Wong
2016-07-08 18:34 ` Brian Foster
2016-07-09 0:16 ` Darrick J. Wong
2016-07-09 13:25 ` Brian Foster
2016-06-17 1:21 ` [PATCH 035/119] xfs: add tracepoints for the rmap functions Darrick J. Wong
2016-07-08 18:34 ` Brian Foster
2016-06-17 1:21 ` [PATCH 036/119] xfs: add an extent to the rmap btree Darrick J. Wong
2016-07-11 18:49 ` Brian Foster
2016-07-11 23:01 ` Darrick J. Wong
2016-06-17 1:21 ` [PATCH 037/119] xfs: remove an extent from " Darrick J. Wong
2016-07-11 18:49 ` Brian Foster
2016-06-17 1:21 ` [PATCH 038/119] xfs: convert unwritten status of reverse mappings Darrick J. Wong
2016-06-30 0:15 ` Darrick J. Wong
2016-07-13 18:27 ` Brian Foster
2016-07-13 20:43 ` Darrick J. Wong
2016-06-17 1:22 ` [PATCH 039/119] xfs: add rmap btree insert and delete helpers Darrick J. Wong
2016-07-13 18:28 ` Brian Foster
2016-07-13 18:37 ` Darrick J. Wong
2016-07-13 18:42 ` Brian Foster
2016-06-17 1:22 ` [PATCH 040/119] xfs: create helpers for mapping, unmapping, and converting file fork extents Darrick J. Wong
2016-07-13 18:28 ` Brian Foster
2016-07-13 18:47 ` Darrick J. Wong
2016-07-13 23:54 ` Dave Chinner
2016-07-13 23:55 ` Darrick J. Wong
2016-06-17 1:22 ` [PATCH 041/119] xfs: create rmap update intent log items Darrick J. Wong
2016-07-15 18:33 ` Brian Foster
2016-07-16 7:10 ` Darrick J. Wong
2016-06-17 1:22 ` [PATCH 042/119] xfs: log rmap intent items Darrick J. Wong
2016-07-15 18:33 ` Brian Foster
2016-07-16 7:34 ` Darrick J. Wong
2016-07-18 12:55 ` Brian Foster
2016-07-19 17:10 ` Darrick J. Wong
2016-06-17 1:22 ` [PATCH 043/119] xfs: enable the xfs_defer mechanism to process rmaps to update Darrick J. Wong
2016-07-15 18:33 ` Brian Foster
2016-06-17 1:22 ` [PATCH 044/119] xfs: propagate bmap updates to rmapbt Darrick J. Wong
2016-07-15 18:33 ` Brian Foster
2016-07-16 7:26 ` Darrick J. Wong
2016-07-18 1:21 ` Dave Chinner
2016-07-18 12:56 ` Brian Foster
2016-07-18 12:55 ` Brian Foster
2016-07-19 1:53 ` Darrick J. Wong
2016-07-19 11:37 ` Brian Foster
2016-06-17 1:22 ` [PATCH 045/119] xfs: add rmap btree geometry feature flag Darrick J. Wong
2016-07-18 13:34 ` Brian Foster
2016-06-17 1:22 ` [PATCH 046/119] xfs: add rmap btree block detection to log recovery Darrick J. Wong
2016-07-18 13:34 ` Brian Foster
2016-06-17 1:22 ` [PATCH 047/119] xfs: disable XFS_IOC_SWAPEXT when rmap btree is enabled Darrick J. Wong
2016-07-18 13:34 ` Brian Foster
2016-07-18 16:18 ` Darrick J. Wong
2016-06-17 1:22 ` [PATCH 048/119] xfs: don't update rmapbt when fixing agfl Darrick J. Wong
2016-07-18 13:34 ` Brian Foster
2016-07-18 15:53 ` Darrick J. Wong
2016-06-17 1:23 ` [PATCH 049/119] xfs: enable the rmap btree functionality Darrick J. Wong
2016-07-18 13:34 ` Brian Foster
2016-06-17 1:23 ` [PATCH 050/119] xfs: count the blocks in a btree Darrick J. Wong
2016-06-17 1:23 ` [PATCH 051/119] xfs: introduce tracepoints for AG reservation code Darrick J. Wong
2016-06-17 1:23 ` [PATCH 052/119] xfs: set up per-AG free space reservations Darrick J. Wong
2016-06-17 1:23 ` [PATCH 053/119] xfs: define tracepoints for refcount btree activities Darrick J. Wong
2016-06-17 1:23 ` [PATCH 054/119] xfs: introduce refcount btree definitions Darrick J. Wong
2016-06-17 1:23 ` [PATCH 055/119] xfs: add refcount btree stats infrastructure Darrick J. Wong
2016-06-17 1:23 ` [PATCH 056/119] xfs: refcount btree add more reserved blocks Darrick J. Wong
2016-06-17 1:23 ` [PATCH 057/119] xfs: define the on-disk refcount btree format Darrick J. Wong
2016-06-17 1:24 ` [PATCH 058/119] xfs: add refcount btree support to growfs Darrick J. Wong
2016-06-17 1:24 ` [PATCH 059/119] xfs: account for the refcount btree in the alloc/free log reservation Darrick J. Wong
2016-06-17 1:24 ` [PATCH 060/119] xfs: add refcount btree operations Darrick J. Wong
2016-06-17 1:24 ` [PATCH 061/119] xfs: create refcount update intent log items Darrick J. Wong
2016-06-17 1:24 ` [PATCH 062/119] xfs: log refcount intent items Darrick J. Wong
2016-06-17 1:24 ` [PATCH 063/119] xfs: adjust refcount of an extent of blocks in refcount btree Darrick J. Wong
2016-06-17 1:24 ` [PATCH 064/119] xfs: connect refcount adjust functions to upper layers Darrick J. Wong
2016-06-17 1:24 ` [PATCH 065/119] xfs: adjust refcount when unmapping file blocks Darrick J. Wong
2016-06-17 1:24 ` [PATCH 066/119] xfs: add refcount btree block detection to log recovery Darrick J. Wong
2016-06-17 1:25 ` [PATCH 067/119] xfs: refcount btree requires more reserved space Darrick J. Wong
2016-06-17 1:25 ` [PATCH 068/119] xfs: introduce reflink utility functions Darrick J. Wong
2016-06-17 1:25 ` [PATCH 069/119] xfs: create bmbt update intent log items Darrick J. Wong
2016-06-17 1:25 ` [PATCH 070/119] xfs: log bmap intent items Darrick J. Wong
2016-06-17 1:25 ` [PATCH 071/119] xfs: map an inode's offset to an exact physical block Darrick J. Wong
2016-06-17 1:25 ` [PATCH 072/119] xfs: implement deferred bmbt map/unmap operations Darrick J. Wong
2016-06-17 1:25 ` [PATCH 073/119] xfs: return work remaining at the end of a bunmapi operation Darrick J. Wong
2016-06-17 1:25 ` [PATCH 074/119] xfs: define tracepoints for reflink activities Darrick J. Wong
2016-06-17 1:25 ` [PATCH 075/119] xfs: add reflink feature flag to geometry Darrick J. Wong
2016-06-17 1:25 ` [PATCH 076/119] xfs: don't allow reflinked dir/dev/fifo/socket/pipe files Darrick J. Wong
2016-06-17 1:26 ` [PATCH 077/119] xfs: introduce the CoW fork Darrick J. Wong
2016-06-17 1:26 ` [PATCH 078/119] xfs: support bmapping delalloc extents in " Darrick J. Wong
2016-06-17 1:26 ` [PATCH 079/119] xfs: create delalloc extents in " Darrick J. Wong
2016-06-17 1:26 ` [PATCH 080/119] xfs: support allocating delayed " Darrick J. Wong
2016-06-17 1:26 ` [PATCH 081/119] xfs: allocate " Darrick J. Wong
2016-06-17 1:26 ` [PATCH 082/119] xfs: support removing extents from " Darrick J. Wong
2016-06-17 1:26 ` [PATCH 083/119] xfs: move mappings from cow fork to data fork after copy-write Darrick J. Wong
2016-06-17 1:26 ` [PATCH 084/119] xfs: implement CoW for directio writes Darrick J. Wong
2016-06-17 1:26 ` [PATCH 085/119] xfs: copy-on-write reflinked blocks when zeroing ranges of blocks Darrick J. Wong
2016-06-17 1:27 ` [PATCH 086/119] xfs: cancel CoW reservations and clear inode reflink flag when freeing blocks Darrick J. Wong
2016-06-17 1:27 ` [PATCH 087/119] xfs: cancel pending CoW reservations when destroying inodes Darrick J. Wong
2016-06-17 1:27 ` [PATCH 088/119] xfs: store in-progress CoW allocations in the refcount btree Darrick J. Wong
2016-06-17 1:27 ` [PATCH 089/119] xfs: reflink extents from one file to another Darrick J. Wong
2016-06-17 1:27 ` [PATCH 090/119] xfs: add clone file and clone range vfs functions Darrick J. Wong
2016-06-17 1:27 ` [PATCH 091/119] xfs: add dedupe range vfs function Darrick J. Wong
2016-06-17 1:27 ` [PATCH 092/119] xfs: teach get_bmapx and fiemap about shared extents and the CoW fork Darrick J. Wong
2016-06-17 1:27 ` [PATCH 093/119] xfs: swap inode reflink flags when swapping inode extents Darrick J. Wong
2016-06-17 1:27 ` [PATCH 094/119] xfs: unshare a range of blocks via fallocate Darrick J. Wong
2016-06-17 1:28 ` [PATCH 095/119] xfs: CoW shared EOF block when truncating file Darrick J. Wong
2016-06-17 1:28 ` [PATCH 096/119] xfs: support FS_XFLAG_REFLINK on reflink filesystems Darrick J. Wong
2016-06-17 1:28 ` [PATCH 097/119] xfs: create a separate cow extent size hint for the allocator Darrick J. Wong
2016-06-17 1:28 ` [PATCH 098/119] xfs: preallocate blocks for worst-case btree expansion Darrick J. Wong
2016-06-17 1:28 ` [PATCH 099/119] xfs: don't allow reflink when the AG is low on space Darrick J. Wong
2016-06-17 1:28 ` [PATCH 100/119] xfs: try other AGs to allocate a BMBT block Darrick J. Wong
2016-06-17 1:28 ` [PATCH 101/119] xfs: promote buffered writes to CoW when cowextsz is set Darrick J. Wong
2016-06-17 1:28 ` [PATCH 102/119] xfs: garbage collect old cowextsz reservations Darrick J. Wong
2016-06-17 1:28 ` [PATCH 103/119] xfs: provide switch to force filesystem to copy-on-write all the time Darrick J. Wong
2016-06-17 1:29 ` [PATCH 104/119] xfs: increase log reservations for reflink Darrick J. Wong
2016-06-17 1:29 ` [PATCH 105/119] xfs: use interval query for rmap alloc operations on shared files Darrick J. Wong
2016-06-17 1:29 ` [PATCH 106/119] xfs: convert unwritten status of reverse mappings for " Darrick J. Wong
2016-06-17 1:29 ` [PATCH 107/119] xfs: set a default CoW extent size of 32 blocks Darrick J. Wong
2016-06-17 1:29 ` [PATCH 108/119] xfs: don't allow realtime and reflinked files to mix Darrick J. Wong
2016-06-17 1:29 ` [PATCH 109/119] xfs: don't mix reflink and DAX mode for now Darrick J. Wong
2016-06-17 1:29 ` [PATCH 110/119] xfs: fail ->bmap for reflink inodes Darrick J. Wong
2016-06-17 1:29 ` [PATCH 111/119] xfs: recognize the reflink feature bit Darrick J. Wong
2016-06-17 1:29 ` [PATCH 112/119] xfs: introduce the XFS_IOC_GETFSMAPX ioctl Darrick J. Wong
2016-06-17 1:30 ` [PATCH 113/119] xfs: scrub btree records and pointers while querying Darrick J. Wong
2016-06-17 1:30 ` [PATCH 114/119] xfs: create sysfs hooks to scrub various files Darrick J. Wong
2016-06-17 1:30 ` [PATCH 115/119] xfs: support scrubbing free space btrees Darrick J. Wong
2016-06-17 1:30 ` [PATCH 116/119] xfs: support scrubbing inode btrees Darrick J. Wong
2016-06-17 1:30 ` [PATCH 117/119] xfs: support scrubbing rmap btree Darrick J. Wong
2016-06-17 1:30 ` [PATCH 118/119] xfs: support scrubbing refcount btree Darrick J. Wong
2016-06-17 1:30 ` [PATCH 119/119] xfs: add btree scrub tracepoints Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627223023.GD4921@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).