* [PATCH] vfs: fix return type of ioctl_file_dedupe_range
@ 2016-08-01 17:13 Darrick J. Wong
2016-08-02 12:24 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Darrick J. Wong @ 2016-08-01 17:13 UTC (permalink / raw)
To: Al Viro, Christoph Hellwig; +Cc: xfs, linux-fsdevel
All the VFS functions in the dedupe ioctl path return int status, so
the ioctl handler ought to as well.
Found by Coverity, CID 1350952.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ioctl.c b/fs/ioctl.c
index 116a333..db3d033 100644
--- a/fs/ioctl.c
+++ b/fs/ioctl.c
@@ -568,7 +568,7 @@ static int ioctl_fsthaw(struct file *filp)
return thaw_super(sb);
}
-static long ioctl_file_dedupe_range(struct file *file, void __user *arg)
+static int ioctl_file_dedupe_range(struct file *file, void __user *arg)
{
struct file_dedupe_range __user *argp = arg;
struct file_dedupe_range *same = NULL;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] vfs: fix return type of ioctl_file_dedupe_range
2016-08-01 17:13 [PATCH] vfs: fix return type of ioctl_file_dedupe_range Darrick J. Wong
@ 2016-08-02 12:24 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2016-08-02 12:24 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Al Viro, Christoph Hellwig, linux-fsdevel, xfs
On Mon, Aug 01, 2016 at 10:13:39AM -0700, Darrick J. Wong wrote:
> All the VFS functions in the dedupe ioctl path return int status, so
> the ioctl handler ought to as well.
>
> Found by Coverity, CID 1350952.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] vfs: fix return type of ioctl_file_dedupe_range
@ 2016-09-15 3:20 Darrick J. Wong
0 siblings, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2016-09-15 3:20 UTC (permalink / raw)
To: torvalds
Cc: Christoph Hellwig, david, viro, linux-xfs, Kirill A. Shutemov,
xfs, linux-fsdevel, linux-api
All the VFS functions in the dedupe ioctl path return int status, so
the ioctl handler ought to as well.
Found by Coverity, CID 1350952.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ioctl.c b/fs/ioctl.c
index 0f56deb..26aba09 100644
--- a/fs/ioctl.c
+++ b/fs/ioctl.c
@@ -568,7 +568,7 @@ static int ioctl_fsthaw(struct file *filp)
return thaw_super(sb);
}
-static long ioctl_file_dedupe_range(struct file *file, void __user *arg)
+static int ioctl_file_dedupe_range(struct file *file, void __user *arg)
{
struct file_dedupe_range __user *argp = arg;
struct file_dedupe_range *same = NULL;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] vfs: fix return type of ioctl_file_dedupe_range
@ 2016-02-10 18:10 Darrick J. Wong
0 siblings, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2016-02-10 18:10 UTC (permalink / raw)
To: Al Viro; +Cc: linux-fsdevel
All the VFS functions in the dedupe ioctl path return int status, so
the ioctl handler ought to as well.
Found by Coverity, CID 1350952.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ioctl.c b/fs/ioctl.c
index 116a333..db3d033 100644
--- a/fs/ioctl.c
+++ b/fs/ioctl.c
@@ -568,7 +568,7 @@ static int ioctl_fsthaw(struct file *filp)
return thaw_super(sb);
}
-static long ioctl_file_dedupe_range(struct file *file, void __user *arg)
+static int ioctl_file_dedupe_range(struct file *file, void __user *arg)
{
struct file_dedupe_range __user *argp = arg;
struct file_dedupe_range *same = NULL;
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-15 3:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-01 17:13 [PATCH] vfs: fix return type of ioctl_file_dedupe_range Darrick J. Wong
2016-08-02 12:24 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2016-09-15 3:20 Darrick J. Wong
2016-02-10 18:10 Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).