From: Salah Triki <salah.triki@gmail.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
mhocko@suse.com, vdavydov@virtuozzo.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] fs: befs: remove useless initialization to zero
Date: Sat, 6 Aug 2016 19:36:38 +0100 [thread overview]
Message-ID: <20160806183638.GC3423@pc> (raw)
In-Reply-To: <579F5232.401@osg.samsung.com>
On Mon, Aug 01, 2016 at 02:44:18PM +0100, Luis de Bethencourt wrote:
> On 31/07/16 21:34, Salah Triki wrote:
> > node_off is unconditionally set to bt_super.root_node_ptr, so no need to
> > init it to zero.
> >
> > Signed-off-by: Salah Triki <salah.triki@gmail.com>
> > ---
> > fs/befs/btree.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/befs/btree.c b/fs/befs/btree.c
> > index f33fc6c..3cb97e8 100644
> > --- a/fs/befs/btree.c
> > +++ b/fs/befs/btree.c
> > @@ -420,7 +420,7 @@ befs_btree_read(struct super_block *sb, const befs_data_stream *ds,
> > {
> > struct befs_btree_node *this_node;
> > befs_btree_super bt_super;
> > - befs_off_t node_off = 0;
> > + befs_off_t node_off;
> > int cur_key;
> > fs64 *valarray;
> > char *keystart;
> >
>
> Looks good to me.
>
> Strange that static analysis didn't pick this one up before.
>
> Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>
> Pushed to the befs-next branch:
> https://github.com/luisbg/linux-befs/tree/befs-next
>
> Thanks Salah,
> Luis
Thanx :)
Salah
next prev parent reply other threads:[~2016-08-06 21:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 20:34 [PATCH 1/6] fs: befs: remove unneeded initialization to zero Salah Triki
2016-07-31 20:34 ` [PATCH 2/6] fs: befs: remove in vain variable assignment Salah Triki
2016-08-01 13:24 ` Luis de Bethencourt
2016-08-06 18:35 ` Salah Triki
2016-07-31 20:34 ` [PATCH 3/6] fs: befs: remove useless initialization to zero Salah Triki
2016-08-01 13:44 ` Luis de Bethencourt
2016-08-06 18:36 ` Salah Triki [this message]
2016-07-31 20:34 ` [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable Salah Triki
2016-08-01 14:02 ` Luis de Bethencourt
2016-08-06 18:37 ` Salah Triki
2016-07-31 20:34 ` [PATCH 5/6] fs: befs: remove in vain variable assignment Salah Triki
2016-08-01 14:17 ` Luis de Bethencourt
2016-07-31 20:34 ` [PATCH 6/6] fs: befs: remove ret variable Salah Triki
2016-08-01 14:23 ` Luis de Bethencourt
2016-08-01 12:51 ` [PATCH 1/6] fs: befs: remove unneeded initialization to zero Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160806183638.GC3423@pc \
--to=salah.triki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@osg.samsung.com \
--cc=mhocko@suse.com \
--cc=vdavydov@virtuozzo.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).