From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: Salah Triki <salah.triki@gmail.com>,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk
Cc: mhocko@suse.com, vdavydov@virtuozzo.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] fs: befs: remove unneeded initialization to zero
Date: Mon, 01 Aug 2016 13:51:48 +0100 [thread overview]
Message-ID: <579F45E4.3030108@osg.samsung.com> (raw)
In-Reply-To: <b5c2d119ccfb0759cf8156c534f2270614f0eba2.1469997250.git.salah.triki@gmail.com>
On 31/07/16 21:34, Salah Triki wrote:
> off is reinitialized by befs_read_datastream, so no need to init it with
> zero in the beginning of befs_bt_read_node.
>
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
> fs/befs/btree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/befs/btree.c b/fs/befs/btree.c
> index e59ad20..a0e8cfa 100644
> --- a/fs/befs/btree.c
> +++ b/fs/befs/btree.c
> @@ -196,7 +196,7 @@ static int
> befs_bt_read_node(struct super_block *sb, const befs_data_stream *ds,
> struct befs_btree_node *node, befs_off_t node_off)
> {
> - uint off = 0;
> + uint off;
>
> befs_debug(sb, "---> %s", __func__);
>
>
Hi Salah,
I will quote Andrew here:
"With this code:
int foo;
bar(&foo);
whatever = foo;
some versions of gcc will warn that foo might be used uninitialized.
Other versions of gcc don't do this. That's why the seemingly-unneeded
initializations are there."
You can read the rest of his reply to when I sent the same change 2
months ago :)
https://lkml.org/lkml/2016/6/1/875
Sorry, I agree with him to keep the code as it is.
Nacked.
Thanks,
Luis
prev parent reply other threads:[~2016-08-01 12:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 20:34 [PATCH 1/6] fs: befs: remove unneeded initialization to zero Salah Triki
2016-07-31 20:34 ` [PATCH 2/6] fs: befs: remove in vain variable assignment Salah Triki
2016-08-01 13:24 ` Luis de Bethencourt
2016-08-06 18:35 ` Salah Triki
2016-07-31 20:34 ` [PATCH 3/6] fs: befs: remove useless initialization to zero Salah Triki
2016-08-01 13:44 ` Luis de Bethencourt
2016-08-06 18:36 ` Salah Triki
2016-07-31 20:34 ` [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable Salah Triki
2016-08-01 14:02 ` Luis de Bethencourt
2016-08-06 18:37 ` Salah Triki
2016-07-31 20:34 ` [PATCH 5/6] fs: befs: remove in vain variable assignment Salah Triki
2016-08-01 14:17 ` Luis de Bethencourt
2016-07-31 20:34 ` [PATCH 6/6] fs: befs: remove ret variable Salah Triki
2016-08-01 14:23 ` Luis de Bethencourt
2016-08-01 12:51 ` Luis de Bethencourt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579F45E4.3030108@osg.samsung.com \
--to=luisbg@osg.samsung.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=salah.triki@gmail.com \
--cc=vdavydov@virtuozzo.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).