From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: gregkh@linuxfoundation.org
Cc: wagi@monom.org, yi1.li@linux.intel.com,
takahiro.akashi@linaro.org, luto@kernel.org,
ebiederm@xmission.com, dmitry.torokhov@gmail.com,
arend.vanspriel@broadcom.com, dwmw2@infradead.org,
rjw@rjwysocki.net, atull@kernel.org, moritz.fischer@ettus.com,
pmladek@suse.com, johannes.berg@intel.com,
emmanuel.grumbach@intel.com, luciano.coelho@intel.com,
kvalo@codeaurora.org, torvalds@linux-foundation.org,
keescook@chromium.org, dhowells@redhat.com, pjones@redhat.com,
hdegoede@redhat.com, alan@linux.intel.com, tytso@mit.edu,
dave@stgolabs.net, mawilcox@microsoft.com, tglx@linutronix.de,
peterz@infradead.org, mfuzzey@parkeon.com,
jakub.kicinski@netronome.com, nbroeking@me.com,
jewalt@lgsinnovations.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH v3 2/4] test_firmware: add test case for SIGCHLD on sync fallback
Date: Thu, 29 Jun 2017 13:51:49 -0700 [thread overview]
Message-ID: <20170629205151.5329-3-mcgrof@kernel.org> (raw)
In-Reply-To: <20170629205151.5329-1-mcgrof@kernel.org>
It has been reported that SIGCHLD will trigger an immediate abort
on sync firmware requests which rely on the sysfs interface for a
trigger. This is unexpected behaviour, this reproduces this issue.
This test case currenty fails.
Reported-by: Martin Fuzzey <mfuzzey@parkeon.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
tools/testing/selftests/firmware/fw_fallback.sh | 31 +++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/tools/testing/selftests/firmware/fw_fallback.sh b/tools/testing/selftests/firmware/fw_fallback.sh
index 2e4c22d5abf7..8f511035f783 100755
--- a/tools/testing/selftests/firmware/fw_fallback.sh
+++ b/tools/testing/selftests/firmware/fw_fallback.sh
@@ -134,6 +134,27 @@ load_fw_custom_cancel()
wait
}
+load_fw_fallback_with_child()
+{
+ local name="$1"
+ local file="$2"
+
+ # This is the value already set but we want to be explicit
+ echo 4 >/sys/class/firmware/timeout
+
+ sleep 1 &
+ SECONDS_BEFORE=$(date +%s)
+ echo -n "$name" >"$DIR"/trigger_request 2>/dev/null
+ SECONDS_AFTER=$(date +%s)
+ SECONDS_DELTA=$(($SECONDS_AFTER - $SECONDS_BEFORE))
+ if [ "$SECONDS_DELTA" -lt 4 ]; then
+ RET=1
+ else
+ RET=0
+ fi
+ wait
+ return $RET
+}
trap "test_finish" EXIT
@@ -221,4 +242,14 @@ else
echo "$0: cancelling custom fallback mechanism works"
fi
+set +e
+load_fw_fallback_with_child "nope-signal-$NAME" "$FW"
+if [ "$?" -eq 0 ]; then
+ echo "$0: SIGCHLD on sync ignored as expected" >&2
+else
+ echo "$0: error - sync firmware request cancelled due to SIGCHLD" >&2
+ exit 1
+fi
+set -e
+
exit 0
--
2.11.0
next prev parent reply other threads:[~2017-06-29 20:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 20:51 [PATCH v3 0/4] firmware: few pending fixes Luis R. Rodriguez
2017-06-29 20:51 ` [PATCH v3 1/4] firmware: fix batched requests - wake all waiters Luis R. Rodriguez
2017-06-29 20:51 ` Luis R. Rodriguez [this message]
2017-07-17 16:20 ` [PATCH v3 2/4] test_firmware: add test case for SIGCHLD on sync fallback Greg KH
2017-06-29 20:51 ` [PATCH v3 3/4] firmware: avoid invalid fallback aborts by using killable wait Luis R. Rodriguez
2017-06-29 20:51 ` [PATCH v3 4/4] firmware: send -EINTR on signal abort on fallback mechanism Luis R. Rodriguez
2017-07-17 14:00 ` Greg KH
2017-07-17 16:04 ` Luis R. Rodriguez
2017-07-17 16:20 ` Greg KH
2017-07-18 0:27 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629205151.5329-3-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=alan@linux.intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=atull@kernel.org \
--cc=dave@stgolabs.net \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ebiederm@xmission.com \
--cc=emmanuel.grumbach@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jakub.kicinski@netronome.com \
--cc=jewalt@lgsinnovations.com \
--cc=johannes.berg@intel.com \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=luto@kernel.org \
--cc=mawilcox@microsoft.com \
--cc=mfuzzey@parkeon.com \
--cc=moritz.fischer@ettus.com \
--cc=nbroeking@me.com \
--cc=peterz@infradead.org \
--cc=pjones@redhat.com \
--cc=pmladek@suse.com \
--cc=rjw@rjwysocki.net \
--cc=takahiro.akashi@linaro.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=wagi@monom.org \
--cc=yi1.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).