From: Greg KH <gregkh@linuxfoundation.org>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: wagi@monom.org, yi1.li@linux.intel.com,
takahiro.akashi@linaro.org, luto@kernel.org,
ebiederm@xmission.com, dmitry.torokhov@gmail.com,
arend.vanspriel@broadcom.com, dwmw2@infradead.org,
rjw@rjwysocki.net, atull@kernel.org, moritz.fischer@ettus.com,
pmladek@suse.com, johannes.berg@intel.com,
emmanuel.grumbach@intel.com, luciano.coelho@intel.com,
kvalo@codeaurora.org, torvalds@linux-foundation.org,
keescook@chromium.org, dhowells@redhat.com, pjones@redhat.com,
hdegoede@redhat.com, alan@linux.intel.com, tytso@mit.edu,
dave@stgolabs.net, mawilcox@microsoft.com, tglx@linutronix.de,
peterz@infradead.org, mfuzzey@parkeon.com,
jakub.kicinski@netronome.com, nbroeking@me.com,
jewalt@lgsinnovations.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] firmware: send -EINTR on signal abort on fallback mechanism
Date: Mon, 17 Jul 2017 18:20:37 +0200 [thread overview]
Message-ID: <20170717162037.GA9583@kroah.com> (raw)
In-Reply-To: <20170717160433.GI21846@wotan.suse.de>
On Mon, Jul 17, 2017 at 06:04:33PM +0200, Luis R. Rodriguez wrote:
> On Mon, Jul 17, 2017 at 04:00:07PM +0200, Greg KH wrote:
> > On Thu, Jun 29, 2017 at 01:51:51PM -0700, Luis R. Rodriguez wrote:
> > > Right now we send -EAGAIN to a syfs write which got interrupted.
> > > Userspace can't tell what happened though, send -EINTR if we
> > > were killed due to a signal so userspace can tell things apart.
> > >
> > > This is only applicable to the fallback mechanism.
> > >
> > > Reported-by: Martin Fuzzey <mfuzzey@parkeon.com>
> > > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> > > ---
> > > drivers/base/firmware_class.c | 9 ++++++---
> > > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > This doesn't need to go into 4.13-final, right?
>
> Nope.
>
> > Can it wait for 4.14-rc1?
>
> Yes. The bigger issue was the unexpected signals causing interruption.
> This I consider a secondary and not critical issue so I did not Cc stable.
Ok, can you then take your two series of patches, and split them up into
one for 4.13-final and one for 4.14-rc1 so that I know for sure which is
which? As it is, I have to guess :(
thanks,
greg k-h
next prev parent reply other threads:[~2017-07-17 16:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 20:51 [PATCH v3 0/4] firmware: few pending fixes Luis R. Rodriguez
2017-06-29 20:51 ` [PATCH v3 1/4] firmware: fix batched requests - wake all waiters Luis R. Rodriguez
2017-06-29 20:51 ` [PATCH v3 2/4] test_firmware: add test case for SIGCHLD on sync fallback Luis R. Rodriguez
2017-07-17 16:20 ` Greg KH
2017-06-29 20:51 ` [PATCH v3 3/4] firmware: avoid invalid fallback aborts by using killable wait Luis R. Rodriguez
2017-06-29 20:51 ` [PATCH v3 4/4] firmware: send -EINTR on signal abort on fallback mechanism Luis R. Rodriguez
2017-07-17 14:00 ` Greg KH
2017-07-17 16:04 ` Luis R. Rodriguez
2017-07-17 16:20 ` Greg KH [this message]
2017-07-18 0:27 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717162037.GA9583@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=atull@kernel.org \
--cc=dave@stgolabs.net \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ebiederm@xmission.com \
--cc=emmanuel.grumbach@intel.com \
--cc=hdegoede@redhat.com \
--cc=jakub.kicinski@netronome.com \
--cc=jewalt@lgsinnovations.com \
--cc=johannes.berg@intel.com \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=luto@kernel.org \
--cc=mawilcox@microsoft.com \
--cc=mcgrof@kernel.org \
--cc=mfuzzey@parkeon.com \
--cc=moritz.fischer@ettus.com \
--cc=nbroeking@me.com \
--cc=peterz@infradead.org \
--cc=pjones@redhat.com \
--cc=pmladek@suse.com \
--cc=rjw@rjwysocki.net \
--cc=takahiro.akashi@linaro.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=wagi@monom.org \
--cc=yi1.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).