archive mirror
 help / color / mirror / Atom feed
From: Mark Fasheh <>
To: "Darrick J. Wong" <>
Cc:,,, Adam Borowski <>
Subject: Re: [PATCH v2 1/2] vfs: allow dedupe of user owned read-only files
Date: Sat, 19 May 2018 00:06:51 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20180518220338.GA31250@magnolia>

On Fri, May 18, 2018 at 03:03:38PM -0700, Darrick J. Wong wrote:
> > +/* Check whether we are allowed to dedupe the destination file */
> > +static int allow_file_dedupe(struct file *file)
> Shouldn't this return bool?  It's a predicate, after all...

Yeah that should be bool. Thanks for pointing it out, I'll fix it up in the
next round.

  reply	other threads:[~2018-05-18 22:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 21:57 [PATCH v2 0/2] vfs: better dedupe permission check Mark Fasheh
2018-05-18 21:57 ` [PATCH v2 1/2] vfs: allow dedupe of user owned read-only files Mark Fasheh
2018-05-18 22:03   ` Darrick J. Wong
2018-05-18 22:06     ` Mark Fasheh [this message]
2018-05-18 21:57 ` [PATCH v2 2/2] vfs: dedupe should return EPERM if permission is not granted Mark Fasheh
2018-05-18 22:04   ` Darrick J. Wong
2018-05-18 22:08     ` Mark Fasheh
2018-05-21 12:35   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).