From: Mark Fasheh <mfasheh@suse.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-xfs@vger.kernel.org, Adam Borowski <kilobyte@angband.pl>
Subject: Re: [PATCH v2 2/2] vfs: dedupe should return EPERM if permission is not granted
Date: Sat, 19 May 2018 00:08:02 +0200 [thread overview]
Message-ID: <20180518220802.GD28045@wotan.suse.de> (raw)
In-Reply-To: <20180518220413.GB31250@magnolia>
On Fri, May 18, 2018 at 03:04:13PM -0700, Darrick J. Wong wrote:
> On Fri, May 18, 2018 at 02:57:27PM -0700, Mark Fasheh wrote:
> > Right now we return EINVAL if a process does not have permission to dedupe a
> > file. This was an oversight on my part. EPERM gives a true description of
> > the nature of our error, and EINVAL is already used for the case that the
> > filesystem does not support dedupe.
> >
> > Signed-off-by: Mark Fasheh <mfasheh@suse.de>
>
> Looks ok what with all the okays after I squawked last time,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Awesome, I'll put that in the patch. Thanks Darrick.
--Mark
next prev parent reply other threads:[~2018-05-18 22:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 21:57 [PATCH v2 0/2] vfs: better dedupe permission check Mark Fasheh
2018-05-18 21:57 ` [PATCH v2 1/2] vfs: allow dedupe of user owned read-only files Mark Fasheh
2018-05-18 22:03 ` Darrick J. Wong
2018-05-18 22:06 ` Mark Fasheh
2018-05-18 21:57 ` [PATCH v2 2/2] vfs: dedupe should return EPERM if permission is not granted Mark Fasheh
2018-05-18 22:04 ` Darrick J. Wong
2018-05-18 22:08 ` Mark Fasheh [this message]
2018-05-21 12:35 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518220802.GD28045@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=darrick.wong@oracle.com \
--cc=kilobyte@angband.pl \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).