From: Christoph Hellwig <hch@infradead.org>
To: Kent Overstreet <kent.overstreet@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Dave Chinner <dchinner@redhat.com>,
darrick.wong@oracle.com, tytso@mit.edu,
linux-btrfs@vger.kernel.org, clm@fb.com, jbacik@fb.com,
viro@zeniv.linux.org.uk, peterz@infradead.org
Subject: Re: [PATCH 01/10] mm: pagecache add lock
Date: Wed, 23 May 2018 08:22:39 -0700 [thread overview]
Message-ID: <20180523152239.GA2425@infradead.org> (raw)
In-Reply-To: <20180520224524.GC11495@kmo-pixel>
On Sun, May 20, 2018 at 06:45:24PM -0400, Kent Overstreet wrote:
> >
> > Honestly I think this probably should be in the core. But IFF we move
> > it to the core the existing users of per-fs locks need to be moved
> > over first. E.g. XFS as the very first one, and at least ext4 and f2fs
> > that copied the approach, and probably more if you audit deep enough.
>
> I'm not going to go and redo locking in XFS and ext4 as a prerequisite to
> merging bcachefs. Sorry, but that's a bit crazy.
It isn't crazy at all. In general we expect people to do their fair
share of core work to get their pet feature in. How much is acceptable
is a difficult question and not black and white.
But if you want to grow a critical core structure you better take a stab
at converting existing users. Without that the tradeoff of growing
that core structure is simply not given.
Or to put it in words for this exact feature: unless your new field
is also used by mainstream file systems it is not going to be added.
next prev parent reply other threads:[~2018-05-23 15:22 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 7:48 [PATCH 00/10] RFC: assorted bcachefs patches Kent Overstreet
2018-05-18 7:49 ` [PATCH 01/10] mm: pagecache add lock Kent Overstreet
2018-05-18 13:13 ` Matthew Wilcox
2018-05-18 15:53 ` Christoph Hellwig
2018-05-18 17:45 ` Kent Overstreet
2018-05-23 23:55 ` Notes on locking for pagacache consistency (was: [PATCH 01/10] mm: pagecache add lock) Kent Overstreet
2018-05-20 22:45 ` [PATCH 01/10] mm: pagecache add lock Kent Overstreet
2018-05-23 15:22 ` Christoph Hellwig [this message]
2018-05-23 17:12 ` Kent Overstreet
2018-05-18 7:49 ` [PATCH 02/10] mm: export find_get_pages() Kent Overstreet
2018-05-18 16:00 ` Christoph Hellwig
2018-05-18 7:49 ` [PATCH 03/10] locking: bring back lglocks Kent Overstreet
2018-05-18 9:51 ` Peter Zijlstra
2018-05-18 10:13 ` Kent Overstreet
2018-05-18 11:03 ` Peter Zijlstra
2018-05-18 11:39 ` Kent Overstreet
2018-05-18 7:49 ` [PATCH 04/10] locking: export osq_lock()/osq_unlock() Kent Overstreet
2018-05-18 9:52 ` Peter Zijlstra
2018-05-18 10:18 ` Kent Overstreet
2018-05-18 11:08 ` Peter Zijlstra
2018-05-18 11:32 ` Kent Overstreet
2018-05-18 11:40 ` Peter Zijlstra
2018-05-18 12:40 ` Kent Overstreet
2018-05-18 7:49 ` [PATCH 05/10] don't use spin_lock_irqsave() unnecessarily Kent Overstreet
2018-05-18 16:01 ` Christoph Hellwig
2018-05-18 7:49 ` [PATCH 06/10] Generic radix trees Kent Overstreet
2018-05-18 16:02 ` Christoph Hellwig
2018-05-18 17:38 ` Kent Overstreet
2018-05-18 7:49 ` [PATCH 07/10] bcache: optimize continue_at_nobarrier() Kent Overstreet
2018-05-18 7:49 ` [PATCH 08/10] bcache: move closures to lib/ Kent Overstreet
2018-05-18 16:02 ` Christoph Hellwig
2018-05-18 7:49 ` [PATCH 09/10] closures: closure_wait_event() Kent Overstreet
2018-05-18 7:49 ` [PATCH 10/10] Dynamic fault injection Kent Overstreet
2018-05-18 16:02 ` Christoph Hellwig
2018-05-18 17:37 ` Kent Overstreet
2018-05-18 19:05 ` Andreas Dilger
2018-05-18 19:10 ` Kent Overstreet
2018-05-18 20:54 ` Andreas Dilger
2018-05-18 7:55 ` [PATCH 00/10] RFC: assorted bcachefs patches Kent Overstreet
2018-05-18 17:45 ` Josef Bacik
2018-05-18 17:49 ` Kent Overstreet
2018-05-18 18:03 ` Josef Bacik
2018-05-18 18:28 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523152239.GA2425@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=clm@fb.com \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=jbacik@fb.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).