From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
Toshi Kani <toshi.kani@hpe.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, Dave Jiang <dave.jiang@intel.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns
Date: Thu, 31 May 2018 14:41:22 -0600 [thread overview]
Message-ID: <20180531204122.GC28256@linux.intel.com> (raw)
In-Reply-To: <20180531191332.GB7825@magnolia>
On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote:
> On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote:
> > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote:
> > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote:
> > > > From: Dave Jiang <dave.jiang@intel.com>
> > > >
> > > > The function return values are confusing with the way the function is
> > > > named. We expect a true or false return value but it actually returns
> > > > 0/-errno. This makes the code very confusing. Changing the return values
> > > > to return a bool where if DAX is supported then return true and no DAX
> > > > support returns false.
> > > >
> > > > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > > > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > >
> > > Looks ok, do you want me to pull the first two patches through the xfs
> > > tree?
> > >
> > > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Thanks for the review.
> >
> > I'm not sure what's best. If you do that then Mike will need to have a DM
> > branch for the rest of the series based on your stable commits, yea?
> >
> > Mike what would you prefer?
>
> I /was/ about to say that I would pull in the first two patches, but now
> I can't get xfs to mount with pmem at all, and have no way of testing
> this...?
>
> # echo 'file drivers/dax/* +p' > /sys/kernel/debug/dynamic_debug/control
> # mount /dev/pmem3 -o rtdev=/dev/pmem4,dax /mnt
> # dmesg
> <snip>
> SGI XFS with ACLs, security attributes, realtime, scrub, debug enabled
> XFS (pmem3): DAX enabled. Warning: EXPERIMENTAL, use at your own risk
> pmem3: error: dax support not enabled
> pmem4: error: dax support not enabled
> XFS (pmem3): DAX unsupported by block device. Turning off DAX.
> XFS (pmem3): Mounting V5 Filesystem
> XFS (pmem3): Ending clean mount
This same sequence worked fine in my QEMU setup.
My guess is the issue is that your namespaces are in raw mode:
# ndctl list
[
{
"dev":"namespace1.0",
"mode":"raw", << this
"size":18119393280,
"sector_size":512,
"blockdev":"pmem1",
"numa_node":0
},
{
"dev":"namespace0.0",
"mode":"raw", << this
"size":18119393280,
"sector_size":512,
"blockdev":"pmem0",
"numa_node":0
}
]
If so, you can solve this by putting them in fsdax mode with ndctl:
# ndctl create-namespace -f -e namespace0.0 --mode=fsdax
{
"dev":"namespace0.0",
"mode":"fsdax",
"size":"16.61 GiB (17.83 GB)",
"uuid":"4c193c83-c031-41d4-8f96-2ff5c7b59c69",
"raw_uuid":"2f785f09-717a-4a5e-9e9d-88d489ef1030",
"sector_size":512,
"blockdev":"pmem0",
"numa_node":0
}
# ndctl create-namespace -f -e namespace1.0 --mode=fsdax
{
"dev":"namespace1.0",
"mode":"fsdax",
"size":"16.61 GiB (17.83 GB)",
"uuid":"39ec9cc4-a7ef-4f99-8354-60105543bf47",
"raw_uuid":"403fae76-d4f8-4bed-9a3f-ef40924762be",
"sector_size":512,
"blockdev":"pmem1",
"numa_node":0
}
If that doesn't fix it for you, ping me on freenode and we'll figure it out.
Thanks,
- Ross
next prev parent reply other threads:[~2018-05-31 20:41 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 19:50 [PATCH v2 0/7] Fix DM DAX handling Ross Zwisler
2018-05-29 19:51 ` [PATCH v2 1/7] fs: allow per-device dax status checking for filesystems Ross Zwisler
2018-05-29 19:51 ` [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns Ross Zwisler
2018-05-29 21:25 ` Darrick J. Wong
2018-05-29 22:01 ` Ross Zwisler
2018-05-31 19:13 ` Darrick J. Wong
2018-05-31 20:34 ` Ross Zwisler
2018-05-31 20:35 ` Dan Williams
2018-05-31 20:41 ` Ross Zwisler [this message]
2018-05-31 20:52 ` Mike Snitzer
2018-05-31 22:26 ` [dm-devel] " Darrick J. Wong
2018-06-01 20:59 ` Ross Zwisler
2018-06-01 1:26 ` Dave Chinner
2018-06-01 1:57 ` Dan Williams
2018-06-01 2:24 ` Dave Chinner
2018-06-01 4:02 ` Dan Williams
2018-06-03 22:20 ` Dave Chinner
2018-06-04 0:25 ` Dave Chinner
2018-06-04 1:48 ` Dan Williams
2018-06-04 23:40 ` Dan Williams
2018-06-05 0:33 ` Mike Snitzer
2018-06-05 5:55 ` Dave Chinner
2018-06-05 3:32 ` Dan Williams
2018-05-29 19:51 ` [PATCH v2 3/7] dm: fix test for DAX device support Ross Zwisler
2018-06-01 20:19 ` Mike Snitzer
2018-06-01 20:46 ` Mike Snitzer
2018-06-01 21:11 ` Ross Zwisler
2018-06-01 21:16 ` Dan Williams
2018-05-29 19:51 ` [PATCH v2 4/7] dm: prevent DAX mounts if not supported Ross Zwisler
2018-06-01 21:55 ` Mike Snitzer
2018-06-04 23:15 ` Ross Zwisler
2018-06-20 15:17 ` Mike Snitzer
2018-06-25 19:20 ` Ross Zwisler
2018-05-29 19:51 ` [PATCH v2 5/7] dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode Ross Zwisler
2018-06-01 22:04 ` Mike Snitzer
2018-06-04 23:24 ` Ross Zwisler
2018-06-04 23:49 ` Kani, Toshi
2018-06-05 0:46 ` Mike Snitzer
2018-06-06 17:24 ` Ross Zwisler
2018-06-06 22:29 ` Mike Snitzer
2018-05-29 19:51 ` [PATCH v2 6/7] dm-snap: remove unnecessary direct_access() stub Ross Zwisler
2018-05-29 19:51 ` [PATCH v2 7/7] dm-error: " Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531204122.GC28256@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=darrick.wong@oracle.com \
--cc=dave.jiang@intel.com \
--cc=dm-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).