From: Mark Fasheh <mfasheh@suse.de>
To: Al Viro <viro@ZenIV.linux.org.uk>, linux-fsdevel@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Amir Goldstein <amir73il@gmail.com>,
linux-unionfs@vger.kernel.org, Jeff Mahoney <jeffm@suse.com>,
linux-nfs@vger.kernel.org, Mark Fasheh <mfasheh@suse.de>
Subject: [PATCH 1/4] vfs: introduce function to map unique ino/dev pairs
Date: Tue, 31 Jul 2018 14:10:42 -0700 [thread overview]
Message-ID: <20180731211045.5671-2-mfasheh@suse.de> (raw)
In-Reply-To: <20180731211045.5671-1-mfasheh@suse.de>
There are places in the VFS where we export an ino/dev pair to userspace.
/proc/PID/maps is a good example - we directly expose inode->i_ino and
inode->i_sb->s_dev to userspace there. Many filesystems don't put a unique
value in inode->i_ino and instead rely on ->getattr to provide the real
inode number to userspace. super->s_dev is similar - some filesystems
expose a difference device from what's put in super->s_dev when queried via
stat/statx.
Ultimately this makes it impossible for a user (or software) to match one of
those reported pairs to the right inode.
We can fix this by adding a helper function, vfs_map_unique_ino_dev(), which
will query the owning filesystem (via ->getattr) to get the correct ino/dev
pair. Later patches will update those places which simply dump inode->i_ino
and super->s_dev to use the helper.
Signed-off-by: Mark Fasheh <mfasheh@suse.de>
---
fs/stat.c | 23 +++++++++++++++++++++++
include/linux/fs.h | 2 ++
2 files changed, 25 insertions(+)
diff --git a/fs/stat.c b/fs/stat.c
index f8e6fb2c3657..80ea42505219 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -84,6 +84,29 @@ int vfs_getattr_nosec(const struct path *path, struct kstat *stat,
}
EXPORT_SYMBOL(vfs_getattr_nosec);
+void vfs_map_unique_ino_dev(struct dentry *dentry, u64 *ino, dev_t *dev)
+{
+ int ret;
+ struct path path;
+ struct kstat stat;
+
+ path.mnt = NULL;
+ path.dentry = dentry;
+ /* ->dev is always returned, so we only need to specify ino here */
+ ret = vfs_getattr_nosec(&path, &stat, STATX_INO, 0);
+ if (ret) {
+ struct inode *inode = d_inode(dentry);
+ /* Fallback to old behavior in case of getattr error */
+ *ino = inode->i_ino;
+ *dev = inode->i_sb->s_dev;
+ return ret;
+ }
+ *ino = stat.ino;
+ *dev = stat.dev;
+ return 0;
+}
+EXPORT_SYMBOL(vfs_map_unique_ino_dev);
+
/*
* vfs_getattr - Get the enhanced basic attributes of a file
* @path: The file of interest
diff --git a/include/linux/fs.h b/include/linux/fs.h
index d78d146a98da..b80789472438 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3077,6 +3077,8 @@ extern void kfree_link(void *);
extern void generic_fillattr(struct inode *, struct kstat *);
extern int vfs_getattr_nosec(const struct path *, struct kstat *, u32, unsigned int);
extern int vfs_getattr(const struct path *, struct kstat *, u32, unsigned int);
+extern void vfs_map_unique_ino_dev(struct dentry *dentry, u64 *ino, dev_t *dev);
+
void __inode_add_bytes(struct inode *inode, loff_t bytes);
void inode_add_bytes(struct inode *inode, loff_t bytes);
void __inode_sub_bytes(struct inode *inode, loff_t bytes);
--
2.15.1
next prev parent reply other threads:[~2018-07-31 22:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 21:10 [RFC PATCH 0/4] vfs: map unique ino/dev pairs for user space Mark Fasheh
2018-07-31 21:10 ` Mark Fasheh [this message]
2018-07-31 23:21 ` [PATCH 1/4] vfs: introduce function to map unique ino/dev pairs Mark Fasheh
2018-08-01 5:41 ` Amir Goldstein
2018-08-01 15:59 ` Mark Fasheh
2018-07-31 21:10 ` [PATCH 2/4] nfs: check for NULL vfsmount in nfs_getattr Mark Fasheh
2018-07-31 22:16 ` Al Viro
2018-07-31 22:51 ` Mark Fasheh
2018-08-02 0:43 ` Al Viro
2018-08-03 2:04 ` Mark Fasheh
2018-07-31 21:10 ` [PATCH 3/4] proc: use vfs helper to get ino/dev pairs for maps file Mark Fasheh
2018-07-31 21:10 ` [PATCH 4/4] locks: map correct ino/dev pairs when exporting to userspace Mark Fasheh
2018-08-01 5:37 ` Amir Goldstein
2018-08-01 17:45 ` Mark Fasheh
2018-08-01 11:03 ` Jeff Layton
2018-08-01 20:38 ` Mark Fasheh
2018-08-02 0:24 ` [RFC PATCH 0/4] vfs: map unique ino/dev pairs for user space J. R. Okajima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731211045.5671-2-mfasheh@suse.de \
--to=mfasheh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).