From: Andrew Morton <akpm@linux-foundation.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: konishi.ryusuke@lab.ntt.co.jp, viro@zeniv.linux.org.uk,
tytso@mit.edu, adilger.kernel@dilger.ca, axboe@kernel.dk,
darrick.wong@oracle.com, ebiggers@google.com,
pombredanne@nexb.com, agruenba@redhat.com,
gregkh@linuxfoundation.org, kemi.wang@intel.com,
willy@infradead.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-nilfs@vger.kernel.org
Subject: Re: [PATCH v2] fs: Convert return type int to vm_fault_t
Date: Thu, 30 Aug 2018 16:33:52 -0700 [thread overview]
Message-ID: <20180830163352.5a96cc721ce069bed95fdbe8@linux-foundation.org> (raw)
In-Reply-To: <20180830172547.GA4408@jordon-HP-15-Notebook-PC>
On Thu, 30 Aug 2018 22:55:47 +0530 Souptick Joarder <jrdr.linux@gmail.com> wrote:
> Return type for fault handlers in ext4 and nilfs are
> changed to use vm_fault_t.
>
> Return type of block_page_mkwrite() is changed from
> int to vm_fault_t. The function signature of
> block_page_mkwrite() is changed to add one new parameter
> int *err. This will provide a way for caller functions
> to get error value along with return value and use it
> further.
>
> Return type of block_page_mkwrite_return() is also changed
> to use new vm_fault_t type.
> --- a/fs/nilfs2/file.c
> +++ b/fs/nilfs2/file.c
> @@ -51,13 +51,14 @@ int nilfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
> return err;
> }
>
> -static int nilfs_page_mkwrite(struct vm_fault *vmf)
> +static vm_fault_t nilfs_page_mkwrite(struct vm_fault *vmf)
nilfs_page_mkwrite() already has return type vm_fault_t in Linus's
kernel, due to the now-merged
fs-nilfs2-adding-new-return-type-vm_fault_t.patch. Looks like a simple
fix.
I'm beginning to feel vm_fault_t exhaustion. Please remind me what
benefit we're going to get out of all this churn?
>
> ...
>
next prev parent reply other threads:[~2018-08-31 3:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 17:25 [PATCH v2] fs: Convert return type int to vm_fault_t Souptick Joarder
2018-08-30 23:33 ` Andrew Morton [this message]
2018-08-31 6:03 ` Souptick Joarder
2018-09-04 0:28 ` Andrew Morton
2018-09-04 2:13 ` Matthew Wilcox
2018-09-03 2:13 ` Ryusuke Konishi
2018-09-03 11:58 ` Souptick Joarder
2018-08-30 23:35 ` Andrew Morton
2018-08-31 16:58 ` Theodore Y. Ts'o
2018-09-01 16:21 ` Souptick Joarder
2018-09-03 4:49 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830163352.5a96cc721ce069bed95fdbe8@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adilger.kernel@dilger.ca \
--cc=agruenba@redhat.com \
--cc=axboe@kernel.dk \
--cc=darrick.wong@oracle.com \
--cc=ebiggers@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jrdr.linux@gmail.com \
--cc=kemi.wang@intel.com \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).