From: john.hubbard@gmail.com
To: Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Christopher Lameter <cl@linux.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.cz>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH 0/6] RFC: gup+dma: tracking dma-pinned pages
Date: Thu, 11 Oct 2018 23:00:08 -0700 [thread overview]
Message-ID: <20181012060014.10242-1-jhubbard@nvidia.com> (raw)
From: John Hubbard <jhubbard@nvidia.com>
Here is an updated proposal for tracking pages that have had
get_user_pages*() called on them. This is in support of fixing the problem
discussed in [1]. This RFC only shows how to set up a reliable
PageDmaPinned flag. What to *do* with that flag is left for a later
discussion.
I'm providing this in order to help the discussion about patches 1-3, which
I'm hoping to check in first. The sequence would be:
-- apply patches 1-3, convert the rest of the subsystems to call
put_user_page*(), then
-- apply patches 4-6, then
-- Apply more patches, to actually use the new PageDmaPinned flag.
One question up front is, "how do we ensure that either put_user_page()
or put_page() are called, depending on whether the page came from
get_user_pages() or not?". From this series, you can see that:
-- It's possible to assert within put_user_page(), that we are in the
right place.
-- It's less clear that there is a way to assert within put_page(),
because put_page() is called from put_user_page(), and PageDmaPinned
may or may not be set--either case is valid.
Opinions and ideas are welcome there.
This is a lightly tested example (it boots up on x86_64, and just lets the
dma-pinned pages leak, in all non-infiniband cases...which is all cases, on
my particular test computer). This series just does the following:
a) Provides the put_user_page*() routines that have been discussed in
another thread (patch 2).
b) Provides a single example of converting some code (infiniband) to use
those routines (patch 3).
c) Connects up get_user_pages*() to use the new refcounting and flags
fieldsj (patches 4-6)
[1] https://lwn.net/Articles/753027/ : "The Trouble with get_user_pages()"
John Hubbard (6):
mm: get_user_pages: consolidate error handling
mm: introduce put_user_page*(), placeholder versions
infiniband/mm: convert put_page() to put_user_page*()
mm: introduce page->dma_pinned_flags, _count
mm: introduce zone_gup_lock, for dma-pinned pages
mm: track gup pages with page->dma_pinned_* fields
drivers/infiniband/core/umem.c | 7 +-
drivers/infiniband/core/umem_odp.c | 2 +-
drivers/infiniband/hw/hfi1/user_pages.c | 11 +-
drivers/infiniband/hw/mthca/mthca_memfree.c | 6 +-
drivers/infiniband/hw/qib/qib_user_pages.c | 11 +-
drivers/infiniband/hw/qib/qib_user_sdma.c | 6 +-
drivers/infiniband/hw/usnic/usnic_uiom.c | 7 +-
include/linux/mm.h | 9 ++
include/linux/mm_types.h | 22 +++-
include/linux/mmzone.h | 6 +
include/linux/page-flags.h | 47 +++++++
mm/gup.c | 93 +++++++++++---
mm/memcontrol.c | 7 +
mm/page_alloc.c | 1 +
mm/swap.c | 134 ++++++++++++++++++++
15 files changed, 319 insertions(+), 50 deletions(-)
--
2.19.1
next reply other threads:[~2018-10-12 6:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 6:00 john.hubbard [this message]
2018-10-12 6:00 ` [PATCH 1/6] mm: get_user_pages: consolidate error handling john.hubbard
2018-10-12 6:30 ` Balbir Singh
2018-10-12 22:45 ` John Hubbard
2018-10-12 6:00 ` [PATCH 2/6] mm: introduce put_user_page*(), placeholder versions john.hubbard
2018-10-12 7:35 ` Balbir Singh
2018-10-12 22:31 ` John Hubbard
2018-10-12 6:00 ` [PATCH 3/6] infiniband/mm: convert put_page() to put_user_page*() john.hubbard
2018-10-12 6:00 ` [PATCH 4/6] mm: introduce page->dma_pinned_flags, _count john.hubbard
2018-10-12 10:56 ` Balbir Singh
2018-10-13 0:15 ` John Hubbard
2018-10-24 11:00 ` Balbir Singh
2018-11-02 23:27 ` John Hubbard
2018-10-13 3:55 ` Dave Chinner
2018-10-13 7:34 ` John Hubbard
2018-10-13 16:47 ` Christoph Hellwig
2018-10-13 21:19 ` John Hubbard
2018-11-05 7:10 ` John Hubbard
2018-11-05 9:54 ` Jan Kara
2018-11-06 0:26 ` John Hubbard
2018-11-06 2:47 ` Dave Chinner
2018-11-06 11:00 ` Jan Kara
2018-11-06 20:41 ` Dave Chinner
2018-11-07 6:36 ` John Hubbard
2018-10-13 23:01 ` Dave Chinner
2018-10-16 8:51 ` Jan Kara
2018-10-17 1:48 ` John Hubbard
2018-10-17 11:09 ` Michal Hocko
2018-10-18 0:03 ` John Hubbard
2018-10-19 8:11 ` Michal Hocko
2018-10-12 6:00 ` [PATCH 5/6] mm: introduce zone_gup_lock, for dma-pinned pages john.hubbard
2018-10-12 6:00 ` [PATCH 6/6] mm: track gup pages with page->dma_pinned_* fields john.hubbard
2018-10-12 11:07 ` Balbir Singh
2018-10-13 0:33 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012060014.10242-1-jhubbard@nvidia.com \
--to=john.hubbard@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).