From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: Fwd: posix_acl_permission() and MAY_* flags
Date: Sat, 13 Oct 2018 04:40:11 +0100 [thread overview]
Message-ID: <20181013034010.GK32577@ZenIV.linux.org.uk> (raw)
In-Reply-To: <ADCDD815-9330-4BF2-B3BB-67F7AA223098@dilger.ca>
On Thu, Oct 11, 2018 at 06:43:57PM -0600, Andreas Dilger wrote:
> I was looking at POSIX ACL on-disk and in-memory code and it looks like
> there is a subtle dependency between the on-disk format and what (IMHO)
> would be considered in-memory declarations.
>
> When a POSIX ACL is read from disk, posix_acl_from_mode() copies the file
> mode (S_I[RWX][UGO]) into the e_perm fields of the ACL default entries.
> Similarly, in posix_acl_equiv_mode() and posix_acl_create_masq() it uses
> S_IRWXO to mask the e_perm flags.
>
> However, later on in posix_acl_permission() it directly uses the "want"
> flag contains MAY_{READ,WRITE,EXEC} flags and compares those to e_perm of
> each ACL entry.
>
> In posix_acl_valid() it compares e_perm with ACL_{READ,WRITE,EXECUTE}.
>
> While the MAY_[RWX] and ACL_[RWX] currently have the same value as
> S_I[RWX]OTH, it isn't very clear that these flags MUST all have the same
> values or POSIX ACLs will break.
>
> This definitely doesn't seem quite right. Are the ACL_* constants the
> values to be used, with "conversion" in between the flags/modes? Should
> there be a BUILD_BUG_ON() that trips if those values ever differ?
Encoding of rwx bits is pretty much cast in stone - they go all way back
to v1 (if not to PDP7 times) and I can't imagine any Unix variant that
would have them not in the same order. MAY_... is tied to those and
so are the bits in ->e_perm.
IOW, all of those are in practice immutable - too closely tied to on-disk
data structures in a lot of filesystems *and* to any number of userland
programs using explicit octal values for mkdir(), etc. arguments.
Symbolic constants != can realistically be redefined...
prev parent reply other threads:[~2018-10-13 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1254FD78-8392-4B97-A191-EDA01B719635@whamcloud.com>
2018-10-12 0:43 ` Fwd: posix_acl_permission() and MAY_* flags Andreas Dilger
2018-10-12 9:09 ` Andreas Grünbacher
2018-10-13 3:56 ` Al Viro
2018-10-13 4:08 ` Andreas Dilger
2018-10-13 4:37 ` Al Viro
2018-10-13 3:40 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181013034010.GK32577@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=adilger@dilger.ca \
--cc=agruenba@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).