[PATCH] fs/buffer.c: include fs/internal.h for missing prototypes

[PATCH] fs/buffer.c: include fs/internal.h for missing prototypes

[Eric Biggers]

From: Eric Biggers <ebiggers@google.com>

__block_write_begin_int(), __generic_write_end(), and guard_bio_eod()
are defined in fs/buffer.c and declared in fs/internal.h, but the
declarations aren't included at the point of the definitions.  Include
the header to enforce that the definitions match the declarations.

This addresses gcc warnings when -Wmissing-prototypes is enabled.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/buffer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/buffer.c b/fs/buffer.c
index 1286c2b95498d..3581e42cf6cbb 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -46,6 +46,7 @@
 #include <linux/pagevec.h>
 #include <linux/sched/mm.h>
 #include <trace/events/block.h>
+#include "internal.h"
 
 static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
 static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
-- 
2.19.1.930.g4563a0d9d0-goog

[PATCH] fs/buffer.c: include fs/internal.h for missing prototypes

[Eric Biggers]

From: Eric Biggers <ebiggers@google.com>

Include fs/internal.h to address the following 'sparse' warnings:

    fs/buffer.c:1930:5: warning: symbol '__block_write_begin_int' was not declared. Should it be static?
    fs/buffer.c:2089:6: warning: symbol '__generic_write_end' was not declared. Should it be static?
    fs/buffer.c:2998:6: warning: symbol 'guard_bio_eod' was not declared. Should it be static?

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/buffer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/buffer.c b/fs/buffer.c
index e450c55f64342..f3c21f2266a5a 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -48,6 +48,8 @@
 #include <linux/sched/mm.h>
 #include <trace/events/block.h>
 
+#include "internal.h"
+
 static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
 static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
 			 enum rw_hint hint, struct writeback_control *wbc);
-- 
2.22.0.rc1.257.g3120a18244-goog