From: Matthew Wilcox <willy@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jan Kara <jack@suse.cz>, Dave Jiang <dave.jiang@intel.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/2] dax: Don't access a freed inode
Date: Wed, 28 Nov 2018 09:10:04 -0800 [thread overview]
Message-ID: <20181128171004.GI10377@bombadil.infradead.org> (raw)
In-Reply-To: <CAPcyv4iqYNq1FMwU9W-oq+2mWGHotK=Ff9YvEyJOxRz3E+eDzQ@mail.gmail.com>
On Wed, Nov 28, 2018 at 09:08:40AM -0800, Dan Williams wrote:
> > Can we add a comment here like:
> >
> > /*
> > * Entry lock waits are exclusive. Wake up the next waiter since we
> > * aren't sure we will acquire the entry lock and thus wake the
> > * next waiter up on unlock.
> > */
> >
> > Because I always wonder for a moment why this is needed.
>
> Looks good, I'll add that when applying.
Thanks.
next prev parent reply other threads:[~2018-11-28 17:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 21:16 [PATCH 0/2] Two DAX fixes for 4.20 Matthew Wilcox
2018-11-27 21:16 ` [PATCH 1/2] dax: Check page->mapping isn't NULL Matthew Wilcox
2018-11-28 9:18 ` Johannes Thumshirn
2018-11-28 11:46 ` Jan Kara
2018-11-27 21:16 ` [PATCH 2/2] dax: Don't access a freed inode Matthew Wilcox
2018-11-28 11:53 ` Jan Kara
2018-11-28 17:08 ` Dan Williams
2018-11-28 17:10 ` Matthew Wilcox [this message]
2018-11-28 19:44 ` [PATCH v2] " Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128171004.GI10377@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).