* [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1
@ 2018-12-06 19:05 Aurelien Jarno
2019-01-12 19:07 ` Aurelien Jarno
0 siblings, 1 reply; 5+ messages in thread
From: Aurelien Jarno @ 2018-12-06 19:05 UTC (permalink / raw)
To: linux-kernel
Cc: linux-fsdevel, x86, Aurelien Jarno, Alexander Viro, H . J . Lu
The preadv2 and pwritev2 syscalls are supposed to emulate the readv and
writev syscalls when offset == -1. Therefore the compat code should
check for offset before calling do_compat_preadv64 and
do_compat_pwritev64. This is the case for the preadv2 and pwritev2
syscalls, but handling of offset == -1 is missing in their 64-bit
equivalent.
This patch fixes that, calling do_compat_readv and do_compat_writev when
offset == -1. This fixes the following glibc tests on x32:
- misc/tst-preadvwritev2
- misc/tst-preadvwritev64v2
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: H.J. Lu <hjl.tools@gmail.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
fs/read_write.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/fs/read_write.c b/fs/read_write.c
index 4dae0399c75a..c2dd3737fea2 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -1241,6 +1241,9 @@ COMPAT_SYSCALL_DEFINE5(preadv64v2, unsigned long, fd,
const struct compat_iovec __user *,vec,
unsigned long, vlen, loff_t, pos, rwf_t, flags)
{
+ if (pos == -1)
+ return do_compat_readv(fd, vec, vlen, flags);
+
return do_compat_preadv64(fd, vec, vlen, pos, flags);
}
#endif
@@ -1347,6 +1350,9 @@ COMPAT_SYSCALL_DEFINE5(pwritev64v2, unsigned long, fd,
const struct compat_iovec __user *,vec,
unsigned long, vlen, loff_t, pos, rwf_t, flags)
{
+ if (pos == -1)
+ return do_compat_writev(fd, vec, vlen, flags);
+
return do_compat_pwritev64(fd, vec, vlen, pos, flags);
}
#endif
--
2.19.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1
2018-12-06 19:05 [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1 Aurelien Jarno
@ 2019-01-12 19:07 ` Aurelien Jarno
2019-01-12 19:07 ` Aurelien Jarno
2019-02-16 15:15 ` Aurelien Jarno
0 siblings, 2 replies; 5+ messages in thread
From: Aurelien Jarno @ 2019-01-12 19:07 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-fsdevel, x86, Alexander Viro, H . J . Lu
On 2018-12-06 20:05, Aurelien Jarno wrote:
> The preadv2 and pwritev2 syscalls are supposed to emulate the readv and
> writev syscalls when offset == -1. Therefore the compat code should
> check for offset before calling do_compat_preadv64 and
> do_compat_pwritev64. This is the case for the preadv2 and pwritev2
> syscalls, but handling of offset == -1 is missing in their 64-bit
> equivalent.
>
> This patch fixes that, calling do_compat_readv and do_compat_writev when
> offset == -1. This fixes the following glibc tests on x32:
> - misc/tst-preadvwritev2
> - misc/tst-preadvwritev64v2
>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: H.J. Lu <hjl.tools@gmail.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> fs/read_write.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Any news about this patch?
Thanks,
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1
2019-01-12 19:07 ` Aurelien Jarno
@ 2019-01-12 19:07 ` Aurelien Jarno
2019-02-16 15:15 ` Aurelien Jarno
1 sibling, 0 replies; 5+ messages in thread
From: Aurelien Jarno @ 2019-01-12 19:07 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-fsdevel, x86, Alexander Viro, H . J . Lu
On 2018-12-06 20:05, Aurelien Jarno wrote:
> The preadv2 and pwritev2 syscalls are supposed to emulate the readv and
> writev syscalls when offset == -1. Therefore the compat code should
> check for offset before calling do_compat_preadv64 and
> do_compat_pwritev64. This is the case for the preadv2 and pwritev2
> syscalls, but handling of offset == -1 is missing in their 64-bit
> equivalent.
>
> This patch fixes that, calling do_compat_readv and do_compat_writev when
> offset == -1. This fixes the following glibc tests on x32:
> - misc/tst-preadvwritev2
> - misc/tst-preadvwritev64v2
>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: H.J. Lu <hjl.tools@gmail.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> fs/read_write.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Any news about this patch?
Thanks,
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1
2019-01-12 19:07 ` Aurelien Jarno
2019-01-12 19:07 ` Aurelien Jarno
@ 2019-02-16 15:15 ` Aurelien Jarno
2019-02-16 15:21 ` Al Viro
1 sibling, 1 reply; 5+ messages in thread
From: Aurelien Jarno @ 2019-02-16 15:15 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel, x86, Alexander Viro, H . J . Lu
On 2019-01-12 20:07, Aurelien Jarno wrote:
> On 2018-12-06 20:05, Aurelien Jarno wrote:
> > The preadv2 and pwritev2 syscalls are supposed to emulate the readv and
> > writev syscalls when offset == -1. Therefore the compat code should
> > check for offset before calling do_compat_preadv64 and
> > do_compat_pwritev64. This is the case for the preadv2 and pwritev2
> > syscalls, but handling of offset == -1 is missing in their 64-bit
> > equivalent.
> >
> > This patch fixes that, calling do_compat_readv and do_compat_writev when
> > offset == -1. This fixes the following glibc tests on x32:
> > - misc/tst-preadvwritev2
> > - misc/tst-preadvwritev64v2
> >
> > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > Cc: H.J. Lu <hjl.tools@gmail.com>
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> > fs/read_write.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
>
> Any news about this patch?
>
Ping.
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1
2019-02-16 15:15 ` Aurelien Jarno
@ 2019-02-16 15:21 ` Al Viro
0 siblings, 0 replies; 5+ messages in thread
From: Al Viro @ 2019-02-16 15:21 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel, x86, H . J . Lu
On Sat, Feb 16, 2019 at 04:15:28PM +0100, Aurelien Jarno wrote:
> On 2019-01-12 20:07, Aurelien Jarno wrote:
> > On 2018-12-06 20:05, Aurelien Jarno wrote:
> > > The preadv2 and pwritev2 syscalls are supposed to emulate the readv and
> > > writev syscalls when offset == -1. Therefore the compat code should
> > > check for offset before calling do_compat_preadv64 and
> > > do_compat_pwritev64. This is the case for the preadv2 and pwritev2
> > > syscalls, but handling of offset == -1 is missing in their 64-bit
> > > equivalent.
> > >
> > > This patch fixes that, calling do_compat_readv and do_compat_writev when
> > > offset == -1. This fixes the following glibc tests on x32:
> > > - misc/tst-preadvwritev2
> > > - misc/tst-preadvwritev64v2
> > >
> > > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > > Cc: H.J. Lu <hjl.tools@gmail.com>
> > > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > > ---
> > > fs/read_write.c | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> >
> > Any news about this patch?
> >
>
> Ping.
Applied
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-16 15:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-06 19:05 [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1 Aurelien Jarno
2019-01-12 19:07 ` Aurelien Jarno
2019-01-12 19:07 ` Aurelien Jarno
2019-02-16 15:15 ` Aurelien Jarno
2019-02-16 15:21 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).