From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Avi Kivity <avi@scylladb.com>,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org
Subject: Re: [PATCH] fs: Return EOPNOTSUPP if block layer does not support REQ_NOWAIT
Date: Tue, 18 Dec 2018 05:55:24 -0600 [thread overview]
Message-ID: <20181218115524.lt3dm53vgmbdbxjd@merlin> (raw)
In-Reply-To: <20181217173813.GB10437@infradead.org>
On 9:38 17/12, Christoph Hellwig wrote:
> On Sun, Dec 16, 2018 at 12:45:19PM +0200, Avi Kivity wrote:
> > I did see this on XFS too. The whole thing bothers me, it doesn't happen
> > consistently in some setups, which I don't understand. Either it should
> > trigger always or never.
>
> Well, if it also happens in XFS the above change isn't going to fix
> it alone, there must be another issue hiding in addition to the error
> conversion problems.
Are you using multi-device setup as your block device? That could make
it return EOPNOTSUPP since we never got to a point where we could
merge code which supported bio based devices.
--
Goldwyn
next prev parent reply other threads:[~2018-12-18 11:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 11:53 [PATCH] fs: Return EOPNOTSUPP if block layer does not support REQ_NOWAIT Goldwyn Rodrigues
2018-12-13 12:04 ` Avi Kivity
2018-12-13 14:24 ` Christoph Hellwig
2018-12-13 15:44 ` Goldwyn Rodrigues
2018-12-16 10:45 ` Avi Kivity
2018-12-17 17:38 ` Christoph Hellwig
2018-12-18 11:55 ` Goldwyn Rodrigues [this message]
2018-12-20 15:32 ` Avi Kivity
2018-12-13 16:27 ` Matthew Wilcox
2018-12-13 19:04 ` Goldwyn Rodrigues
2018-12-13 22:43 ` Dave Chinner
2018-12-14 17:09 ` Goldwyn Rodrigues
2018-12-16 21:35 ` Dave Chinner
2018-12-18 11:53 ` Goldwyn Rodrigues
2020-07-22 16:08 ` Avi Kivity
2020-07-28 13:38 ` Goldwyn Rodrigues
2020-07-28 13:47 ` Avi Kivity
2020-07-31 13:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218115524.lt3dm53vgmbdbxjd@merlin \
--to=rgoldwyn@suse.de \
--cc=avi@scylladb.com \
--cc=hch@infradead.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).