* [PATCH] mount: Make function to_mnt_ns static
@ 2018-12-07 20:43 Mathieu Malaterre
2019-01-16 11:10 ` Mathieu Malaterre
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Malaterre @ 2018-12-07 20:43 UTC (permalink / raw)
To: Alexander Viro; +Cc: Mathieu Malaterre, linux-fsdevel, linux-kernel
In commit 58be28256d98 ("make mntns ->get()/->put()/->install()/->inum()
work with &mnt_ns->ns"), a new function `to_mnt_ns` was introduced.
Since this function can be made static, make it so.
Fix warning when compiling with W=1:
fs/namespace.c:1693:23: warning: no previous prototype for ‘to_mnt_ns’ [-Wmissing-prototypes]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
fs/namespace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/namespace.c b/fs/namespace.c
index a7f91265ea67..f0cf252d9aa3 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1690,7 +1690,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
dentry->d_fsdata == &mntns_operations;
}
-struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
+static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
{
return container_of(ns, struct mnt_namespace, ns);
}
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mount: Make function to_mnt_ns static
2018-12-07 20:43 [PATCH] mount: Make function to_mnt_ns static Mathieu Malaterre
@ 2019-01-16 11:10 ` Mathieu Malaterre
2019-01-16 11:10 ` Mathieu Malaterre
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Malaterre @ 2019-01-16 11:10 UTC (permalink / raw)
To: Alexander Viro; +Cc: linux-fsdevel, LKML
ping ?
On Fri, Dec 7, 2018 at 9:43 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> In commit 58be28256d98 ("make mntns ->get()/->put()/->install()/->inum()
> work with &mnt_ns->ns"), a new function `to_mnt_ns` was introduced.
> Since this function can be made static, make it so.
>
> Fix warning when compiling with W=1:
>
> fs/namespace.c:1693:23: warning: no previous prototype for ‘to_mnt_ns’ [-Wmissing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> fs/namespace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index a7f91265ea67..f0cf252d9aa3 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -1690,7 +1690,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
> dentry->d_fsdata == &mntns_operations;
> }
>
> -struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
> +static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
> {
> return container_of(ns, struct mnt_namespace, ns);
> }
> --
> 2.19.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mount: Make function to_mnt_ns static
2019-01-16 11:10 ` Mathieu Malaterre
@ 2019-01-16 11:10 ` Mathieu Malaterre
0 siblings, 0 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2019-01-16 11:10 UTC (permalink / raw)
To: Alexander Viro; +Cc: linux-fsdevel, LKML
ping ?
On Fri, Dec 7, 2018 at 9:43 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> In commit 58be28256d98 ("make mntns ->get()/->put()/->install()/->inum()
> work with &mnt_ns->ns"), a new function `to_mnt_ns` was introduced.
> Since this function can be made static, make it so.
>
> Fix warning when compiling with W=1:
>
> fs/namespace.c:1693:23: warning: no previous prototype for ‘to_mnt_ns’ [-Wmissing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> fs/namespace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index a7f91265ea67..f0cf252d9aa3 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -1690,7 +1690,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
> dentry->d_fsdata == &mntns_operations;
> }
>
> -struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
> +static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
> {
> return container_of(ns, struct mnt_namespace, ns);
> }
> --
> 2.19.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-16 11:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-07 20:43 [PATCH] mount: Make function to_mnt_ns static Mathieu Malaterre
2019-01-16 11:10 ` Mathieu Malaterre
2019-01-16 11:10 ` Mathieu Malaterre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).