* [PATCH -next] proc/kcore: Make kcore_modules static
@ 2019-03-20 13:54 Yue Haibing
2019-03-20 19:55 ` Mukesh Ojha
0 siblings, 1 reply; 2+ messages in thread
From: Yue Haibing @ 2019-03-20 13:54 UTC (permalink / raw)
To: adobriyan, akpm, osandov, james.morse, sfr
Cc: linux-kernel, linux-fsdevel, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
fs/proc/kcore.c:591:19: warning:
symbol 'kcore_modules' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/proc/kcore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
index bbcc185..378f453 100644
--- a/fs/proc/kcore.c
+++ b/fs/proc/kcore.c
@@ -588,7 +588,7 @@ static void __init proc_kcore_text_init(void)
/*
* MODULES_VADDR has no intersection with VMALLOC_ADDR.
*/
-struct kcore_list kcore_modules;
+static struct kcore_list kcore_modules;
static void __init add_modules_range(void)
{
if (MODULES_VADDR != VMALLOC_START && MODULES_END != VMALLOC_END) {
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] proc/kcore: Make kcore_modules static
2019-03-20 13:54 [PATCH -next] proc/kcore: Make kcore_modules static Yue Haibing
@ 2019-03-20 19:55 ` Mukesh Ojha
0 siblings, 0 replies; 2+ messages in thread
From: Mukesh Ojha @ 2019-03-20 19:55 UTC (permalink / raw)
To: Yue Haibing, adobriyan, akpm, osandov, james.morse, sfr
Cc: linux-kernel, linux-fsdevel
On 3/20/2019 7:24 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> fs/proc/kcore.c:591:19: warning:
> symbol 'kcore_modules' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/proc/kcore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
> index bbcc185..378f453 100644
> --- a/fs/proc/kcore.c
> +++ b/fs/proc/kcore.c
> @@ -588,7 +588,7 @@ static void __init proc_kcore_text_init(void)
> /*
> * MODULES_VADDR has no intersection with VMALLOC_ADDR.
> */
> -struct kcore_list kcore_modules;
> +static struct kcore_list kcore_modules;
> static void __init add_modules_range(void)
> {
> if (MODULES_VADDR != VMALLOC_START && MODULES_END != VMALLOC_END) {
Acked-by: Mukesh Ojha <mojha@codeaurora.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-20 19:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 13:54 [PATCH -next] proc/kcore: Make kcore_modules static Yue Haibing
2019-03-20 19:55 ` Mukesh Ojha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).