[PATCH] fs/namespace.c: Make to_mnt_ns static

[PATCH] fs/namespace.c: Make to_mnt_ns static

[Bharath Vedartham]

This patch fixes the sparse warning:
"warning: symbol 'to_mnt_ns' was not declared. Should it be static?"

Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
---
 fs/namespace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index c9cab30..b39a3ec 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1732,7 +1732,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
 	       dentry->d_fsdata == &mntns_operations;
 }
 
-struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
+static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
 {
 	return container_of(ns, struct mnt_namespace, ns);
 }
-- 
2.7.4

[PATCH] fs/namespace.c: make to_mnt_ns() static

[Eric Biggers]

From: Eric Biggers <ebiggers@google.com>

Make to_mnt_ns() static to address the following 'sparse' warning:

    fs/namespace.c:1731:22: warning: symbol 'to_mnt_ns' was not declared. Should it be static?

Signed-off-by: Eric Biggers <ebiggers@google.com>
---

Hi Andrew, please consider applying this straightforward cleanup.
This has been sent to Al four times with no response, plus this
same patch has been sent many times by other people too.

 fs/namespace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index 2fd0c8bcb8c14..dd26cad6c5dd5 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1728,7 +1728,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
 	       dentry->d_fsdata == &mntns_operations;
 }
 
-struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
+static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
 {
 	return container_of(ns, struct mnt_namespace, ns);
 }
-- 
2.24.0.393.g34dc348eaf-goog

[PATCH] fs/namespace.c: make to_mnt_ns() static

[Eric Biggers]

From: Eric Biggers <ebiggers@google.com>

Make to_mnt_ns() static to address the following 'sparse' warning:

    fs/namespace.c:1736:22: warning: symbol 'to_mnt_ns' was not declared. Should it be static?

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/namespace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index ffb13f0562b07..0de85376c0c24 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1733,7 +1733,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
 	       dentry->d_fsdata == &mntns_operations;
 }
 
-struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
+static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
 {
 	return container_of(ns, struct mnt_namespace, ns);
 }
-- 
2.22.0.rc1.257.g3120a18244-goog

[PATCH] fs/namespace.c: make to_mnt_ns() static

[Eric Biggers]

From: Eric Biggers <ebiggers@google.com>

to_mnt_ns() is only used in fs/namespace.c, so make it static.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/namespace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index 74f64294a4108..55a3c94ba98b2 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1690,7 +1690,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
 	       dentry->d_fsdata == &mntns_operations;
 }
 
-struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
+static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
 {
 	return container_of(ns, struct mnt_namespace, ns);
 }
-- 
2.19.1.930.g4563a0d9d0-goog