* [PATCH] fs/nsfs.c: include headers for missing declarations
@ 2019-05-29 21:21 Eric Biggers
0 siblings, 0 replies; 2+ messages in thread
From: Eric Biggers @ 2019-05-29 21:21 UTC (permalink / raw)
To: linux-fsdevel, Alexander Viro
From: Eric Biggers <ebiggers@google.com>
Include linux/proc_fs.h and fs/internal.h to address the following
'sparse' warnings:
fs/nsfs.c:40:32: warning: symbol 'ns_dentry_operations' was not declared. Should it be static?
fs/nsfs.c:144:5: warning: symbol 'open_related_ns' was not declared. Should it be static?
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/nsfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/nsfs.c b/fs/nsfs.c
index e3bf08c5af411..d0e8391ae3d77 100644
--- a/fs/nsfs.c
+++ b/fs/nsfs.c
@@ -2,6 +2,7 @@
#include <linux/mount.h>
#include <linux/file.h>
#include <linux/fs.h>
+#include <linux/proc_fs.h>
#include <linux/proc_ns.h>
#include <linux/magic.h>
#include <linux/ktime.h>
@@ -10,6 +11,8 @@
#include <linux/nsfs.h>
#include <linux/uaccess.h>
+#include "internal.h"
+
static struct vfsmount *nsfs_mnt;
static long ns_ioctl(struct file *filp, unsigned int ioctl,
--
2.22.0.rc1.257.g3120a18244-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] fs/nsfs.c: include headers for missing declarations
@ 2019-12-09 23:48 Eric Biggers
0 siblings, 0 replies; 2+ messages in thread
From: Eric Biggers @ 2019-12-09 23:48 UTC (permalink / raw)
To: Andrew Morton; +Cc: Alexander Viro, linux-fsdevel
From: Eric Biggers <ebiggers@google.com>
Include linux/proc_fs.h and fs/internal.h to address the following
'sparse' warnings:
fs/nsfs.c:41:32: warning: symbol 'ns_dentry_operations' was not declared. Should it be static?
fs/nsfs.c:145:5: warning: symbol 'open_related_ns' was not declared. Should it be static?
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
Hi Andrew, please consider applying this straightforward cleanup.
This has been sent to Al four times with no response.
fs/nsfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/nsfs.c b/fs/nsfs.c
index a0431642c6b55..f75767bd623af 100644
--- a/fs/nsfs.c
+++ b/fs/nsfs.c
@@ -3,6 +3,7 @@
#include <linux/pseudo_fs.h>
#include <linux/file.h>
#include <linux/fs.h>
+#include <linux/proc_fs.h>
#include <linux/proc_ns.h>
#include <linux/magic.h>
#include <linux/ktime.h>
@@ -11,6 +12,8 @@
#include <linux/nsfs.h>
#include <linux/uaccess.h>
+#include "internal.h"
+
static struct vfsmount *nsfs_mnt;
static long ns_ioctl(struct file *filp, unsigned int ioctl,
--
2.24.0.393.g34dc348eaf-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-09 23:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-29 21:21 [PATCH] fs/nsfs.c: include headers for missing declarations Eric Biggers
2019-12-09 23:48 Eric Biggers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).