* [PATCH] nfs: disable client side deduplication
@ 2019-05-31 21:06 Darrick J. Wong
0 siblings, 0 replies; only message in thread
From: Darrick J. Wong @ 2019-05-31 21:06 UTC (permalink / raw)
To: anna.schumaker, trond.myklebust
Cc: fstests, Murphy Zhou, linux-nfs, linux-fsdevel, fengxiaoli0714
From: Darrick J. Wong <darrick.wong@oracle.com>
The NFS protocol doesn't support deduplication, so turn it off again.
Fixes: ce96e888fe48e ("Fix nfs4.2 return -EINVAL when do dedupe operation")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/nfs/nfs4file.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/nfs/nfs4file.c b/fs/nfs/nfs4file.c
index cf42a8b939e3..1915f24bba85 100644
--- a/fs/nfs/nfs4file.c
+++ b/fs/nfs/nfs4file.c
@@ -187,7 +187,11 @@ static loff_t nfs42_remap_file_range(struct file *src_file, loff_t src_off,
bool same_inode = false;
int ret;
- if (remap_flags & ~(REMAP_FILE_DEDUP | REMAP_FILE_ADVISORY))
+ /* NFS does not support deduplication. */
+ if (remap_flags & REMAP_FILE_DEDUP)
+ return -EOPNOTSUPP;
+
+ if (remap_flags & ~REMAP_FILE_ADVISORY)
return -EINVAL;
/* check alignment w.r.t. clone_blksize */
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-05-31 21:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-31 21:06 [PATCH] nfs: disable client side deduplication Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).