From: Miklos Szeredi <mszeredi@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Ian Kent <raven@themaw.net>,
linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 07/13] proc: don't ignore options
Date: Wed, 19 Jun 2019 14:30:13 +0200 [thread overview]
Message-ID: <20190619123019.30032-7-mszeredi@redhat.com> (raw)
In-Reply-To: <20190619123019.30032-1-mszeredi@redhat.com>
The options "sync", "async", "dirsync", "lazytime", "nolazytime", "mand"
and "nomand" make no sense for the proc filesystem. If these options are
supplied to fsconfig(FSCONFIG_SET_FLAG), then return -EINVAL instead of
silently ignoring the option.
Any implementation, such as mount(8) that needs to parse this option
without failing should simply ignore the return value from fsconfig().
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---
fs/proc/root.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/root.c b/fs/proc/root.c
index 6ef1527ad975..70127eaba04d 100644
--- a/fs/proc/root.c
+++ b/fs/proc/root.c
@@ -58,7 +58,7 @@ static int proc_parse_param(struct fs_context *fc, struct fs_parameter *param)
struct fs_parse_result result;
int ret, opt;
- ret = vfs_parse_sb_flag(fc, param);
+ ret = vfs_parse_ro_rw(fc, param);
if (ret != -ENOPARAM)
return ret;
--
2.21.0
next prev parent reply other threads:[~2019-06-19 12:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 12:30 [PATCH 01/13] vfs: verify param type in vfs_parse_sb_flag() Miklos Szeredi
2019-06-19 12:30 ` [PATCH 02/13] vfs: move vfs_parse_sb_flag() calls into filesystems Miklos Szeredi
2019-06-19 12:30 ` [PATCH 03/13] vfs: don't parse forbidden flags Miklos Szeredi
2019-06-19 12:30 ` [PATCH 04/13] vfs: don't parse "posixacl" option Miklos Szeredi
2019-06-19 12:30 ` [PATCH 05/13] vfs: don't parse "silent" option Miklos Szeredi
2019-06-20 4:40 ` Ian Kent
2019-06-24 8:25 ` Miklos Szeredi
2019-06-24 10:36 ` David Howells
2019-06-24 10:44 ` Miklos Szeredi
2019-06-24 10:53 ` Miklos Szeredi
2019-06-19 12:30 ` [PATCH 06/13] vfs: new helper: vfs_parse_ro_rw() Miklos Szeredi
2019-06-19 12:30 ` Miklos Szeredi [this message]
2019-06-19 12:30 ` [PATCH 08/13] sysfs: don't ignore options Miklos Szeredi
2019-06-19 12:30 ` [PATCH 09/13] mqueue: " Miklos Szeredi
2019-06-19 12:30 ` [PATCH 10/13] cpuset: " Miklos Szeredi
2019-06-19 12:30 ` [PATCH 11/13] cgroup: " Miklos Szeredi
2019-06-19 12:30 ` [PATCH 12/13] fusectl: " Miklos Szeredi
2019-06-19 12:30 ` [PATCH 13/13] resctrl: " Miklos Szeredi
2019-07-01 8:45 ` [PATCH 01/13] vfs: verify param type in vfs_parse_sb_flag() Miklos Szeredi
2019-07-04 16:19 ` David Howells
2019-09-06 7:28 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619123019.30032-7-mszeredi@redhat.com \
--to=mszeredi@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).