Re: [PATCH 06/16] zuf: Multy Devices

From: kbuild test robot <lkp@intel.com>
To: Boaz Harrosh <boaz@plexistor.com>
Cc: kbuild-all@01.org, Boaz Harrosh <boaz@plexistor.com>,
	Boaz Harrosh <ooo@electrozaur.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Boaz Harrosh <boazh@netapp.com>
Subject: Re: [PATCH 06/16] zuf: Multy Devices
Date: Tue, 13 Aug 2019 16:11:53 +0800	[thread overview]
Message-ID: <201908131625.nH4peW0F%lkp@intel.com> (raw)
In-Reply-To: <20190812164244.15580-7-boazh@netapp.com>

[-- Attachment #1: Type: text/plain, Size: 3363 bytes --]

Hi Boaz,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Boaz-Harrosh/zuf-ZUFS-Zero-copy-User-mode-FileSystem/20190813-074124
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:15:0,
                    from include/asm-generic/bug.h:18,
                    from arch/x86/include/asm/bug.h:83,
                    from include/linux/bug.h:5,
                    from include/linux/mmdebug.h:5,
                    from include/linux/mm.h:9,
                    from fs/zuf/t1.c:15:
   fs/zuf/t1.c: In function 't1_fault':
   include/linux/printk.h:304:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
     printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> fs/zuf/_pr.h:23:31: note: in expansion of macro 'pr_err'
    #define zuf_err(s, args ...)  pr_err("[%s:%d] " s, __func__, \
                                  ^~~~~~
>> fs/zuf/t1.c:75:3: note: in expansion of macro 'zuf_err'
      zuf_err("[%ld] PTE fault not expected pgoff=0x%lx addr=0x%lx\n",
      ^~~~~~~
   fs/zuf/t1.c:78:2: note: here
     case PE_SIZE_PMD:
     ^~~~

vim +/pr_err +23 fs/zuf/_pr.h

f577115420e717 Boaz Harrosh 2019-08-12  19  
f577115420e717 Boaz Harrosh 2019-08-12  20  /*
f577115420e717 Boaz Harrosh 2019-08-12  21   * Debug code
f577115420e717 Boaz Harrosh 2019-08-12  22   */
f577115420e717 Boaz Harrosh 2019-08-12 @23  #define zuf_err(s, args ...)		pr_err("[%s:%d] " s, __func__, \
f577115420e717 Boaz Harrosh 2019-08-12  24  							__LINE__, ## args)
f577115420e717 Boaz Harrosh 2019-08-12  25  #define zuf_err_cnd(silent, s, args ...) \
f577115420e717 Boaz Harrosh 2019-08-12  26  	do {if (!silent) \
f577115420e717 Boaz Harrosh 2019-08-12  27  		pr_err("[%s:%d] " s, __func__, __LINE__, ## args); \
f577115420e717 Boaz Harrosh 2019-08-12  28  	} while (0)
f577115420e717 Boaz Harrosh 2019-08-12  29  #define zuf_warn(s, args ...)		pr_warn("[%s:%d] " s, __func__, \
f577115420e717 Boaz Harrosh 2019-08-12  30  							__LINE__, ## args)
f577115420e717 Boaz Harrosh 2019-08-12  31  #define zuf_warn_cnd(silent, s, args ...) \
f577115420e717 Boaz Harrosh 2019-08-12  32  	do {if (!silent) \
f577115420e717 Boaz Harrosh 2019-08-12  33  		pr_warn("[%s:%d] " s, __func__, __LINE__, ## args); \
f577115420e717 Boaz Harrosh 2019-08-12  34  	} while (0)
f577115420e717 Boaz Harrosh 2019-08-12  35  #define zuf_info(s, args ...)          pr_info("~info~ " s, ## args)
f577115420e717 Boaz Harrosh 2019-08-12  36  

:::::: The code at line 23 was first introduced by commit
:::::: f577115420e717e536986a2e6055c584ec2f6829 zuf: zuf-rootfs

:::::: TO: Boaz Harrosh <boaz@plexistor.com>
:::::: CC: 0day robot <lkp@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69489 bytes --]