Re: [PATCH 07/16] zuf: mounting

From: kbuild test robot <lkp@intel.com>
To: Boaz Harrosh <boaz@plexistor.com>
Cc: kbuild-all@01.org, Boaz Harrosh <boaz@plexistor.com>,
	Boaz Harrosh <ooo@electrozaur.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Boaz Harrosh <boazh@netapp.com>
Subject: Re: [PATCH 07/16] zuf: mounting
Date: Tue, 13 Aug 2019 16:58:05 +0800	[thread overview]
Message-ID: <201908131636.YCcvbjVD%lkp@intel.com> (raw)
In-Reply-To: <20190812164244.15580-8-boazh@netapp.com>

[-- Attachment #1: Type: text/plain, Size: 2816 bytes --]

Hi Boaz,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Boaz-Harrosh/zuf-ZUFS-Zero-copy-User-mode-FileSystem/20190813-074124
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   fs/zuf/zuf-core.c: In function '_r_zufs_dispatch':
   fs/zuf/zuf-core.c:860:46: error: 'struct task_struct' has no member named 'cpus_allowed'; did you mean 'nr_cpus_allowed'?
     cpumask_copy(&zt->relay.cpus_allowed, &app->cpus_allowed);
                                                 ^~~~~~~~~~~~
                                                 nr_cpus_allowed
   fs/zuf/zuf-core.c:861:21: error: 'struct task_struct' has no member named 'cpus_allowed'; did you mean 'nr_cpus_allowed'?
     cpumask_copy(&app->cpus_allowed,  cpumask_of(smp_processor_id()));
                        ^~~~~~~~~~~~
                        nr_cpus_allowed
   fs/zuf/zuf-core.c:884:22: error: 'struct task_struct' has no member named 'cpus_allowed'; did you mean 'nr_cpus_allowed'?
      cpumask_copy(&app->cpus_allowed, &zt->relay.cpus_allowed);
                         ^~~~~~~~~~~~
                         nr_cpus_allowed
   fs/zuf/zuf-core.c: In function 'zufc_release':
>> fs/zuf/zuf-core.c:1078:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
      _zu_private_mounter_release(file);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   fs/zuf/zuf-core.c:1079:2: note: here
     case zlfs_e_pmem:
     ^~~~

vim +1078 fs/zuf/zuf-core.c

  1062	
  1063	int zufc_release(struct inode *inode, struct file *file)
  1064	{
  1065		struct zuf_special_file *zsf = file->private_data;
  1066	
  1067		if (!zsf)
  1068			return 0;
  1069	
  1070		switch (zsf->type) {
  1071		case zlfs_e_zt:
  1072			zufc_zt_release(file);
  1073			return 0;
  1074		case zlfs_e_mout_thread:
  1075			zufc_mounter_release(file);
  1076			return 0;
  1077		case zlfs_e_private_mount:
> 1078			_zu_private_mounter_release(file);
  1079		case zlfs_e_pmem:
  1080			/* NOTHING to clean for pmem file yet */
  1081			/* zuf_pmem_release(file);*/
  1082			return 0;
  1083		case zlfs_e_dpp_buff:
  1084			zufc_ebuff_release(file);
  1085			return 0;
  1086		default:
  1087			return 0;
  1088		}
  1089	}
  1090	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69489 bytes --]