* [PATCH] proc:fix confusing macro arg name
@ 2019-09-10 2:17 Miaohe Lin
0 siblings, 0 replies; 6+ messages in thread
From: Miaohe Lin @ 2019-09-10 2:17 UTC (permalink / raw)
To: adobriyan, tglx, akpm, dhowells, cyphar, christian, aubrey.li,
linux-kernel, linux-fsdevel
Cc: linmiaohe, mingfangsen
state_size and ops are in the wrong position, fix it.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
include/linux/proc_fs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h
index a705aa2d03f9..0640be56dcbd 100644
--- a/include/linux/proc_fs.h
+++ b/include/linux/proc_fs.h
@@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *);
struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
struct proc_dir_entry *parent, const struct seq_operations *ops,
unsigned int state_size, void *data);
-#define proc_create_net(name, mode, parent, state_size, ops) \
- proc_create_net_data(name, mode, parent, state_size, ops, NULL)
+#define proc_create_net(name, mode, parent, ops, state_size) \
+ proc_create_net_data(name, mode, parent, ops, state_size, NULL)
struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
struct proc_dir_entry *parent,
int (*show)(struct seq_file *, void *), void *data);
--
2.21.GIT
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] proc:fix confusing macro arg name
@ 2019-10-08 6:44 linmiaohe
2019-10-08 7:04 ` Li, Aubrey
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: linmiaohe @ 2019-10-08 6:44 UTC (permalink / raw)
To: adobriyan, tglx, akpm, dhowells, cyphar, christian, aubrey.li
Cc: Mingfangsen, linmiaohe, mm-commits, linux-kernel, linux-fsdevel
Add suitable additional cc's as Andrew Morton suggested.
Get cc list from get_maintainer script:
[root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch
Alexey Dobriyan <adobriyan@gmail.com> (reviewer:PROC FILESYSTEM)
linux-kernel@vger.kernel.org (open list:PROC FILESYSTEM)
linux-fsdevel@vger.kernel.org (open list:PROC FILESYSTEM)
------------------------------------------------------
From: Miaohe Lin <linmiaohe@huawei.com>
Subject: fix confusing macro arg name
state_size and ops are in the wrong position, fix it.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/proc_fs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index a705aa2d03f9..0640be56dcbd 100644
--- a/include/linux/proc_fs.h
+++ b/include/linux/proc_fs.h
@@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *); struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
struct proc_dir_entry *parent, const struct seq_operations *ops,
unsigned int state_size, void *data);
-#define proc_create_net(name, mode, parent, state_size, ops) \
- proc_create_net_data(name, mode, parent, state_size, ops, NULL)
+#define proc_create_net(name, mode, parent, ops, state_size) \
+ proc_create_net_data(name, mode, parent, ops, state_size, NULL)
struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
struct proc_dir_entry *parent,
int (*show)(struct seq_file *, void *), void *data);
--
2.21.GIT
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] proc:fix confusing macro arg name
2019-10-08 6:44 linmiaohe
@ 2019-10-08 7:04 ` Li, Aubrey
2019-10-08 7:27 ` Aleksa Sarai
2019-10-08 11:22 ` Christian Brauner
2 siblings, 0 replies; 6+ messages in thread
From: Li, Aubrey @ 2019-10-08 7:04 UTC (permalink / raw)
To: linmiaohe, adobriyan, tglx, akpm, dhowells, cyphar, christian
Cc: Mingfangsen, mm-commits, linux-kernel, linux-fsdevel
On 2019/10/8 14:44, linmiaohe wrote:
> Add suitable additional cc's as Andrew Morton suggested.
> Get cc list from get_maintainer script:
> [root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch
> Alexey Dobriyan <adobriyan@gmail.com> (reviewer:PROC FILESYSTEM)
> linux-kernel@vger.kernel.org (open list:PROC FILESYSTEM)
> linux-fsdevel@vger.kernel.org (open list:PROC FILESYSTEM)
>
> ------------------------------------------------------
> From: Miaohe Lin <linmiaohe@huawei.com>
> Subject: fix confusing macro arg name
>
> state_size and ops are in the wrong position, fix it.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
> Cc: Alexey Dobriyan <adobriyan@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
Good catch!
This is interesting, I saw this interface has 50+ callers,
How did they work before? ;)
Thanks,
-Aubrey
>
> include/linux/proc_fs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index a705aa2d03f9..0640be56dcbd 100644
> --- a/include/linux/proc_fs.h
> +++ b/include/linux/proc_fs.h
> @@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *); struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
> struct proc_dir_entry *parent, const struct seq_operations *ops,
> unsigned int state_size, void *data);
> -#define proc_create_net(name, mode, parent, state_size, ops) \
> - proc_create_net_data(name, mode, parent, state_size, ops, NULL)
> +#define proc_create_net(name, mode, parent, ops, state_size) \
> + proc_create_net_data(name, mode, parent, ops, state_size, NULL)
> struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
> struct proc_dir_entry *parent,
> int (*show)(struct seq_file *, void *), void *data);
> --
> 2.21.GIT
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] proc:fix confusing macro arg name
2019-10-08 6:44 linmiaohe
2019-10-08 7:04 ` Li, Aubrey
@ 2019-10-08 7:27 ` Aleksa Sarai
2019-10-08 11:22 ` Christian Brauner
2 siblings, 0 replies; 6+ messages in thread
From: Aleksa Sarai @ 2019-10-08 7:27 UTC (permalink / raw)
To: linmiaohe
Cc: adobriyan, tglx, akpm, dhowells, christian, aubrey.li,
Mingfangsen, mm-commits, linux-kernel, linux-fsdevel
[-- Attachment #1: Type: text/plain, Size: 2079 bytes --]
On 2019-10-08, linmiaohe <linmiaohe@huawei.com> wrote:
> Add suitable additional cc's as Andrew Morton suggested.
> Get cc list from get_maintainer script:
> [root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch
> Alexey Dobriyan <adobriyan@gmail.com> (reviewer:PROC FILESYSTEM)
> linux-kernel@vger.kernel.org (open list:PROC FILESYSTEM)
> linux-fsdevel@vger.kernel.org (open list:PROC FILESYSTEM)
>
> ------------------------------------------------------
> From: Miaohe Lin <linmiaohe@huawei.com>
> Subject: fix confusing macro arg name
>
> state_size and ops are in the wrong position, fix it.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
> Cc: Alexey Dobriyan <adobriyan@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Looks reasonable.
Acked-by: Aleksa Sarai <cyphar@cyphar.com>
> ---
>
> include/linux/proc_fs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index a705aa2d03f9..0640be56dcbd 100644
> --- a/include/linux/proc_fs.h
> +++ b/include/linux/proc_fs.h
> @@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *); struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
> struct proc_dir_entry *parent, const struct seq_operations *ops,
> unsigned int state_size, void *data);
> -#define proc_create_net(name, mode, parent, state_size, ops) \
> - proc_create_net_data(name, mode, parent, state_size, ops, NULL)
> +#define proc_create_net(name, mode, parent, ops, state_size) \
> + proc_create_net_data(name, mode, parent, ops, state_size, NULL)
> struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
> struct proc_dir_entry *parent,
> int (*show)(struct seq_file *, void *), void *data);
> --
> 2.21.GIT
>
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] proc:fix confusing macro arg name
2019-10-08 6:44 linmiaohe
2019-10-08 7:04 ` Li, Aubrey
2019-10-08 7:27 ` Aleksa Sarai
@ 2019-10-08 11:22 ` Christian Brauner
2 siblings, 0 replies; 6+ messages in thread
From: Christian Brauner @ 2019-10-08 11:22 UTC (permalink / raw)
To: linmiaohe
Cc: adobriyan, tglx, akpm, dhowells, cyphar, christian, aubrey.li,
Mingfangsen, mm-commits, linux-kernel, linux-fsdevel
On Tue, Oct 08, 2019 at 06:44:18AM +0000, linmiaohe wrote:
> Add suitable additional cc's as Andrew Morton suggested.
> Get cc list from get_maintainer script:
> [root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch
> Alexey Dobriyan <adobriyan@gmail.com> (reviewer:PROC FILESYSTEM)
> linux-kernel@vger.kernel.org (open list:PROC FILESYSTEM)
> linux-fsdevel@vger.kernel.org (open list:PROC FILESYSTEM)
>
> ------------------------------------------------------
> From: Miaohe Lin <linmiaohe@huawei.com>
> Subject: fix confusing macro arg name
>
> state_size and ops are in the wrong position, fix it.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
> Cc: Alexey Dobriyan <adobriyan@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
I thought I already reviewed this weeks ago...
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] proc:fix confusing macro arg name
@ 2019-10-08 8:28 linmiaohe
0 siblings, 0 replies; 6+ messages in thread
From: linmiaohe @ 2019-10-08 8:28 UTC (permalink / raw)
To: Li, Aubrey
Cc: adobriyan, tglx, akpm, dhowells, cyphar, christian, Mingfangsen,
mm-commits, linux-kernel, linux-fsdevel
On 2019/10/8 15:05, Aubrey wrote:
>> On 2019/10/8 14:44, linmiaohe wrote:
>> state_size and ops are in the wrong position, fix it.
>>
>
> Good catch!
>
> This is interesting, I saw this interface has 50+ callers, How did they work before? ;)
>
This confused me too. The args of function proc_create_net_single is consistent with
the callers, so it works. But the wrong args name in macro proc_create_net makes
it confusing.
Thanks, have a nice day!
> Thanks,
> -Aubrey
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-08 11:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-10 2:17 [PATCH] proc:fix confusing macro arg name Miaohe Lin
2019-10-08 6:44 linmiaohe
2019-10-08 7:04 ` Li, Aubrey
2019-10-08 7:27 ` Aleksa Sarai
2019-10-08 11:22 ` Christian Brauner
2019-10-08 8:28 linmiaohe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).