* [PATCH -next] virtiofs: remove unused variable 'fc'
@ 2019-10-23 6:21 YueHaibing
2019-10-23 14:31 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-10-23 6:21 UTC (permalink / raw)
To: vgoyal, stefanha, miklos, mszeredi
Cc: virtualization, linux-fsdevel, linux-kernel, YueHaibing
fs/fuse/virtio_fs.c:983:20: warning:
variable fc set but not used [-Wunused-but-set-variable]
It is not used since commit 7ee1e2e631db ("virtiofs:
No need to check fpq->connected state")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/fuse/virtio_fs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index 2de8fc0..a5c8604 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -980,7 +980,6 @@ __releases(fiq->lock)
{
unsigned int queue_id = VQ_REQUEST; /* TODO multiqueue */
struct virtio_fs *fs;
- struct fuse_conn *fc;
struct fuse_req *req;
struct virtio_fs_vq *fsvq;
int ret;
@@ -993,7 +992,6 @@ __releases(fiq->lock)
spin_unlock(&fiq->lock);
fs = fiq->priv;
- fc = fs->vqs[queue_id].fud->fc;
pr_debug("%s: opcode %u unique %#llx nodeid %#llx in.len %u out.len %u\n",
__func__, req->in.h.opcode, req->in.h.unique,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] virtiofs: remove unused variable 'fc'
2019-10-23 6:21 [PATCH -next] virtiofs: remove unused variable 'fc' YueHaibing
@ 2019-10-23 14:31 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2019-10-23 14:31 UTC (permalink / raw)
To: YueHaibing
Cc: vgoyal, miklos, mszeredi, virtualization, linux-fsdevel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
On Wed, Oct 23, 2019 at 02:21:30PM +0800, YueHaibing wrote:
> fs/fuse/virtio_fs.c:983:20: warning:
> variable fc set but not used [-Wunused-but-set-variable]
>
> It is not used since commit 7ee1e2e631db ("virtiofs:
> No need to check fpq->connected state")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/fuse/virtio_fs.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-23 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 6:21 [PATCH -next] virtiofs: remove unused variable 'fc' YueHaibing
2019-10-23 14:31 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).