* [PATCH 00/19] Renaming some identifiers
@ 2020-01-29 16:58 Pragat Pandya
2020-01-29 16:58 ` [PATCH 01/19] staging: exfat: Rename variable 'Year' to 'year' Pragat Pandya
` (18 more replies)
0 siblings, 19 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
This patchset renames following nineteen variables in exfat.h
Fix checkpatch warning: Avoid CamelCase
-Year->year
-Day->day
-Hour->hour
-Minute->minute
-Second->second
-Millisecond->millisecond
-FatType->fat_type
-ClusterSize->cluster_size
-NumClusters->num_clusters
-FreeClusters->free_clusters
-UsedClusters->used_clusters
-Name->name
-ShortName->short_name
-Attr->attr
-NumSubdirs->num_subdirs
-CreateTimestamp->create_timestamp
-ModifyTimestamp->modify_timestamp
-AccessTimestamp->access_timestamp
v2:
-Correct misplaced quatation character in subject line(s).
-Remove unnecessary '_'(underscore) character in renaming of identifier
MilliSecond.
-Drop commits renaming unused struct members.
Pragat Pandya (19):
staging: exfat: Rename variable 'Year' to 'year'
staging: exfat: Rename variable 'Month' to 'month'
staging: exfat: Rename variable 'Day' to 'day'
staging: exfat: Rename variable 'Hour' to 'hour'
staging: exfat: Rename variable 'Minute' to 'minute'
staging: exfat: Rename variable 'Second' to 'second'
staging: exfat: Rename variable 'MilliSecond' to 'millisecond'
staging: exfat: Rename variable 'FatType' to 'fat_type'
staging: exfat: Rename variable 'ClusterSize' to 'cluster_size'
staging: exfat: Rename variable 'NumClusters' to 'num_cluster'
staging: exfat: Rename variable 'FreeClusters' to 'free_clusters'
staging: exfat: Rename variable 'UsedClusters' to 'used_clusters'
staging: exfat: Rename variable 'Name' to 'name'
staging: exfat: Rename variable 'ShortName' to 'short_name'
staging: exfat: Rename variable 'Attr' to 'attr'
staging: exfat: Rename variable 'NumSubdirs' to 'num_subdirs'
staging: exfat: Rename variable 'CreateTimestamp' to
'create_timestamp'
staging: exfat: Rename variable 'ModifyTimestamp' to
'modify_timestamp'
staging: exfat: Rename variable 'AccessTimestamp' to
'access_timestamp'
drivers/staging/exfat/exfat.h | 38 ++---
drivers/staging/exfat/exfat_super.c | 232 ++++++++++++++--------------
2 files changed, 135 insertions(+), 135 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 01/19] staging: exfat: Rename variable 'Year' to 'year'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 02/19] staging: exfat: Rename variable 'Month' to 'month' Pragat Pandya
` (17 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "Year" to "year"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 20 ++++++++++----------
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 51c665a924b7..c3c562fba133 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -222,7 +222,7 @@ static inline u16 get_row_index(u16 i)
#endif
struct date_time_t {
- u16 Year;
+ u16 year;
u16 Month;
u16 Day;
u16 Hour;
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 9f91853b189b..7534b86192aa 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -59,7 +59,7 @@ static void exfat_write_super(struct super_block *sb);
/* Convert a FAT time/date pair to a UNIX date (seconds since 1 1 70). */
static void exfat_time_fat2unix(struct timespec64 *ts, struct date_time_t *tp)
{
- ts->tv_sec = mktime64(tp->Year + 1980, tp->Month + 1, tp->Day,
+ ts->tv_sec = mktime64(tp->year + 1980, tp->Month + 1, tp->Day,
tp->Hour, tp->Minute, tp->Second);
ts->tv_nsec = tp->MilliSecond * NSEC_PER_MSEC;
@@ -80,7 +80,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
tp->Hour = 0;
tp->Day = 1;
tp->Month = 1;
- tp->Year = 0;
+ tp->year = 0;
return;
}
@@ -91,7 +91,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
tp->Hour = 23;
tp->Day = 31;
tp->Month = 12;
- tp->Year = 127;
+ tp->year = 127;
return;
}
@@ -101,7 +101,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
tp->Hour = tm.tm_hour;
tp->Day = tm.tm_mday;
tp->Month = tm.tm_mon + 1;
- tp->Year = tm.tm_year + 1900 - 1980;
+ tp->year = tm.tm_year + 1900 - 1980;
}
struct timestamp_t *tm_current(struct timestamp_t *tp)
@@ -1505,7 +1505,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->Attr = p_fs->fs_func->get_entry_attr(ep);
p_fs->fs_func->get_entry_time(ep, &tm, TM_CREATE);
- info->CreateTimestamp.Year = tm.year;
+ info->CreateTimestamp.year = tm.year;
info->CreateTimestamp.Month = tm.mon;
info->CreateTimestamp.Day = tm.day;
info->CreateTimestamp.Hour = tm.hour;
@@ -1514,7 +1514,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->CreateTimestamp.MilliSecond = 0;
p_fs->fs_func->get_entry_time(ep, &tm, TM_MODIFY);
- info->ModifyTimestamp.Year = tm.year;
+ info->ModifyTimestamp.year = tm.year;
info->ModifyTimestamp.Month = tm.mon;
info->ModifyTimestamp.Day = tm.day;
info->ModifyTimestamp.Hour = tm.hour;
@@ -1610,7 +1610,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
tm.hour = info->CreateTimestamp.Hour;
tm.day = info->CreateTimestamp.Day;
tm.mon = info->CreateTimestamp.Month;
- tm.year = info->CreateTimestamp.Year;
+ tm.year = info->CreateTimestamp.year;
p_fs->fs_func->set_entry_time(ep, &tm, TM_CREATE);
tm.sec = info->ModifyTimestamp.Second;
@@ -1618,7 +1618,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
tm.hour = info->ModifyTimestamp.Hour;
tm.day = info->ModifyTimestamp.Day;
tm.mon = info->ModifyTimestamp.Month;
- tm.year = info->ModifyTimestamp.Year;
+ tm.year = info->ModifyTimestamp.year;
p_fs->fs_func->set_entry_time(ep, &tm, TM_MODIFY);
p_fs->fs_func->set_entry_size(ep2, info->Size);
@@ -1925,7 +1925,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
dir_entry->Attr = fs_func->get_entry_attr(ep);
fs_func->get_entry_time(ep, &tm, TM_CREATE);
- dir_entry->CreateTimestamp.Year = tm.year;
+ dir_entry->CreateTimestamp.year = tm.year;
dir_entry->CreateTimestamp.Month = tm.mon;
dir_entry->CreateTimestamp.Day = tm.day;
dir_entry->CreateTimestamp.Hour = tm.hour;
@@ -1934,7 +1934,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
dir_entry->CreateTimestamp.MilliSecond = 0;
fs_func->get_entry_time(ep, &tm, TM_MODIFY);
- dir_entry->ModifyTimestamp.Year = tm.year;
+ dir_entry->ModifyTimestamp.year = tm.year;
dir_entry->ModifyTimestamp.Month = tm.mon;
dir_entry->ModifyTimestamp.Day = tm.day;
dir_entry->ModifyTimestamp.Hour = tm.hour;
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 02/19] staging: exfat: Rename variable 'Month' to 'month'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
2020-01-29 16:58 ` [PATCH 01/19] staging: exfat: Rename variable 'Year' to 'year' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 03/19] staging: exfat: Rename variable 'Day' to 'day' Pragat Pandya
` (16 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "Month" to "month"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 20 ++++++++++----------
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index c3c562fba133..95e27aed350d 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -223,7 +223,7 @@ static inline u16 get_row_index(u16 i)
struct date_time_t {
u16 year;
- u16 Month;
+ u16 month;
u16 Day;
u16 Hour;
u16 Minute;
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 7534b86192aa..293d103a6b54 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -59,7 +59,7 @@ static void exfat_write_super(struct super_block *sb);
/* Convert a FAT time/date pair to a UNIX date (seconds since 1 1 70). */
static void exfat_time_fat2unix(struct timespec64 *ts, struct date_time_t *tp)
{
- ts->tv_sec = mktime64(tp->year + 1980, tp->Month + 1, tp->Day,
+ ts->tv_sec = mktime64(tp->year + 1980, tp->month + 1, tp->Day,
tp->Hour, tp->Minute, tp->Second);
ts->tv_nsec = tp->MilliSecond * NSEC_PER_MSEC;
@@ -79,7 +79,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
tp->Minute = 0;
tp->Hour = 0;
tp->Day = 1;
- tp->Month = 1;
+ tp->month = 1;
tp->year = 0;
return;
}
@@ -90,7 +90,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
tp->Minute = 59;
tp->Hour = 23;
tp->Day = 31;
- tp->Month = 12;
+ tp->month = 12;
tp->year = 127;
return;
}
@@ -100,7 +100,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
tp->Minute = tm.tm_min;
tp->Hour = tm.tm_hour;
tp->Day = tm.tm_mday;
- tp->Month = tm.tm_mon + 1;
+ tp->month = tm.tm_mon + 1;
tp->year = tm.tm_year + 1900 - 1980;
}
@@ -1506,7 +1506,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
p_fs->fs_func->get_entry_time(ep, &tm, TM_CREATE);
info->CreateTimestamp.year = tm.year;
- info->CreateTimestamp.Month = tm.mon;
+ info->CreateTimestamp.month = tm.mon;
info->CreateTimestamp.Day = tm.day;
info->CreateTimestamp.Hour = tm.hour;
info->CreateTimestamp.Minute = tm.min;
@@ -1515,7 +1515,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
p_fs->fs_func->get_entry_time(ep, &tm, TM_MODIFY);
info->ModifyTimestamp.year = tm.year;
- info->ModifyTimestamp.Month = tm.mon;
+ info->ModifyTimestamp.month = tm.mon;
info->ModifyTimestamp.Day = tm.day;
info->ModifyTimestamp.Hour = tm.hour;
info->ModifyTimestamp.Minute = tm.min;
@@ -1609,7 +1609,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
tm.min = info->CreateTimestamp.Minute;
tm.hour = info->CreateTimestamp.Hour;
tm.day = info->CreateTimestamp.Day;
- tm.mon = info->CreateTimestamp.Month;
+ tm.mon = info->CreateTimestamp.month;
tm.year = info->CreateTimestamp.year;
p_fs->fs_func->set_entry_time(ep, &tm, TM_CREATE);
@@ -1617,7 +1617,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
tm.min = info->ModifyTimestamp.Minute;
tm.hour = info->ModifyTimestamp.Hour;
tm.day = info->ModifyTimestamp.Day;
- tm.mon = info->ModifyTimestamp.Month;
+ tm.mon = info->ModifyTimestamp.month;
tm.year = info->ModifyTimestamp.year;
p_fs->fs_func->set_entry_time(ep, &tm, TM_MODIFY);
@@ -1926,7 +1926,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
fs_func->get_entry_time(ep, &tm, TM_CREATE);
dir_entry->CreateTimestamp.year = tm.year;
- dir_entry->CreateTimestamp.Month = tm.mon;
+ dir_entry->CreateTimestamp.month = tm.mon;
dir_entry->CreateTimestamp.Day = tm.day;
dir_entry->CreateTimestamp.Hour = tm.hour;
dir_entry->CreateTimestamp.Minute = tm.min;
@@ -1935,7 +1935,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
fs_func->get_entry_time(ep, &tm, TM_MODIFY);
dir_entry->ModifyTimestamp.year = tm.year;
- dir_entry->ModifyTimestamp.Month = tm.mon;
+ dir_entry->ModifyTimestamp.month = tm.mon;
dir_entry->ModifyTimestamp.Day = tm.day;
dir_entry->ModifyTimestamp.Hour = tm.hour;
dir_entry->ModifyTimestamp.Minute = tm.min;
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 03/19] staging: exfat: Rename variable 'Day' to 'day'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
2020-01-29 16:58 ` [PATCH 01/19] staging: exfat: Rename variable 'Year' to 'year' Pragat Pandya
2020-01-29 16:58 ` [PATCH 02/19] staging: exfat: Rename variable 'Month' to 'month' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 04/19] staging: exfat: Rename variable 'Hour' to 'hour' Pragat Pandya
` (15 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurences of identifier "Day" to "day"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 20 ++++++++++----------
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 95e27aed350d..4211148405c5 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -224,7 +224,7 @@ static inline u16 get_row_index(u16 i)
struct date_time_t {
u16 year;
u16 month;
- u16 Day;
+ u16 day;
u16 Hour;
u16 Minute;
u16 Second;
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 293d103a6b54..b30f9517cfef 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -59,7 +59,7 @@ static void exfat_write_super(struct super_block *sb);
/* Convert a FAT time/date pair to a UNIX date (seconds since 1 1 70). */
static void exfat_time_fat2unix(struct timespec64 *ts, struct date_time_t *tp)
{
- ts->tv_sec = mktime64(tp->year + 1980, tp->month + 1, tp->Day,
+ ts->tv_sec = mktime64(tp->year + 1980, tp->month + 1, tp->day,
tp->Hour, tp->Minute, tp->Second);
ts->tv_nsec = tp->MilliSecond * NSEC_PER_MSEC;
@@ -78,7 +78,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
tp->Second = 0;
tp->Minute = 0;
tp->Hour = 0;
- tp->Day = 1;
+ tp->day = 1;
tp->month = 1;
tp->year = 0;
return;
@@ -89,7 +89,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
tp->Second = 59;
tp->Minute = 59;
tp->Hour = 23;
- tp->Day = 31;
+ tp->day = 31;
tp->month = 12;
tp->year = 127;
return;
@@ -99,7 +99,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
tp->Second = tm.tm_sec;
tp->Minute = tm.tm_min;
tp->Hour = tm.tm_hour;
- tp->Day = tm.tm_mday;
+ tp->day = tm.tm_mday;
tp->month = tm.tm_mon + 1;
tp->year = tm.tm_year + 1900 - 1980;
}
@@ -1507,7 +1507,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
p_fs->fs_func->get_entry_time(ep, &tm, TM_CREATE);
info->CreateTimestamp.year = tm.year;
info->CreateTimestamp.month = tm.mon;
- info->CreateTimestamp.Day = tm.day;
+ info->CreateTimestamp.day = tm.day;
info->CreateTimestamp.Hour = tm.hour;
info->CreateTimestamp.Minute = tm.min;
info->CreateTimestamp.Second = tm.sec;
@@ -1516,7 +1516,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
p_fs->fs_func->get_entry_time(ep, &tm, TM_MODIFY);
info->ModifyTimestamp.year = tm.year;
info->ModifyTimestamp.month = tm.mon;
- info->ModifyTimestamp.Day = tm.day;
+ info->ModifyTimestamp.day = tm.day;
info->ModifyTimestamp.Hour = tm.hour;
info->ModifyTimestamp.Minute = tm.min;
info->ModifyTimestamp.Second = tm.sec;
@@ -1608,7 +1608,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
tm.sec = info->CreateTimestamp.Second;
tm.min = info->CreateTimestamp.Minute;
tm.hour = info->CreateTimestamp.Hour;
- tm.day = info->CreateTimestamp.Day;
+ tm.day = info->CreateTimestamp.day;
tm.mon = info->CreateTimestamp.month;
tm.year = info->CreateTimestamp.year;
p_fs->fs_func->set_entry_time(ep, &tm, TM_CREATE);
@@ -1616,7 +1616,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
tm.sec = info->ModifyTimestamp.Second;
tm.min = info->ModifyTimestamp.Minute;
tm.hour = info->ModifyTimestamp.Hour;
- tm.day = info->ModifyTimestamp.Day;
+ tm.day = info->ModifyTimestamp.day;
tm.mon = info->ModifyTimestamp.month;
tm.year = info->ModifyTimestamp.year;
p_fs->fs_func->set_entry_time(ep, &tm, TM_MODIFY);
@@ -1927,7 +1927,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
fs_func->get_entry_time(ep, &tm, TM_CREATE);
dir_entry->CreateTimestamp.year = tm.year;
dir_entry->CreateTimestamp.month = tm.mon;
- dir_entry->CreateTimestamp.Day = tm.day;
+ dir_entry->CreateTimestamp.day = tm.day;
dir_entry->CreateTimestamp.Hour = tm.hour;
dir_entry->CreateTimestamp.Minute = tm.min;
dir_entry->CreateTimestamp.Second = tm.sec;
@@ -1936,7 +1936,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
fs_func->get_entry_time(ep, &tm, TM_MODIFY);
dir_entry->ModifyTimestamp.year = tm.year;
dir_entry->ModifyTimestamp.month = tm.mon;
- dir_entry->ModifyTimestamp.Day = tm.day;
+ dir_entry->ModifyTimestamp.day = tm.day;
dir_entry->ModifyTimestamp.Hour = tm.hour;
dir_entry->ModifyTimestamp.Minute = tm.min;
dir_entry->ModifyTimestamp.Second = tm.sec;
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 04/19] staging: exfat: Rename variable 'Hour' to 'hour'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (2 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 03/19] staging: exfat: Rename variable 'Day' to 'day' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 05/19] staging: exfat: Rename variable 'Minute' to 'minute' Pragat Pandya
` (14 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "Hour" to "hour"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 20 ++++++++++----------
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 4211148405c5..03eaf25692aa 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -225,7 +225,7 @@ struct date_time_t {
u16 year;
u16 month;
u16 day;
- u16 Hour;
+ u16 hour;
u16 Minute;
u16 Second;
u16 MilliSecond;
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index b30f9517cfef..ae9180be4cc0 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -60,7 +60,7 @@ static void exfat_write_super(struct super_block *sb);
static void exfat_time_fat2unix(struct timespec64 *ts, struct date_time_t *tp)
{
ts->tv_sec = mktime64(tp->year + 1980, tp->month + 1, tp->day,
- tp->Hour, tp->Minute, tp->Second);
+ tp->hour, tp->Minute, tp->Second);
ts->tv_nsec = tp->MilliSecond * NSEC_PER_MSEC;
}
@@ -77,7 +77,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
tp->MilliSecond = 0;
tp->Second = 0;
tp->Minute = 0;
- tp->Hour = 0;
+ tp->hour = 0;
tp->day = 1;
tp->month = 1;
tp->year = 0;
@@ -88,7 +88,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
tp->MilliSecond = 999;
tp->Second = 59;
tp->Minute = 59;
- tp->Hour = 23;
+ tp->hour = 23;
tp->day = 31;
tp->month = 12;
tp->year = 127;
@@ -98,7 +98,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
tp->MilliSecond = ts->tv_nsec / NSEC_PER_MSEC;
tp->Second = tm.tm_sec;
tp->Minute = tm.tm_min;
- tp->Hour = tm.tm_hour;
+ tp->hour = tm.tm_hour;
tp->day = tm.tm_mday;
tp->month = tm.tm_mon + 1;
tp->year = tm.tm_year + 1900 - 1980;
@@ -1508,7 +1508,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->CreateTimestamp.year = tm.year;
info->CreateTimestamp.month = tm.mon;
info->CreateTimestamp.day = tm.day;
- info->CreateTimestamp.Hour = tm.hour;
+ info->CreateTimestamp.hour = tm.hour;
info->CreateTimestamp.Minute = tm.min;
info->CreateTimestamp.Second = tm.sec;
info->CreateTimestamp.MilliSecond = 0;
@@ -1517,7 +1517,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->ModifyTimestamp.year = tm.year;
info->ModifyTimestamp.month = tm.mon;
info->ModifyTimestamp.day = tm.day;
- info->ModifyTimestamp.Hour = tm.hour;
+ info->ModifyTimestamp.hour = tm.hour;
info->ModifyTimestamp.Minute = tm.min;
info->ModifyTimestamp.Second = tm.sec;
info->ModifyTimestamp.MilliSecond = 0;
@@ -1607,7 +1607,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
/* set FILE_INFO structure using the acquired struct dentry_t */
tm.sec = info->CreateTimestamp.Second;
tm.min = info->CreateTimestamp.Minute;
- tm.hour = info->CreateTimestamp.Hour;
+ tm.hour = info->CreateTimestamp.hour;
tm.day = info->CreateTimestamp.day;
tm.mon = info->CreateTimestamp.month;
tm.year = info->CreateTimestamp.year;
@@ -1615,7 +1615,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
tm.sec = info->ModifyTimestamp.Second;
tm.min = info->ModifyTimestamp.Minute;
- tm.hour = info->ModifyTimestamp.Hour;
+ tm.hour = info->ModifyTimestamp.hour;
tm.day = info->ModifyTimestamp.day;
tm.mon = info->ModifyTimestamp.month;
tm.year = info->ModifyTimestamp.year;
@@ -1928,7 +1928,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
dir_entry->CreateTimestamp.year = tm.year;
dir_entry->CreateTimestamp.month = tm.mon;
dir_entry->CreateTimestamp.day = tm.day;
- dir_entry->CreateTimestamp.Hour = tm.hour;
+ dir_entry->CreateTimestamp.hour = tm.hour;
dir_entry->CreateTimestamp.Minute = tm.min;
dir_entry->CreateTimestamp.Second = tm.sec;
dir_entry->CreateTimestamp.MilliSecond = 0;
@@ -1937,7 +1937,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
dir_entry->ModifyTimestamp.year = tm.year;
dir_entry->ModifyTimestamp.month = tm.mon;
dir_entry->ModifyTimestamp.day = tm.day;
- dir_entry->ModifyTimestamp.Hour = tm.hour;
+ dir_entry->ModifyTimestamp.hour = tm.hour;
dir_entry->ModifyTimestamp.Minute = tm.min;
dir_entry->ModifyTimestamp.Second = tm.sec;
dir_entry->ModifyTimestamp.MilliSecond = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 05/19] staging: exfat: Rename variable 'Minute' to 'minute'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (3 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 04/19] staging: exfat: Rename variable 'Hour' to 'hour' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 06/19] staging: exfat: Rename variable 'Second' to 'second' Pragat Pandya
` (13 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "Minute" to "minute"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 20 ++++++++++----------
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 03eaf25692aa..755e2fd6e3fd 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -226,7 +226,7 @@ struct date_time_t {
u16 month;
u16 day;
u16 hour;
- u16 Minute;
+ u16 minute;
u16 Second;
u16 MilliSecond;
};
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index ae9180be4cc0..70fa5f118a38 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -60,7 +60,7 @@ static void exfat_write_super(struct super_block *sb);
static void exfat_time_fat2unix(struct timespec64 *ts, struct date_time_t *tp)
{
ts->tv_sec = mktime64(tp->year + 1980, tp->month + 1, tp->day,
- tp->hour, tp->Minute, tp->Second);
+ tp->hour, tp->minute, tp->Second);
ts->tv_nsec = tp->MilliSecond * NSEC_PER_MSEC;
}
@@ -76,7 +76,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
if (second < UNIX_SECS_1980) {
tp->MilliSecond = 0;
tp->Second = 0;
- tp->Minute = 0;
+ tp->minute = 0;
tp->hour = 0;
tp->day = 1;
tp->month = 1;
@@ -87,7 +87,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
if (second >= UNIX_SECS_2108) {
tp->MilliSecond = 999;
tp->Second = 59;
- tp->Minute = 59;
+ tp->minute = 59;
tp->hour = 23;
tp->day = 31;
tp->month = 12;
@@ -97,7 +97,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
tp->MilliSecond = ts->tv_nsec / NSEC_PER_MSEC;
tp->Second = tm.tm_sec;
- tp->Minute = tm.tm_min;
+ tp->minute = tm.tm_min;
tp->hour = tm.tm_hour;
tp->day = tm.tm_mday;
tp->month = tm.tm_mon + 1;
@@ -1509,7 +1509,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->CreateTimestamp.month = tm.mon;
info->CreateTimestamp.day = tm.day;
info->CreateTimestamp.hour = tm.hour;
- info->CreateTimestamp.Minute = tm.min;
+ info->CreateTimestamp.minute = tm.min;
info->CreateTimestamp.Second = tm.sec;
info->CreateTimestamp.MilliSecond = 0;
@@ -1518,7 +1518,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->ModifyTimestamp.month = tm.mon;
info->ModifyTimestamp.day = tm.day;
info->ModifyTimestamp.hour = tm.hour;
- info->ModifyTimestamp.Minute = tm.min;
+ info->ModifyTimestamp.minute = tm.min;
info->ModifyTimestamp.Second = tm.sec;
info->ModifyTimestamp.MilliSecond = 0;
@@ -1606,7 +1606,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
/* set FILE_INFO structure using the acquired struct dentry_t */
tm.sec = info->CreateTimestamp.Second;
- tm.min = info->CreateTimestamp.Minute;
+ tm.min = info->CreateTimestamp.minute;
tm.hour = info->CreateTimestamp.hour;
tm.day = info->CreateTimestamp.day;
tm.mon = info->CreateTimestamp.month;
@@ -1614,7 +1614,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
p_fs->fs_func->set_entry_time(ep, &tm, TM_CREATE);
tm.sec = info->ModifyTimestamp.Second;
- tm.min = info->ModifyTimestamp.Minute;
+ tm.min = info->ModifyTimestamp.minute;
tm.hour = info->ModifyTimestamp.hour;
tm.day = info->ModifyTimestamp.day;
tm.mon = info->ModifyTimestamp.month;
@@ -1929,7 +1929,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
dir_entry->CreateTimestamp.month = tm.mon;
dir_entry->CreateTimestamp.day = tm.day;
dir_entry->CreateTimestamp.hour = tm.hour;
- dir_entry->CreateTimestamp.Minute = tm.min;
+ dir_entry->CreateTimestamp.minute = tm.min;
dir_entry->CreateTimestamp.Second = tm.sec;
dir_entry->CreateTimestamp.MilliSecond = 0;
@@ -1938,7 +1938,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
dir_entry->ModifyTimestamp.month = tm.mon;
dir_entry->ModifyTimestamp.day = tm.day;
dir_entry->ModifyTimestamp.hour = tm.hour;
- dir_entry->ModifyTimestamp.Minute = tm.min;
+ dir_entry->ModifyTimestamp.minute = tm.min;
dir_entry->ModifyTimestamp.Second = tm.sec;
dir_entry->ModifyTimestamp.MilliSecond = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 06/19] staging: exfat: Rename variable 'Second' to 'second'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (4 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 05/19] staging: exfat: Rename variable 'Minute' to 'minute' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 07/19] staging: exfat: Rename variable 'MilliSecond' to 'millisecond' Pragat Pandya
` (12 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "Second" to "second"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 20 ++++++++++----------
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 755e2fd6e3fd..85fbea44219a 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -227,7 +227,7 @@ struct date_time_t {
u16 day;
u16 hour;
u16 minute;
- u16 Second;
+ u16 second;
u16 MilliSecond;
};
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 70fa5f118a38..0582c49f091d 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -60,7 +60,7 @@ static void exfat_write_super(struct super_block *sb);
static void exfat_time_fat2unix(struct timespec64 *ts, struct date_time_t *tp)
{
ts->tv_sec = mktime64(tp->year + 1980, tp->month + 1, tp->day,
- tp->hour, tp->minute, tp->Second);
+ tp->hour, tp->minute, tp->second);
ts->tv_nsec = tp->MilliSecond * NSEC_PER_MSEC;
}
@@ -75,7 +75,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
if (second < UNIX_SECS_1980) {
tp->MilliSecond = 0;
- tp->Second = 0;
+ tp->second = 0;
tp->minute = 0;
tp->hour = 0;
tp->day = 1;
@@ -86,7 +86,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
if (second >= UNIX_SECS_2108) {
tp->MilliSecond = 999;
- tp->Second = 59;
+ tp->second = 59;
tp->minute = 59;
tp->hour = 23;
tp->day = 31;
@@ -96,7 +96,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
}
tp->MilliSecond = ts->tv_nsec / NSEC_PER_MSEC;
- tp->Second = tm.tm_sec;
+ tp->second = tm.tm_sec;
tp->minute = tm.tm_min;
tp->hour = tm.tm_hour;
tp->day = tm.tm_mday;
@@ -1510,7 +1510,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->CreateTimestamp.day = tm.day;
info->CreateTimestamp.hour = tm.hour;
info->CreateTimestamp.minute = tm.min;
- info->CreateTimestamp.Second = tm.sec;
+ info->CreateTimestamp.second = tm.sec;
info->CreateTimestamp.MilliSecond = 0;
p_fs->fs_func->get_entry_time(ep, &tm, TM_MODIFY);
@@ -1519,7 +1519,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->ModifyTimestamp.day = tm.day;
info->ModifyTimestamp.hour = tm.hour;
info->ModifyTimestamp.minute = tm.min;
- info->ModifyTimestamp.Second = tm.sec;
+ info->ModifyTimestamp.second = tm.sec;
info->ModifyTimestamp.MilliSecond = 0;
memset((char *)&info->AccessTimestamp, 0, sizeof(struct date_time_t));
@@ -1605,7 +1605,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
p_fs->fs_func->set_entry_attr(ep, info->Attr);
/* set FILE_INFO structure using the acquired struct dentry_t */
- tm.sec = info->CreateTimestamp.Second;
+ tm.sec = info->CreateTimestamp.second;
tm.min = info->CreateTimestamp.minute;
tm.hour = info->CreateTimestamp.hour;
tm.day = info->CreateTimestamp.day;
@@ -1613,7 +1613,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
tm.year = info->CreateTimestamp.year;
p_fs->fs_func->set_entry_time(ep, &tm, TM_CREATE);
- tm.sec = info->ModifyTimestamp.Second;
+ tm.sec = info->ModifyTimestamp.second;
tm.min = info->ModifyTimestamp.minute;
tm.hour = info->ModifyTimestamp.hour;
tm.day = info->ModifyTimestamp.day;
@@ -1930,7 +1930,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
dir_entry->CreateTimestamp.day = tm.day;
dir_entry->CreateTimestamp.hour = tm.hour;
dir_entry->CreateTimestamp.minute = tm.min;
- dir_entry->CreateTimestamp.Second = tm.sec;
+ dir_entry->CreateTimestamp.second = tm.sec;
dir_entry->CreateTimestamp.MilliSecond = 0;
fs_func->get_entry_time(ep, &tm, TM_MODIFY);
@@ -1939,7 +1939,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
dir_entry->ModifyTimestamp.day = tm.day;
dir_entry->ModifyTimestamp.hour = tm.hour;
dir_entry->ModifyTimestamp.minute = tm.min;
- dir_entry->ModifyTimestamp.Second = tm.sec;
+ dir_entry->ModifyTimestamp.second = tm.sec;
dir_entry->ModifyTimestamp.MilliSecond = 0;
memset((char *)&dir_entry->AccessTimestamp, 0,
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 07/19] staging: exfat: Rename variable 'MilliSecond' to 'millisecond'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (5 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 06/19] staging: exfat: Rename variable 'Second' to 'second' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 08/19] staging: exfat: Rename variable 'FatType' to 'fat_type' Pragat Pandya
` (11 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "MilliSecond" to "millisecond"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
Changes in v1:
-Rename "MilliSecond" as "milli_second"
Changes in v2:
-Remove unnecessary '_'(underscore) character form renamed
identifier name.
-Rename "MilliSecond" as "millisecond"
---
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 16 ++++++++--------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 85fbea44219a..55405dcbf8f7 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -228,7 +228,7 @@ struct date_time_t {
u16 hour;
u16 minute;
u16 second;
- u16 MilliSecond;
+ u16 millisecond;
};
struct part_info_t {
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 0582c49f091d..e51abb9b3826 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -62,7 +62,7 @@ static void exfat_time_fat2unix(struct timespec64 *ts, struct date_time_t *tp)
ts->tv_sec = mktime64(tp->year + 1980, tp->month + 1, tp->day,
tp->hour, tp->minute, tp->second);
- ts->tv_nsec = tp->MilliSecond * NSEC_PER_MSEC;
+ ts->tv_nsec = tp->millisecond * NSEC_PER_MSEC;
}
/* Convert linear UNIX date to a FAT time/date pair. */
@@ -74,7 +74,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
time64_to_tm(second, 0, &tm);
if (second < UNIX_SECS_1980) {
- tp->MilliSecond = 0;
+ tp->millisecond = 0;
tp->second = 0;
tp->minute = 0;
tp->hour = 0;
@@ -85,7 +85,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
}
if (second >= UNIX_SECS_2108) {
- tp->MilliSecond = 999;
+ tp->millisecond = 999;
tp->second = 59;
tp->minute = 59;
tp->hour = 23;
@@ -95,7 +95,7 @@ static void exfat_time_unix2fat(struct timespec64 *ts, struct date_time_t *tp)
return;
}
- tp->MilliSecond = ts->tv_nsec / NSEC_PER_MSEC;
+ tp->millisecond = ts->tv_nsec / NSEC_PER_MSEC;
tp->second = tm.tm_sec;
tp->minute = tm.tm_min;
tp->hour = tm.tm_hour;
@@ -1511,7 +1511,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->CreateTimestamp.hour = tm.hour;
info->CreateTimestamp.minute = tm.min;
info->CreateTimestamp.second = tm.sec;
- info->CreateTimestamp.MilliSecond = 0;
+ info->CreateTimestamp.millisecond = 0;
p_fs->fs_func->get_entry_time(ep, &tm, TM_MODIFY);
info->ModifyTimestamp.year = tm.year;
@@ -1520,7 +1520,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->ModifyTimestamp.hour = tm.hour;
info->ModifyTimestamp.minute = tm.min;
info->ModifyTimestamp.second = tm.sec;
- info->ModifyTimestamp.MilliSecond = 0;
+ info->ModifyTimestamp.millisecond = 0;
memset((char *)&info->AccessTimestamp, 0, sizeof(struct date_time_t));
@@ -1931,7 +1931,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
dir_entry->CreateTimestamp.hour = tm.hour;
dir_entry->CreateTimestamp.minute = tm.min;
dir_entry->CreateTimestamp.second = tm.sec;
- dir_entry->CreateTimestamp.MilliSecond = 0;
+ dir_entry->CreateTimestamp.millisecond = 0;
fs_func->get_entry_time(ep, &tm, TM_MODIFY);
dir_entry->ModifyTimestamp.year = tm.year;
@@ -1940,7 +1940,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
dir_entry->ModifyTimestamp.hour = tm.hour;
dir_entry->ModifyTimestamp.minute = tm.min;
dir_entry->ModifyTimestamp.second = tm.sec;
- dir_entry->ModifyTimestamp.MilliSecond = 0;
+ dir_entry->ModifyTimestamp.millisecond = 0;
memset((char *)&dir_entry->AccessTimestamp, 0,
sizeof(struct date_time_t));
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 08/19] staging: exfat: Rename variable 'FatType' to 'fat_type'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (6 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 07/19] staging: exfat: Rename variable 'MilliSecond' to 'millisecond' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 09/19] staging: exfat: Rename variable 'ClusterSize' to 'cluster_size' Pragat Pandya
` (10 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "FatType" to "fat_type"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 55405dcbf8f7..8e01f011ef27 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -242,7 +242,7 @@ struct dev_info_t {
};
struct vol_info_t {
- u32 FatType;
+ u32 fat_type;
u32 ClusterSize;
u32 NumClusters;
u32 FreeClusters;
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index e51abb9b3826..6278fc3eac19 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -494,7 +494,7 @@ static int ffsGetVolInfo(struct super_block *sb, struct vol_info_t *info)
if (p_fs->used_clusters == UINT_MAX)
p_fs->used_clusters = p_fs->fs_func->count_used_clusters(sb);
- info->FatType = p_fs->vol_type;
+ info->fat_type = p_fs->vol_type;
info->ClusterSize = p_fs->cluster_size;
info->NumClusters = p_fs->num_clusters - 2; /* clu 0 & 1 */
info->UsedClusters = p_fs->used_clusters;
@@ -3348,7 +3348,7 @@ static int exfat_statfs(struct dentry *dentry, struct kstatfs *buf)
return -EIO;
} else {
- info.FatType = p_fs->vol_type;
+ info.fat_type = p_fs->vol_type;
info.ClusterSize = p_fs->cluster_size;
info.NumClusters = p_fs->num_clusters - 2;
info.UsedClusters = p_fs->used_clusters;
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 09/19] staging: exfat: Rename variable 'ClusterSize' to 'cluster_size'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (7 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 08/19] staging: exfat: Rename variable 'FatType' to 'fat_type' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 10/19] staging: exfat: Rename variable 'NumClusters' to 'num_cluster' Pragat Pandya
` (9 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "ClusterSize" to "cluster_size"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 8e01f011ef27..c9d9791312f0 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -243,7 +243,7 @@ struct dev_info_t {
struct vol_info_t {
u32 fat_type;
- u32 ClusterSize;
+ u32 cluster_size;
u32 NumClusters;
u32 FreeClusters;
u32 UsedClusters;
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 6278fc3eac19..ac6f38508d2b 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -495,7 +495,7 @@ static int ffsGetVolInfo(struct super_block *sb, struct vol_info_t *info)
p_fs->used_clusters = p_fs->fs_func->count_used_clusters(sb);
info->fat_type = p_fs->vol_type;
- info->ClusterSize = p_fs->cluster_size;
+ info->cluster_size = p_fs->cluster_size;
info->NumClusters = p_fs->num_clusters - 2; /* clu 0 & 1 */
info->UsedClusters = p_fs->used_clusters;
info->FreeClusters = info->NumClusters - info->UsedClusters;
@@ -3349,7 +3349,7 @@ static int exfat_statfs(struct dentry *dentry, struct kstatfs *buf)
} else {
info.fat_type = p_fs->vol_type;
- info.ClusterSize = p_fs->cluster_size;
+ info.cluster_size = p_fs->cluster_size;
info.NumClusters = p_fs->num_clusters - 2;
info.UsedClusters = p_fs->used_clusters;
info.FreeClusters = info.NumClusters - info.UsedClusters;
@@ -3359,7 +3359,7 @@ static int exfat_statfs(struct dentry *dentry, struct kstatfs *buf)
}
buf->f_type = sb->s_magic;
- buf->f_bsize = info.ClusterSize;
+ buf->f_bsize = info.cluster_size;
buf->f_blocks = info.NumClusters;
buf->f_bfree = info.FreeClusters;
buf->f_bavail = info.FreeClusters;
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 10/19] staging: exfat: Rename variable 'NumClusters' to 'num_cluster'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (8 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 09/19] staging: exfat: Rename variable 'ClusterSize' to 'cluster_size' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 11/19] staging: exfat: Rename variable 'FreeClusters' to 'free_clusters' Pragat Pandya
` (8 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "NumClusters" to "num_clusters"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index c9d9791312f0..3fd234a323fb 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -244,7 +244,7 @@ struct dev_info_t {
struct vol_info_t {
u32 fat_type;
u32 cluster_size;
- u32 NumClusters;
+ u32 num_clusters;
u32 FreeClusters;
u32 UsedClusters;
};
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index ac6f38508d2b..d8de39917bc0 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -496,9 +496,9 @@ static int ffsGetVolInfo(struct super_block *sb, struct vol_info_t *info)
info->fat_type = p_fs->vol_type;
info->cluster_size = p_fs->cluster_size;
- info->NumClusters = p_fs->num_clusters - 2; /* clu 0 & 1 */
+ info->num_clusters = p_fs->num_clusters - 2; /* clu 0 & 1 */
info->UsedClusters = p_fs->used_clusters;
- info->FreeClusters = info->NumClusters - info->UsedClusters;
+ info->FreeClusters = info->num_clusters - info->UsedClusters;
if (p_fs->dev_ejected)
err = -EIO;
@@ -3350,9 +3350,9 @@ static int exfat_statfs(struct dentry *dentry, struct kstatfs *buf)
} else {
info.fat_type = p_fs->vol_type;
info.cluster_size = p_fs->cluster_size;
- info.NumClusters = p_fs->num_clusters - 2;
+ info.num_clusters = p_fs->num_clusters - 2;
info.UsedClusters = p_fs->used_clusters;
- info.FreeClusters = info.NumClusters - info.UsedClusters;
+ info.FreeClusters = info.num_clusters - info.UsedClusters;
if (p_fs->dev_ejected)
pr_info("[EXFAT] statfs on device that is ejected\n");
@@ -3360,7 +3360,7 @@ static int exfat_statfs(struct dentry *dentry, struct kstatfs *buf)
buf->f_type = sb->s_magic;
buf->f_bsize = info.cluster_size;
- buf->f_blocks = info.NumClusters;
+ buf->f_blocks = info.num_clusters;
buf->f_bfree = info.FreeClusters;
buf->f_bavail = info.FreeClusters;
buf->f_fsid.val[0] = (u32)id;
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 11/19] staging: exfat: Rename variable 'FreeClusters' to 'free_clusters'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (9 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 10/19] staging: exfat: Rename variable 'NumClusters' to 'num_cluster' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 12/19] staging: exfat: Rename variable 'UsedClusters' to 'used_clusters' Pragat Pandya
` (7 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "FreeClusters" to "free_clusters"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 3fd234a323fb..2c42519d5eba 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -245,7 +245,7 @@ struct vol_info_t {
u32 fat_type;
u32 cluster_size;
u32 num_clusters;
- u32 FreeClusters;
+ u32 free_clusters;
u32 UsedClusters;
};
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index d8de39917bc0..335bf39aa171 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -498,7 +498,7 @@ static int ffsGetVolInfo(struct super_block *sb, struct vol_info_t *info)
info->cluster_size = p_fs->cluster_size;
info->num_clusters = p_fs->num_clusters - 2; /* clu 0 & 1 */
info->UsedClusters = p_fs->used_clusters;
- info->FreeClusters = info->num_clusters - info->UsedClusters;
+ info->free_clusters = info->num_clusters - info->UsedClusters;
if (p_fs->dev_ejected)
err = -EIO;
@@ -3352,7 +3352,7 @@ static int exfat_statfs(struct dentry *dentry, struct kstatfs *buf)
info.cluster_size = p_fs->cluster_size;
info.num_clusters = p_fs->num_clusters - 2;
info.UsedClusters = p_fs->used_clusters;
- info.FreeClusters = info.num_clusters - info.UsedClusters;
+ info.free_clusters = info.num_clusters - info.UsedClusters;
if (p_fs->dev_ejected)
pr_info("[EXFAT] statfs on device that is ejected\n");
@@ -3361,8 +3361,8 @@ static int exfat_statfs(struct dentry *dentry, struct kstatfs *buf)
buf->f_type = sb->s_magic;
buf->f_bsize = info.cluster_size;
buf->f_blocks = info.num_clusters;
- buf->f_bfree = info.FreeClusters;
- buf->f_bavail = info.FreeClusters;
+ buf->f_bfree = info.free_clusters;
+ buf->f_bavail = info.free_clusters;
buf->f_fsid.val[0] = (u32)id;
buf->f_fsid.val[1] = (u32)(id >> 32);
buf->f_namelen = 260;
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 12/19] staging: exfat: Rename variable 'UsedClusters' to 'used_clusters'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (10 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 11/19] staging: exfat: Rename variable 'FreeClusters' to 'free_clusters' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 13/19] staging: exfat: Rename variable 'Name' to 'name' Pragat Pandya
` (6 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrecnes of identifier "UsedClusters" to "used_clusters"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 2c42519d5eba..2242cf1fdb4a 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -246,7 +246,7 @@ struct vol_info_t {
u32 cluster_size;
u32 num_clusters;
u32 free_clusters;
- u32 UsedClusters;
+ u32 used_clusters;
};
/* directory structure */
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 335bf39aa171..4b8ffb8ab557 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -497,8 +497,8 @@ static int ffsGetVolInfo(struct super_block *sb, struct vol_info_t *info)
info->fat_type = p_fs->vol_type;
info->cluster_size = p_fs->cluster_size;
info->num_clusters = p_fs->num_clusters - 2; /* clu 0 & 1 */
- info->UsedClusters = p_fs->used_clusters;
- info->free_clusters = info->num_clusters - info->UsedClusters;
+ info->used_clusters = p_fs->used_clusters;
+ info->free_clusters = info->num_clusters - info->used_clusters;
if (p_fs->dev_ejected)
err = -EIO;
@@ -3351,8 +3351,8 @@ static int exfat_statfs(struct dentry *dentry, struct kstatfs *buf)
info.fat_type = p_fs->vol_type;
info.cluster_size = p_fs->cluster_size;
info.num_clusters = p_fs->num_clusters - 2;
- info.UsedClusters = p_fs->used_clusters;
- info.free_clusters = info.num_clusters - info.UsedClusters;
+ info.used_clusters = p_fs->used_clusters;
+ info.free_clusters = info.num_clusters - info.used_clusters;
if (p_fs->dev_ejected)
pr_info("[EXFAT] statfs on device that is ejected\n");
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 13/19] staging: exfat: Rename variable 'Name' to 'name'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (11 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 12/19] staging: exfat: Rename variable 'UsedClusters' to 'used_clusters' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 14/19] staging: exfat: Rename variable 'ShortName' to 'short_name' Pragat Pandya
` (5 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "Name" to "name"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 2242cf1fdb4a..e74e4d5fecd4 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -270,7 +270,7 @@ struct file_id_t {
};
struct dir_entry_t {
- char Name[MAX_NAME_LENGTH * MAX_CHARSET_SIZE];
+ char name[MAX_NAME_LENGTH * MAX_CHARSET_SIZE];
/* used only for FAT12/16/32, not used for exFAT */
char ShortName[DOS_NAME_LENGTH + 2];
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 4b8ffb8ab557..8e9684808cba 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -1465,7 +1465,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
memset((char *)&info->AccessTimestamp, 0,
sizeof(struct date_time_t));
strcpy(info->ShortName, ".");
- strcpy(info->Name, ".");
+ strcpy(info->name, ".");
dir.dir = p_fs->root_dir;
dir.flags = 0x01;
@@ -1530,7 +1530,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
*/
p_fs->fs_func->get_uni_name_from_ext_entry(sb, &fid->dir, fid->entry,
uni_name.name);
- nls_uniname_to_cstring(sb, info->Name, &uni_name);
+ nls_uniname_to_cstring(sb, info->name, &uni_name);
info->NumSubdirs = 2;
@@ -1948,7 +1948,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
*uni_name.name = 0x0;
fs_func->get_uni_name_from_ext_entry(sb, &dir, dentry,
uni_name.name);
- nls_uniname_to_cstring(sb, dir_entry->Name, &uni_name);
+ nls_uniname_to_cstring(sb, dir_entry->name, &uni_name);
exfat_buf_unlock(sb, sector);
ep = get_entry_in_dir(sb, &clu, i + 1, NULL);
@@ -1991,7 +1991,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
}
}
- *dir_entry->Name = '\0';
+ *dir_entry->name = '\0';
fid->rwoffset = (s64)(++dentry);
@@ -2129,7 +2129,7 @@ static int exfat_readdir(struct file *filp, struct dir_context *ctx)
cpos = EXFAT_I(inode)->fid.rwoffset << DENTRY_SIZE_BITS;
- if (!de.Name[0])
+ if (!de.name[0])
goto end_of_dir;
if (!memcmp(de.ShortName, DOS_CUR_DIR_NAME, DOS_NAME_LENGTH)) {
@@ -2149,7 +2149,7 @@ static int exfat_readdir(struct file *filp, struct dir_context *ctx)
}
}
- if (!dir_emit(ctx, de.Name, strlen(de.Name), inum,
+ if (!dir_emit(ctx, de.name, strlen(de.name), inum,
(de.Attr & ATTR_SUBDIR) ? DT_DIR : DT_REG))
goto out;
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 14/19] staging: exfat: Rename variable 'ShortName' to 'short_name'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (12 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 13/19] staging: exfat: Rename variable 'Name' to 'name' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 15/19] staging: exfat: Rename variable 'Attr' to 'attr' Pragat Pandya
` (4 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "ShortName" to "short_name"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index e74e4d5fecd4..099730e5b9f1 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -273,7 +273,7 @@ struct dir_entry_t {
char name[MAX_NAME_LENGTH * MAX_CHARSET_SIZE];
/* used only for FAT12/16/32, not used for exFAT */
- char ShortName[DOS_NAME_LENGTH + 2];
+ char short_name[DOS_NAME_LENGTH + 2];
u32 Attr;
u64 Size;
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 8e9684808cba..e155079722c8 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -1464,7 +1464,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
sizeof(struct date_time_t));
memset((char *)&info->AccessTimestamp, 0,
sizeof(struct date_time_t));
- strcpy(info->ShortName, ".");
+ strcpy(info->short_name, ".");
strcpy(info->name, ".");
dir.dir = p_fs->root_dir;
@@ -2132,9 +2132,9 @@ static int exfat_readdir(struct file *filp, struct dir_context *ctx)
if (!de.name[0])
goto end_of_dir;
- if (!memcmp(de.ShortName, DOS_CUR_DIR_NAME, DOS_NAME_LENGTH)) {
+ if (!memcmp(de.short_name, DOS_CUR_DIR_NAME, DOS_NAME_LENGTH)) {
inum = inode->i_ino;
- } else if (!memcmp(de.ShortName, DOS_PAR_DIR_NAME, DOS_NAME_LENGTH)) {
+ } else if (!memcmp(de.short_name, DOS_PAR_DIR_NAME, DOS_NAME_LENGTH)) {
inum = parent_ino(filp->f_path.dentry);
} else {
loff_t i_pos = ((loff_t)EXFAT_I(inode)->fid.start_clu << 32) |
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 15/19] staging: exfat: Rename variable 'Attr' to 'attr'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (13 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 14/19] staging: exfat: Rename variable 'ShortName' to 'short_name' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 16/19] staging: exfat: Rename variable 'NumSubdirs' to 'num_subdirs' Pragat Pandya
` (3 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "Attr" to "attr"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 24 ++++++++++++------------
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 099730e5b9f1..f1fa4d19a2e2 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -275,7 +275,7 @@ struct dir_entry_t {
/* used only for FAT12/16/32, not used for exFAT */
char short_name[DOS_NAME_LENGTH + 2];
- u32 Attr;
+ u32 attr;
u64 Size;
u32 NumSubdirs;
struct date_time_t CreateTimestamp;
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index e155079722c8..73d116b8d769 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -1457,7 +1457,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
if (is_dir) {
if ((fid->dir.dir == p_fs->root_dir) &&
(fid->entry == -1)) {
- info->Attr = ATTR_SUBDIR;
+ info->attr = ATTR_SUBDIR;
memset((char *)&info->CreateTimestamp, 0,
sizeof(struct date_time_t));
memset((char *)&info->ModifyTimestamp, 0,
@@ -1502,7 +1502,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
ep2 = ep + 1;
/* set FILE_INFO structure using the acquired struct dentry_t */
- info->Attr = p_fs->fs_func->get_entry_attr(ep);
+ info->attr = p_fs->fs_func->get_entry_attr(ep);
p_fs->fs_func->get_entry_time(ep, &tm, TM_CREATE);
info->CreateTimestamp.year = tm.year;
@@ -1602,7 +1602,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
}
ep2 = ep + 1;
- p_fs->fs_func->set_entry_attr(ep, info->Attr);
+ p_fs->fs_func->set_entry_attr(ep, info->attr);
/* set FILE_INFO structure using the acquired struct dentry_t */
tm.sec = info->CreateTimestamp.second;
@@ -1922,7 +1922,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
continue;
exfat_buf_lock(sb, sector);
- dir_entry->Attr = fs_func->get_entry_attr(ep);
+ dir_entry->attr = fs_func->get_entry_attr(ep);
fs_func->get_entry_time(ep, &tm, TM_CREATE);
dir_entry->CreateTimestamp.year = tm.year;
@@ -2150,7 +2150,7 @@ static int exfat_readdir(struct file *filp, struct dir_context *ctx)
}
if (!dir_emit(ctx, de.name, strlen(de.name), inum,
- (de.Attr & ATTR_SUBDIR) ? DT_DIR : DT_REG))
+ (de.attr & ATTR_SUBDIR) ? DT_DIR : DT_REG))
goto out;
ctx->pos = cpos;
@@ -3159,25 +3159,25 @@ static int exfat_fill_inode(struct inode *inode, struct file_id_t *fid)
INC_IVERSION(inode);
inode->i_generation = prandom_u32();
- if (info.Attr & ATTR_SUBDIR) { /* directory */
+ if (info.attr & ATTR_SUBDIR) { /* directory */
inode->i_generation &= ~1;
- inode->i_mode = exfat_make_mode(sbi, info.Attr, 0777);
+ inode->i_mode = exfat_make_mode(sbi, info.attr, 0777);
inode->i_op = &exfat_dir_inode_operations;
inode->i_fop = &exfat_dir_operations;
i_size_write(inode, info.Size);
EXFAT_I(inode)->mmu_private = i_size_read(inode);
set_nlink(inode, info.NumSubdirs);
- } else if (info.Attr & ATTR_SYMLINK) { /* symbolic link */
+ } else if (info.attr & ATTR_SYMLINK) { /* symbolic link */
inode->i_generation |= 1;
- inode->i_mode = exfat_make_mode(sbi, info.Attr, 0777);
+ inode->i_mode = exfat_make_mode(sbi, info.attr, 0777);
inode->i_op = &exfat_symlink_inode_operations;
i_size_write(inode, info.Size);
EXFAT_I(inode)->mmu_private = i_size_read(inode);
} else { /* regular file */
inode->i_generation |= 1;
- inode->i_mode = exfat_make_mode(sbi, info.Attr, 0777);
+ inode->i_mode = exfat_make_mode(sbi, info.attr, 0777);
inode->i_op = &exfat_file_inode_operations;
inode->i_fop = &exfat_file_operations;
inode->i_mapping->a_ops = &exfat_aops;
@@ -3186,7 +3186,7 @@ static int exfat_fill_inode(struct inode *inode, struct file_id_t *fid)
i_size_write(inode, info.Size);
EXFAT_I(inode)->mmu_private = i_size_read(inode);
}
- exfat_save_attr(inode, info.Attr);
+ exfat_save_attr(inode, info.attr);
inode->i_blocks = ((i_size_read(inode) + (p_fs->cluster_size - 1))
& ~((loff_t)p_fs->cluster_size - 1)) >> 9;
@@ -3259,7 +3259,7 @@ static int exfat_write_inode(struct inode *inode, struct writeback_control *wbc)
if (inode->i_ino == EXFAT_ROOT_INO)
return 0;
- info.Attr = exfat_make_attr(inode);
+ info.attr = exfat_make_attr(inode);
info.Size = i_size_read(inode);
exfat_time_unix2fat(&inode->i_mtime, &info.ModifyTimestamp);
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 16/19] staging: exfat: Rename variable 'NumSubdirs' to 'num_subdirs'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (14 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 15/19] staging: exfat: Rename variable 'Attr' to 'attr' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 17/19] staging: exfat: Rename variable 'CreateTimestamp' to 'create_timestamp' Pragat Pandya
` (2 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "NumSubdirs" to "num_subdirs"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index f1fa4d19a2e2..0b5ec053bb26 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -277,7 +277,7 @@ struct dir_entry_t {
u32 attr;
u64 Size;
- u32 NumSubdirs;
+ u32 num_subdirs;
struct date_time_t CreateTimestamp;
struct date_time_t ModifyTimestamp;
struct date_time_t AccessTimestamp;
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 73d116b8d769..14a10f6f8653 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -1484,7 +1484,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
ret = count; /* propogate error upward */
goto out;
}
- info->NumSubdirs = count;
+ info->num_subdirs = count;
if (p_fs->dev_ejected)
ret = -EIO;
@@ -1532,7 +1532,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
uni_name.name);
nls_uniname_to_cstring(sb, info->name, &uni_name);
- info->NumSubdirs = 2;
+ info->num_subdirs = 2;
info->Size = p_fs->fs_func->get_entry_size(ep2);
@@ -1551,7 +1551,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
ret = count; /* propogate error upward */
goto out;
}
- info->NumSubdirs += count;
+ info->num_subdirs += count;
}
if (p_fs->dev_ejected)
@@ -3167,7 +3167,7 @@ static int exfat_fill_inode(struct inode *inode, struct file_id_t *fid)
i_size_write(inode, info.Size);
EXFAT_I(inode)->mmu_private = i_size_read(inode);
- set_nlink(inode, info.NumSubdirs);
+ set_nlink(inode, info.num_subdirs);
} else if (info.attr & ATTR_SYMLINK) { /* symbolic link */
inode->i_generation |= 1;
inode->i_mode = exfat_make_mode(sbi, info.attr, 0777);
@@ -3667,7 +3667,7 @@ static int exfat_read_root(struct inode *inode)
inode->i_mtime = curtime;
inode->i_atime = curtime;
inode->i_ctime = curtime;
- set_nlink(inode, info.NumSubdirs + 2);
+ set_nlink(inode, info.num_subdirs + 2);
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 17/19] staging: exfat: Rename variable 'CreateTimestamp' to 'create_timestamp'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (15 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 16/19] staging: exfat: Rename variable 'NumSubdirs' to 'num_subdirs' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 18/19] staging: exfat: Rename variable 'ModifyTimestamp' to 'modify_timestamp' Pragat Pandya
2020-01-29 16:58 ` [PATCH 19/19] staging: exfat: Rename variable 'AccessTimestamp' to 'access_timestamp' Pragat Pandya
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "CreateTimestamp" to
"create_timestamp"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 46 ++++++++++++++---------------
2 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 0b5ec053bb26..58db8ea700f8 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -278,7 +278,7 @@ struct dir_entry_t {
u32 attr;
u64 Size;
u32 num_subdirs;
- struct date_time_t CreateTimestamp;
+ struct date_time_t create_timestamp;
struct date_time_t ModifyTimestamp;
struct date_time_t AccessTimestamp;
};
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 14a10f6f8653..694acfd8c52a 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -1458,7 +1458,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
if ((fid->dir.dir == p_fs->root_dir) &&
(fid->entry == -1)) {
info->attr = ATTR_SUBDIR;
- memset((char *)&info->CreateTimestamp, 0,
+ memset((char *)&info->create_timestamp, 0,
sizeof(struct date_time_t));
memset((char *)&info->ModifyTimestamp, 0,
sizeof(struct date_time_t));
@@ -1505,13 +1505,13 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->attr = p_fs->fs_func->get_entry_attr(ep);
p_fs->fs_func->get_entry_time(ep, &tm, TM_CREATE);
- info->CreateTimestamp.year = tm.year;
- info->CreateTimestamp.month = tm.mon;
- info->CreateTimestamp.day = tm.day;
- info->CreateTimestamp.hour = tm.hour;
- info->CreateTimestamp.minute = tm.min;
- info->CreateTimestamp.second = tm.sec;
- info->CreateTimestamp.millisecond = 0;
+ info->create_timestamp.year = tm.year;
+ info->create_timestamp.month = tm.mon;
+ info->create_timestamp.day = tm.day;
+ info->create_timestamp.hour = tm.hour;
+ info->create_timestamp.minute = tm.min;
+ info->create_timestamp.second = tm.sec;
+ info->create_timestamp.millisecond = 0;
p_fs->fs_func->get_entry_time(ep, &tm, TM_MODIFY);
info->ModifyTimestamp.year = tm.year;
@@ -1605,12 +1605,12 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
p_fs->fs_func->set_entry_attr(ep, info->attr);
/* set FILE_INFO structure using the acquired struct dentry_t */
- tm.sec = info->CreateTimestamp.second;
- tm.min = info->CreateTimestamp.minute;
- tm.hour = info->CreateTimestamp.hour;
- tm.day = info->CreateTimestamp.day;
- tm.mon = info->CreateTimestamp.month;
- tm.year = info->CreateTimestamp.year;
+ tm.sec = info->create_timestamp.second;
+ tm.min = info->create_timestamp.minute;
+ tm.hour = info->create_timestamp.hour;
+ tm.day = info->create_timestamp.day;
+ tm.mon = info->create_timestamp.month;
+ tm.year = info->create_timestamp.year;
p_fs->fs_func->set_entry_time(ep, &tm, TM_CREATE);
tm.sec = info->ModifyTimestamp.second;
@@ -1925,13 +1925,13 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
dir_entry->attr = fs_func->get_entry_attr(ep);
fs_func->get_entry_time(ep, &tm, TM_CREATE);
- dir_entry->CreateTimestamp.year = tm.year;
- dir_entry->CreateTimestamp.month = tm.mon;
- dir_entry->CreateTimestamp.day = tm.day;
- dir_entry->CreateTimestamp.hour = tm.hour;
- dir_entry->CreateTimestamp.minute = tm.min;
- dir_entry->CreateTimestamp.second = tm.sec;
- dir_entry->CreateTimestamp.millisecond = 0;
+ dir_entry->create_timestamp.year = tm.year;
+ dir_entry->create_timestamp.month = tm.mon;
+ dir_entry->create_timestamp.day = tm.day;
+ dir_entry->create_timestamp.hour = tm.hour;
+ dir_entry->create_timestamp.minute = tm.min;
+ dir_entry->create_timestamp.second = tm.sec;
+ dir_entry->create_timestamp.millisecond = 0;
fs_func->get_entry_time(ep, &tm, TM_MODIFY);
dir_entry->ModifyTimestamp.year = tm.year;
@@ -3192,7 +3192,7 @@ static int exfat_fill_inode(struct inode *inode, struct file_id_t *fid)
& ~((loff_t)p_fs->cluster_size - 1)) >> 9;
exfat_time_fat2unix(&inode->i_mtime, &info.ModifyTimestamp);
- exfat_time_fat2unix(&inode->i_ctime, &info.CreateTimestamp);
+ exfat_time_fat2unix(&inode->i_ctime, &info.create_timestamp);
exfat_time_fat2unix(&inode->i_atime, &info.AccessTimestamp);
return 0;
@@ -3263,7 +3263,7 @@ static int exfat_write_inode(struct inode *inode, struct writeback_control *wbc)
info.Size = i_size_read(inode);
exfat_time_unix2fat(&inode->i_mtime, &info.ModifyTimestamp);
- exfat_time_unix2fat(&inode->i_ctime, &info.CreateTimestamp);
+ exfat_time_unix2fat(&inode->i_ctime, &info.create_timestamp);
exfat_time_unix2fat(&inode->i_atime, &info.AccessTimestamp);
ffsWriteStat(inode, &info);
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 18/19] staging: exfat: Rename variable 'ModifyTimestamp' to 'modify_timestamp'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (16 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 17/19] staging: exfat: Rename variable 'CreateTimestamp' to 'create_timestamp' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
2020-01-29 16:58 ` [PATCH 19/19] staging: exfat: Rename variable 'AccessTimestamp' to 'access_timestamp' Pragat Pandya
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of "ModifyTimestamp" to "modify_timestamp"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 46 ++++++++++++++---------------
2 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 58db8ea700f8..323048cd1903 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -279,7 +279,7 @@ struct dir_entry_t {
u64 Size;
u32 num_subdirs;
struct date_time_t create_timestamp;
- struct date_time_t ModifyTimestamp;
+ struct date_time_t modify_timestamp;
struct date_time_t AccessTimestamp;
};
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 694acfd8c52a..92670913971f 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -1460,7 +1460,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->attr = ATTR_SUBDIR;
memset((char *)&info->create_timestamp, 0,
sizeof(struct date_time_t));
- memset((char *)&info->ModifyTimestamp, 0,
+ memset((char *)&info->modify_timestamp, 0,
sizeof(struct date_time_t));
memset((char *)&info->AccessTimestamp, 0,
sizeof(struct date_time_t));
@@ -1514,13 +1514,13 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->create_timestamp.millisecond = 0;
p_fs->fs_func->get_entry_time(ep, &tm, TM_MODIFY);
- info->ModifyTimestamp.year = tm.year;
- info->ModifyTimestamp.month = tm.mon;
- info->ModifyTimestamp.day = tm.day;
- info->ModifyTimestamp.hour = tm.hour;
- info->ModifyTimestamp.minute = tm.min;
- info->ModifyTimestamp.second = tm.sec;
- info->ModifyTimestamp.millisecond = 0;
+ info->modify_timestamp.year = tm.year;
+ info->modify_timestamp.month = tm.mon;
+ info->modify_timestamp.day = tm.day;
+ info->modify_timestamp.hour = tm.hour;
+ info->modify_timestamp.minute = tm.min;
+ info->modify_timestamp.second = tm.sec;
+ info->modify_timestamp.millisecond = 0;
memset((char *)&info->AccessTimestamp, 0, sizeof(struct date_time_t));
@@ -1613,12 +1613,12 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
tm.year = info->create_timestamp.year;
p_fs->fs_func->set_entry_time(ep, &tm, TM_CREATE);
- tm.sec = info->ModifyTimestamp.second;
- tm.min = info->ModifyTimestamp.minute;
- tm.hour = info->ModifyTimestamp.hour;
- tm.day = info->ModifyTimestamp.day;
- tm.mon = info->ModifyTimestamp.month;
- tm.year = info->ModifyTimestamp.year;
+ tm.sec = info->modify_timestamp.second;
+ tm.min = info->modify_timestamp.minute;
+ tm.hour = info->modify_timestamp.hour;
+ tm.day = info->modify_timestamp.day;
+ tm.mon = info->modify_timestamp.month;
+ tm.year = info->modify_timestamp.year;
p_fs->fs_func->set_entry_time(ep, &tm, TM_MODIFY);
p_fs->fs_func->set_entry_size(ep2, info->Size);
@@ -1934,13 +1934,13 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
dir_entry->create_timestamp.millisecond = 0;
fs_func->get_entry_time(ep, &tm, TM_MODIFY);
- dir_entry->ModifyTimestamp.year = tm.year;
- dir_entry->ModifyTimestamp.month = tm.mon;
- dir_entry->ModifyTimestamp.day = tm.day;
- dir_entry->ModifyTimestamp.hour = tm.hour;
- dir_entry->ModifyTimestamp.minute = tm.min;
- dir_entry->ModifyTimestamp.second = tm.sec;
- dir_entry->ModifyTimestamp.millisecond = 0;
+ dir_entry->modify_timestamp.year = tm.year;
+ dir_entry->modify_timestamp.month = tm.mon;
+ dir_entry->modify_timestamp.day = tm.day;
+ dir_entry->modify_timestamp.hour = tm.hour;
+ dir_entry->modify_timestamp.minute = tm.min;
+ dir_entry->modify_timestamp.second = tm.sec;
+ dir_entry->modify_timestamp.millisecond = 0;
memset((char *)&dir_entry->AccessTimestamp, 0,
sizeof(struct date_time_t));
@@ -3191,7 +3191,7 @@ static int exfat_fill_inode(struct inode *inode, struct file_id_t *fid)
inode->i_blocks = ((i_size_read(inode) + (p_fs->cluster_size - 1))
& ~((loff_t)p_fs->cluster_size - 1)) >> 9;
- exfat_time_fat2unix(&inode->i_mtime, &info.ModifyTimestamp);
+ exfat_time_fat2unix(&inode->i_mtime, &info.modify_timestamp);
exfat_time_fat2unix(&inode->i_ctime, &info.create_timestamp);
exfat_time_fat2unix(&inode->i_atime, &info.AccessTimestamp);
@@ -3262,7 +3262,7 @@ static int exfat_write_inode(struct inode *inode, struct writeback_control *wbc)
info.attr = exfat_make_attr(inode);
info.Size = i_size_read(inode);
- exfat_time_unix2fat(&inode->i_mtime, &info.ModifyTimestamp);
+ exfat_time_unix2fat(&inode->i_mtime, &info.modify_timestamp);
exfat_time_unix2fat(&inode->i_ctime, &info.create_timestamp);
exfat_time_unix2fat(&inode->i_atime, &info.AccessTimestamp);
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 19/19] staging: exfat: Rename variable 'AccessTimestamp' to 'access_timestamp'
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
` (17 preceding siblings ...)
2020-01-29 16:58 ` [PATCH 18/19] staging: exfat: Rename variable 'ModifyTimestamp' to 'modify_timestamp' Pragat Pandya
@ 2020-01-29 16:58 ` Pragat Pandya
18 siblings, 0 replies; 20+ messages in thread
From: Pragat Pandya @ 2020-01-29 16:58 UTC (permalink / raw)
To: gregkh, valdis.kletnieks
Cc: devel, linux-kernel, skhan, linux-fsdevel, linux-kernel-mentees,
Pragat Pandya
Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "AccessTimestamp" to
"access_timestamp"
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_super.c | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 323048cd1903..29762946e773 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -280,7 +280,7 @@ struct dir_entry_t {
u32 num_subdirs;
struct date_time_t create_timestamp;
struct date_time_t modify_timestamp;
- struct date_time_t AccessTimestamp;
+ struct date_time_t access_timestamp;
};
struct timestamp_t {
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 92670913971f..d78172d3f6b7 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -1462,7 +1462,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
sizeof(struct date_time_t));
memset((char *)&info->modify_timestamp, 0,
sizeof(struct date_time_t));
- memset((char *)&info->AccessTimestamp, 0,
+ memset((char *)&info->access_timestamp, 0,
sizeof(struct date_time_t));
strcpy(info->short_name, ".");
strcpy(info->name, ".");
@@ -1522,7 +1522,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
info->modify_timestamp.second = tm.sec;
info->modify_timestamp.millisecond = 0;
- memset((char *)&info->AccessTimestamp, 0, sizeof(struct date_time_t));
+ memset((char *)&info->access_timestamp, 0, sizeof(struct date_time_t));
*uni_name.name = 0x0;
/* XXX this is very bad for exfat cuz name is already included in es.
@@ -1942,7 +1942,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
dir_entry->modify_timestamp.second = tm.sec;
dir_entry->modify_timestamp.millisecond = 0;
- memset((char *)&dir_entry->AccessTimestamp, 0,
+ memset((char *)&dir_entry->access_timestamp, 0,
sizeof(struct date_time_t));
*uni_name.name = 0x0;
@@ -3193,7 +3193,7 @@ static int exfat_fill_inode(struct inode *inode, struct file_id_t *fid)
exfat_time_fat2unix(&inode->i_mtime, &info.modify_timestamp);
exfat_time_fat2unix(&inode->i_ctime, &info.create_timestamp);
- exfat_time_fat2unix(&inode->i_atime, &info.AccessTimestamp);
+ exfat_time_fat2unix(&inode->i_atime, &info.access_timestamp);
return 0;
}
@@ -3264,7 +3264,7 @@ static int exfat_write_inode(struct inode *inode, struct writeback_control *wbc)
exfat_time_unix2fat(&inode->i_mtime, &info.modify_timestamp);
exfat_time_unix2fat(&inode->i_ctime, &info.create_timestamp);
- exfat_time_unix2fat(&inode->i_atime, &info.AccessTimestamp);
+ exfat_time_unix2fat(&inode->i_atime, &info.access_timestamp);
ffsWriteStat(inode, &info);
--
2.17.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
end of thread, other threads:[~2020-01-29 17:00 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-29 16:58 [PATCH 00/19] Renaming some identifiers Pragat Pandya
2020-01-29 16:58 ` [PATCH 01/19] staging: exfat: Rename variable 'Year' to 'year' Pragat Pandya
2020-01-29 16:58 ` [PATCH 02/19] staging: exfat: Rename variable 'Month' to 'month' Pragat Pandya
2020-01-29 16:58 ` [PATCH 03/19] staging: exfat: Rename variable 'Day' to 'day' Pragat Pandya
2020-01-29 16:58 ` [PATCH 04/19] staging: exfat: Rename variable 'Hour' to 'hour' Pragat Pandya
2020-01-29 16:58 ` [PATCH 05/19] staging: exfat: Rename variable 'Minute' to 'minute' Pragat Pandya
2020-01-29 16:58 ` [PATCH 06/19] staging: exfat: Rename variable 'Second' to 'second' Pragat Pandya
2020-01-29 16:58 ` [PATCH 07/19] staging: exfat: Rename variable 'MilliSecond' to 'millisecond' Pragat Pandya
2020-01-29 16:58 ` [PATCH 08/19] staging: exfat: Rename variable 'FatType' to 'fat_type' Pragat Pandya
2020-01-29 16:58 ` [PATCH 09/19] staging: exfat: Rename variable 'ClusterSize' to 'cluster_size' Pragat Pandya
2020-01-29 16:58 ` [PATCH 10/19] staging: exfat: Rename variable 'NumClusters' to 'num_cluster' Pragat Pandya
2020-01-29 16:58 ` [PATCH 11/19] staging: exfat: Rename variable 'FreeClusters' to 'free_clusters' Pragat Pandya
2020-01-29 16:58 ` [PATCH 12/19] staging: exfat: Rename variable 'UsedClusters' to 'used_clusters' Pragat Pandya
2020-01-29 16:58 ` [PATCH 13/19] staging: exfat: Rename variable 'Name' to 'name' Pragat Pandya
2020-01-29 16:58 ` [PATCH 14/19] staging: exfat: Rename variable 'ShortName' to 'short_name' Pragat Pandya
2020-01-29 16:58 ` [PATCH 15/19] staging: exfat: Rename variable 'Attr' to 'attr' Pragat Pandya
2020-01-29 16:58 ` [PATCH 16/19] staging: exfat: Rename variable 'NumSubdirs' to 'num_subdirs' Pragat Pandya
2020-01-29 16:58 ` [PATCH 17/19] staging: exfat: Rename variable 'CreateTimestamp' to 'create_timestamp' Pragat Pandya
2020-01-29 16:58 ` [PATCH 18/19] staging: exfat: Rename variable 'ModifyTimestamp' to 'modify_timestamp' Pragat Pandya
2020-01-29 16:58 ` [PATCH 19/19] staging: exfat: Rename variable 'AccessTimestamp' to 'access_timestamp' Pragat Pandya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).